Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Jonathan Druart d8dd31142c
Bug 13518: Delete patron's modifications along with the patron 
The table borrower_modifications has no FK constraint on the borrowernumber
and will remain untouched when the patron is deleted.
If the borrowernumber doesn't exist in the database, the modification entry is no longer visible in Koha.

The problem is that this table is used for the borrower modifications and the self-registration features.

So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the self-registration feature we can have borrowernumber that is not defined (0 is used)

Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for self-reg, but then we will loose the PK (PK cannot be NULL).

As we cannot keep the correct constraints at DB level anyway, we will need to handle consistency at code-level.

Test plan:
Create a new patron
Do some modification at the OPAC
Delete the patron
Confirm that the modifications as been removed (directly in DB)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2020-04-20 12:19:16 +01:00
..
Acquisition Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent 2020-04-14 16:39:06 +01:00
api/v1 Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
Auth
Authority
Biblio Bug 24715: Cache repeatable subfield in TransformKohaToMarc 2020-04-17 09:25:06 +01:00
Circulation Bug 24380: (QA follow-up) Do not use compare float with precision 2020-04-15 12:28:45 +01:00
CourseReserves Bug 23727: Editing course reserve items is broken 2020-04-17 13:45:56 +01:00
Creators
cronjobs Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
data
Exporter
Holds Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Illrequest Bug 23173: Add unit tests 2020-04-06 11:04:36 +01:00
Items Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t subtest 2020-03-23 09:26:33 +00:00
Koha Bug 13518: Delete patron's modifications along with the patron 2020-04-20 12:19:16 +01:00
Labels Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
LDAP
Letters Bug 21901: (RM follow-up) Use TestBuilder to fix tests 2020-04-17 13:37:33 +01:00
Members Bug 20443: Remove extended_attributes_code_value_arrayref AND C4::Members::Attributes 2020-03-23 13:49:22 +00:00
OAI Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Patron Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Record Bug 24029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t 2019-11-13 13:22:11 +00:00
Reports Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
Reserves Bug 14711: Change prototype for AddReserve - pass a hashref 2020-02-11 14:32:47 +00:00
Search
selenium Bug 24801: (follow-up) Display all the libraries - Selenium fix 2020-04-08 08:16:13 +01:00
Serials Bug 7046: Implemented subscription renewal dropdown sub length element 2020-04-08 11:48:03 +01:00
SIP Bug 24966: Add unit tests 2020-04-14 08:27:14 +01:00
Template/Plugin Bug 21503: Restore existing ternary operator logic 2020-03-24 11:30:08 +00:00
Utils Bug 25046: Add test 2020-04-08 11:51:48 +01:00
www Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
00-strict.t
01-test_dbic.t
Accounts.t Bug 24818: (RM follow-up) Update tests for DATE -> TIMESTAMP change 2020-03-19 13:05:58 +00:00
Acquisition.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Amazon.t
ArticleRequests.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
AudioAlerts.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth.t Bug 24145: (bug 22543 follow-up) Fix Auth.t 2019-12-02 17:13:27 +00:00
Auth_with_cas.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth_with_ldap.t Bug 20443: Remove UpdateBorrowerAttribute and SetBorrowerAttributes 2020-03-23 13:44:16 +00:00
AuthorisedValues.t Bug 23272: Adapt controller and tests 2019-09-13 08:04:15 +01:00
AuthoritiesMarc.t
BackgroundJob.t Bug 24760: (follow-up) Add a neighboring test messsage 2020-03-06 14:58:47 +00:00
Barcodes.t
Barcodes_ValueBuilder.t
Biblio.t Bug 21901: Add FK on subscription and serial tables 2020-04-17 09:39:00 +01:00
Bookseller.t Bug 18177: remove aqbooksellers.currency 2020-03-27 12:15:55 +00:00
Breeding.t Bug 24052: Fix Koha/XSLT/Base.t 2020-03-24 10:42:23 +00:00
Budgets.t
Cache.t
Calendar.t Bug 23974: Add test descriptions 2020-01-10 08:23:50 +00:00
Charset.t
check_kohastructure.t
check_sysprefs.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
Circulation.t Bug 24620: Fix test, remove replaced code, use dt_from_string 2020-04-14 17:24:41 +01:00
Clubs.t
ColumnsSettings.t
Context.t
Contract.t
CourseReserves.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
db_structure.t
DecreaseLoanHighHolds.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Filter_MARC_ViewPolicy.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Fines.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
FrameworkPlugin.t
Heading.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Heading_MARC21.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Hold.t Bug 21684: Fix Hold.t 2020-01-07 16:33:04 +00:00
Holds.t Bug 23463: Fix tests 2020-03-23 09:26:34 +00:00
HoldsQueue.t Bug 14711: Change prototype for AddReserve - pass a hashref 2020-02-11 14:32:47 +00:00
Holidays.t Bug 19475: Clear the caches at the end of the tests 2020-04-03 14:26:33 +01:00
Illcomments.t
Illrequestattributes.t
Illrequests.t Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
ILSDI_Services.t Bug 20443: (follow-up) Move GetBorrowerAttributes to Koha::Patron - ILSDI 2020-03-23 13:49:22 +00:00
ImportBatch.t Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
ImportExportFramework.t
Installer.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Items.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Koha.t Bug 22302: Unit tests 2020-02-05 12:35:24 +00:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t
Koha_ExternalContent_OverDrive.t
Koha_ExternalContent_RecordedBooks.t
Koha_Misc_Files.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Languages.t
Letters.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
LibraryGroups.t Bug 22284: New methods in Koha::Library::Groups and Koha::Library 2020-01-03 12:58:03 +00:00
Linker_Default.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Linker_FirstMatch.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Log.t Bug 21190: Add tests for authentication success and failure 2020-04-14 16:13:39 +01:00
MarcModificationTemplates.t Bug 24900: Checks in MARC mod templates for when from field does not equal conditional field 2020-04-03 14:26:31 +01:00
Members.t Bug 23579: (RM follow-up) Fix failing tests 2019-10-25 13:13:26 +01:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t Bug 24408: Do not compare floats with precision in tests 2020-01-13 13:42:45 +00:00
Passwordrecovery.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Patroncards.t
PatronLists.t
Patrons.t Bug 17168: (QA follow-up) Only remove guarantor relationship if not Child AND not Professional 2019-10-26 07:37:42 +01:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Reports.t
Reserves.t Bug 24468: Remove unused C4::Reserves::_get_itype subroutine 2020-03-24 10:57:13 +00:00
rollingloans.t
RotatingCollections.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
Search.t Bug 24735: Remove more code from tests 2020-03-02 11:13:11 +00:00
Serials.t Bug 21901: (RM follow-up) Use TestBuilder to fix tests 2020-04-17 13:37:33 +01:00
Serials_2.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Service.t
ShelfBrowser.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Sitemapper.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Stats.t
StockRotationItems.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationRotas.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
StockRotationStages.t Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
SuggestionEngine_ExplodedTerms.t
Suggestions.t Bug 22778: Add unit test 2020-04-14 08:19:34 +01:00
sysprefs.t Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. 2020-02-24 13:24:25 +00:00
Tags.t
Templates.t
TestBuilder.t Bug 18936: (follow-up) Add foreign key and scope enhancement to circ rules 2020-02-04 09:56:24 +00:00
Upload.t Bug 21684: Fix UploadedFile[s]->delete 2020-01-07 16:32:53 +00:00
UsageStats.t Bug 25147: (RM follow-up) Update pref references. 2020-04-17 09:03:47 +01:00
Virtualshelves.t Bug 21684: Adjust some tests 2020-01-03 10:58:51 +00:00
XISBN.t Bug 23274: Mock simple_search_compat to cover both search engines 2020-01-10 10:48:53 +00:00
XSLT.t Bug 23463: Fix XSLT.t 2020-03-23 09:26:34 +00:00
zebra_config.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00