b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
30 lines
789 B
Perl
Executable file
30 lines
789 B
Perl
Executable file
#!/usr/bin/perl
|
|
## This script allows you to export a rel_2_2 bibliographic db in
|
|
#MARC21 format from the command line.
|
|
#
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
BEGIN {
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/kohalib.pl" };
|
|
}
|
|
|
|
use Koha::Script;
|
|
use C4::Context;
|
|
use C4::Biblio;
|
|
use C4::Auth;
|
|
my $outfile = $ARGV[0];
|
|
open(my $fh, '>', $outfile) or die $!;
|
|
my $dbh=C4::Context->dbh;
|
|
#$dbh->do("set character_set_client='latin5'");
|
|
$dbh->do("set character_set_connection='utf8'");
|
|
#$dbh->do("set character_set_results='latin5'");
|
|
my $sth=$dbh->prepare("select marc from auth_header order by authid");
|
|
$sth->execute();
|
|
while (my ($marc) = $sth->fetchrow) {
|
|
print $fh $marc;
|
|
}
|
|
close($fh);
|