Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin
History
Alex Buckley db3ebe47e8 Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl 
Removed the sql code from Itemtypes.pm and replaced  it with DBIx
database query in the itemtypes.pl administrative script

Test plan:
1. In the staff interface, stage and manage MARC records for import

2. Try to delete an itemtype. If there are items of that itemtype in the
   database then a message telling you the number of items of that
   itemtype there are will be displayed.

3. Record that number

4. View the admin/itemtpes.pl script and confirm that there is sql code
   written in this file.

5. Apply this patch

6. View the admin/itemtypes.pl script and observe that there is no sql
   in this file. There is however DBIx code, for example
   $schema->resultset('Item')->search({ 'itype' => $itemtype_code} );
   which is searching for items with the itype value matching
   $itemtype_code value.

7. In the staff interface try to delete the same itemtype

8. Record the number of items there are with that itemtype in the
   resulting message

9. The numbers recorded in steps 3 and 8 should match showing that the
   DBIx code is working as intended

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-06-05 11:59:10 -03:00
..
searchengine/elasticsearch Bug 17169: (QA followup) Add NORMARC and UNIMARC definitions for CCODE 2017-03-22 19:24:22 +00:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
admin-home.pl Bug 9021 [QA Followup] - Use TT plugin instead of passing syspref via script 2016-02-14 12:40:05 +00:00
aqbudgetperiods.pl Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls 2017-04-13 08:34:15 -04:00
aqbudgets.pl Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls 2017-04-13 08:34:15 -04:00
aqcontract.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
aqplan.pl Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
audio_alerts.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
auth_subfields_structure.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
auth_tag_structure.pl Bug 18376: Do not need to prepare a single statement, use do 2017-05-19 09:53:14 -04:00
authorised_values.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
authtypes.pl Bug 16012: Restore the ability to edit default authority type 2016-03-21 22:41:44 +00:00
biblio_framework.pl Bug 17189: Replace occurrences of 'use Koha::Cache' 2016-09-08 10:24:47 +00:00
branch_transfer_limits.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
branches.pl Bug 16259: Replace CGI->param with CGI->multi_param in list context - part 2 2016-05-16 17:28:06 +00:00
categories.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
check_budget_parent.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
check_parent_total.pl Bug 14383: admin: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
checkmarc.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
cities.pl Bug 14888: Update copyright and wording 2015-10-05 12:00:38 -03:00
classsources.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
clone-rules.pl Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
columns_settings.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
columns_settings.yml Bug 17346: Make checkin column hidable 2017-03-31 13:24:02 +00:00
currency.pl Bug 18662: Fix currency deletion 2017-05-28 22:01:39 -04:00
didyoumean.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
edi_accounts.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
edi_ean_accounts.pl Bug 17692: Remove 'CGI::param called in list context' warnings 2016-12-21 12:27:29 +00:00
fieldmapping.pl Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
import_export_framework.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
item_circulation_alerts.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
items_search_field.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
items_search_fields.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
itemtypes.pl Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl 2017-06-05 11:59:10 -03:00
koha2marclinks.pl Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences 2016-09-08 10:24:46 +00:00
localization.pl Bug 14100: Generic solution for language overlay - Item types 2015-10-27 12:34:06 -03:00
marc_subfields_structure.pl Bug 17216: Use Koha::AVC from mss.pl 2016-10-11 07:30:31 +00:00
marctagstructure.pl Bug 15803: Koha::AuthorisedValues - Remove C4::Koha::GetAuthorisedValueCategories 2016-10-28 16:35:52 +00:00
matching-rules.pl Bug 17318: Allow chosing fixed normalization routines 2016-10-21 16:16:34 +00:00
oai_set_mappings.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
oai_sets.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
patron-attr-types.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
preferences.pl Bug 18026: Correct URL to database columns from .pref files 2017-02-21 19:54:23 +00:00
printers.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
smart-rules.pl Bug 16344: Add a circ rule to limit the auto renewals given a specific 2017-04-28 09:15:21 -04:00
sms_providers.pl Bug 9021 [QA Followup] - Switch to Koha::Object(s) 2016-02-14 12:40:06 +00:00
sru_modmapping.pl Bug 6536: Add a form for SRU Field mapping 2014-09-01 10:08:50 -03:00
systempreferences.pl Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
transport-cost-matrix.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
usage_statistics.pl Bug 18066: Hea V2 2017-03-23 00:10:46 +00:00
z3950servers.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00