35938a0cb3
When you attempt to edit the manual history for a subscription,
the title is blank. This is a result of an incorrect use of the
GetBiblio function.
TEST PLAN
---------
1) Log in to staff client
2) Serials
3) Search for an existing serial with manual history checked.
-- creating one as needed is left as an exercise to the reader.
4) Click on the title of the serial for the details page.
5) Go to the Planning tab and click 'Edit History'
-- Heading will be 'Subscription history for' without a
title.
6) Apply patch
7) Refresh page.
-- Heading will include the title correctly.
8) run koha qa test tools
Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
88 lines
2.8 KiB
Perl
Executable file
88 lines
2.8 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2011-2013 Biblibre SARL
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 NAME
|
|
|
|
subscription-history.pl
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
Modify subscription history
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
|
|
use C4::Biblio;
|
|
use C4::Dates qw(format_date_in_iso);
|
|
use C4::Serials;
|
|
|
|
my $input = new CGI;
|
|
my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( {
|
|
template_name => 'serials/subscription-history.tt',
|
|
query => $input,
|
|
type => 'intranet',
|
|
authnotrequired => 0,
|
|
flagsrequired => { 'serials' => 'edit_subscription' },
|
|
debug => 1,
|
|
} );
|
|
|
|
my $subscriptionid = $input->param('subscriptionid');
|
|
my $op = $input->param('op');
|
|
|
|
if(!defined $subscriptionid || $subscriptionid eq '') {
|
|
print $input->redirect('/cgi-bin/koha/serials/serials-home.pl');
|
|
exit;
|
|
}
|
|
|
|
if($op && $op eq 'mod') {
|
|
my $histstartdate = $input->param('histstartdate');
|
|
my $histenddate = $input->param('histenddate');
|
|
my $receivedlist = $input->param('receivedlist');
|
|
my $missinglist = $input->param('missinglist');
|
|
my $opacnote = $input->param('opacnote');
|
|
my $librariannote = $input->param('librariannote');
|
|
|
|
ModSubscriptionHistory( $subscriptionid, format_date_in_iso($histstartdate),
|
|
format_date_in_iso($histenddate), $receivedlist, $missinglist, $opacnote,
|
|
$librariannote );
|
|
|
|
print $input->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
|
|
exit;
|
|
} else {
|
|
my $history = GetSubscriptionHistoryFromSubscriptionId($subscriptionid);
|
|
my $biblio = GetBiblio($history->{'biblionumber'});
|
|
|
|
$template->param(
|
|
subscriptionid => $subscriptionid,
|
|
title => $biblio->{'title'},
|
|
histstartdate => $history->{'histstartdate'},
|
|
histenddate => $history->{'histenddate'},
|
|
receivedlist => $history->{'recievedlist'},
|
|
missinglist => $history->{'missinglist'},
|
|
opacnote => $history->{'opacnote'},
|
|
librariannote => $history->{'librariannote'},
|
|
);
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
}
|