dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
75 lines
3.5 KiB
PHP
75 lines
3.5 KiB
PHP
[%- USE Koha -%]
|
|
[%- USE Branches -%]
|
|
[%- SET data = {} -%]
|
|
[%- IF patron -%]
|
|
[%- SET data.category_type = patron.category.category_type -%]
|
|
[%- SET data.surname = patron.surname -%]
|
|
[%- SET data.othernames = patron.othernames -%]
|
|
[%- SET data.firstname = patron.firstname -%]
|
|
[%- SET data.cardnumber = patron.cardnumber -%]
|
|
[%- SET data.borrowernumber = patron.borrowernumber -%]
|
|
[%- SET data.title = patron.title -%]
|
|
[%- ELSIF ( borrower.borrowernumber ) -%]
|
|
[%- SET data.category_type = borrower.category_type -%]
|
|
[%- SET data.surname = borrower.surname -%]
|
|
[%- SET data.othernames = borrower.othernames -%]
|
|
[%- SET data.firstname = borrower.firstname -%]
|
|
[%- SET data.cardnumber = borrower.cardnumber -%]
|
|
[%- SET data.borrowernumber = borrower.borrowernumber -%]
|
|
[%- SET data.title = borrower.title -%]
|
|
[%- ELSIF ( borrowernumber ) -%]
|
|
[%- SET data.category_type = category_type -%]
|
|
[%- SET data.surname = surname -%]
|
|
[%- SET data.othernames = othernames -%]
|
|
[%- SET data.firstname = firstname -%]
|
|
[%- SET data.cardnumber = cardnumber -%]
|
|
[%- SET data.borrowernumber = borrowernumber -%]
|
|
[%- SET data.title = title -%]
|
|
[%- END -%]
|
|
[%# Parameter no_html - if 1, the html tags are NOT generated %]
|
|
[%- IF data.title %]
|
|
[%- IF no_html %]
|
|
[%- span_start = '' | html %]
|
|
[%- span_end = '' | html %]
|
|
[%- ELSE %]
|
|
[%- span_start = '<span class="patron-title">' %]
|
|
[%- span_end = '</span>' | html %]
|
|
[%- END %]
|
|
[%- SET data.title = span_start _ data.title _ span_end _ ' ' -%]
|
|
[%- END -%]
|
|
[%- SET display_patron_name = 1 -%]
|
|
[%- SET display_cardnumber = 1 -%]
|
|
[%- IF hide_patron_infos_if_needed %] [%# Should only be set if patron is set -%]
|
|
[%- SET can_see_patron_infos = logged_in_user.can_see_patron_infos( patron ) -%]
|
|
[%- UNLESS can_see_patron_infos -%]
|
|
[%- SET display_patron_name = 0 -%]
|
|
[%- SET display_cardnumber = 0 -%]
|
|
[%- ELSIF Koha.Preference('HidePatronName') -%]
|
|
[%- SET display_patron_name = 0 -%]
|
|
[%- END -%]
|
|
[%- END -%]
|
|
[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%]
|
|
[%- IF link_to == 'circulation_reserves' %]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% data.borrowernumber | html %]#reserves">
|
|
[%- ELSE %]<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% data.borrowernumber | html %]">
|
|
[%- END -%]
|
|
[%- END -%]
|
|
[%- IF display_patron_name -%]
|
|
[%- IF data.category_type == 'I' -%]
|
|
[%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%]
|
|
[%- ELSIF invert_name -%]
|
|
[% data.title | html %][%- data.surname | html %], [% data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END -%]
|
|
[%- ELSE -%]
|
|
[% data.title | html %][%- data.firstname | html %] [% IF data.othernames %] ([% data.othernames | html %]) [% END %] [% data.surname | html -%]
|
|
[%- END -%]
|
|
[%- IF display_cardnumber AND data.cardnumber %] ([% data.cardnumber | html %])[% END -%]
|
|
[%- ELSIF display_cardnumber -%]
|
|
[%- IF data.cardnumber -%][%# FIXME Cardnumber should always be defined, right? -%]
|
|
[%- data.cardnumber | html -%]
|
|
[%- END -%]
|
|
[%- ELSE -%]
|
|
A patron from library [% Branches.GetName( patron.branchcode ) | html -%]
|
|
[%- END -%]
|
|
|
|
[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%]
|
|
</a>
|
|
[%- END -%]
|