dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
73 lines
3.1 KiB
Text
73 lines
3.1 KiB
Text
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Acquisitions › Basket [% basketno | html %] › Duplicate warning</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
<body id="acq_neworderempty_duplicate" class="acq">
|
|
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'acquisitions-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> › <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | html %]">Basket [% basketno | html %]</a> › Duplicate warning</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<div class="dialog alert">
|
|
<h4>Duplicate warning</h4>
|
|
<p>You selected a record from an external source that matches an existing record in your catalog: [% IF ( BiblioDefaultViewmarc ) %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% biblionumber |url %]">
|
|
[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=[% biblionumber |url %]">
|
|
[% ELSIF ( BiblioDefaultViewisbd ) %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=[% biblionumber |url %]">
|
|
[% ELSE %]<a class="popup" target="_blank" title="Open in new window" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblionumber |url %]">[% END %][% duplicatetitle | html %]</a></p>
|
|
</div>
|
|
|
|
<div class="yui-gb">
|
|
<div class="yui-u first">
|
|
<div style="border: 1px solid #DDD; padding:1em;">
|
|
<form action="/cgi-bin/koha/acqui/neworderempty.pl">
|
|
<h4>Use existing record</h4>
|
|
<p>Do not create a duplicate record. Add an order from the existing record in your catalog.</p>
|
|
<input type="hidden" name="booksellerid" value="[% booksellerid | html %]" />
|
|
<input type="hidden" name="basketno" value="[% basketno | html %]" />
|
|
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
|
|
<input type="submit" value="Use Existing" />
|
|
</form>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="yui-u">
|
|
<div style="border: 1px solid #DDD; padding:1em;">
|
|
<form action="/cgi-bin/koha/acqui/basket.pl">
|
|
<h4>Cancel and return to order</h4>
|
|
<p>Return to the basket without making a new order.</p>
|
|
<input type="hidden" name="basketno" value="[% basketno | html %]" />
|
|
<input type="submit" value="Cancel" />
|
|
</form>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="yui-u">
|
|
<div style="border: 1px solid #DDD; padding:1em;">
|
|
<form action="/cgi-bin/koha/acqui/neworderempty.pl">
|
|
<h4>Create new record</h4>
|
|
<p>Create a new record by importing the external (duplicate) record.</p>
|
|
<input type="hidden" name="booksellerid" value="[% booksellerid | html %]" />
|
|
<input type="hidden" name="basketno" value="[% basketno | html %]" />
|
|
<input type="hidden" name="breedingid" value="[% breedingid | html %]" />
|
|
<input type="hidden" name="use_external_source" value="1" />
|
|
<input type="submit" value="Create New" />
|
|
</form>
|
|
</div>
|
|
</div>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'acquisitions-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|