dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
145 lines
8.2 KiB
Text
145 lines
8.2 KiB
Text
[% USE raw %]
|
|
[% USE Asset %]
|
|
[% USE Koha %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Audio alerts</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="admin_audio_alerts" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › Audio alerts</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<div id="toolbar" class="btn-toolbar">
|
|
<a class="btn btn-default btn-sm" id="newalert" href="/cgi-bin/koha/admin/audio_alerts.pl"><i class="fa fa-plus"></i> New alert</a>
|
|
</div>
|
|
|
|
<form id="new-alert-form" action="audio_alerts.pl" method="post" class="validated">
|
|
<fieldset class="rows">
|
|
<legend><span class="create-alert">Add new alert</span><span class="edit-alert">Edit alert</span></legend>
|
|
|
|
<input id="id" name="id" type="hidden" value="" />
|
|
<ol>
|
|
<li>
|
|
<label for="selector" class="required">Selector: </label>
|
|
<input id="selector" name="selector" type="text" class="required input-large" placeholder="selector" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="sound" class="required">Sound: </label>
|
|
<input id="sound" name="sound" type="text" class="required input-large" placeholder="sound" />
|
|
<button id="play-sound" class="btn btn-default btn-xs disabled"><i class="fa fa-play"></i> Play sound</button>
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="koha-sounds">Select a built-in sound: </label>
|
|
<select id="koha-sounds">
|
|
<option value=""> -- Choose one -- </option>
|
|
<option value="beep.ogg">beep.ogg</option>
|
|
<option value="call.ogg">call.ogg</option>
|
|
<option value="critical.ogg">critical.ogg</option>
|
|
<option value="device_connect.ogg">device_connect.ogg</option>
|
|
<option value="device_disconnect.ogg">device_disconnect.ogg</option>
|
|
<option value="ending.ogg">ending.ogg</option>
|
|
<option value="fail.ogg">fail.ogg</option>
|
|
<option value="IM_notification.ogg">IM_notification.ogg</option>
|
|
<option value="incoming_call.ogg">incoming_call.ogg</option>
|
|
<option value="loading.ogg">loading.ogg</option>
|
|
<option value="loading_2.ogg">loading_2.ogg</option>
|
|
<option value="maximize.ogg">maximize.ogg</option>
|
|
<option value="minimize.ogg">minimize.ogg</option>
|
|
<option value="new_mail_notification.ogg">new_mail_notification.ogg</option>
|
|
<option value="opening.ogg">opening.ogg</option>
|
|
<option value="panic.ogg">panic.ogg</option>
|
|
<option value="popup.ogg">popup.ogg</option>
|
|
<option value="warning.ogg">warning.ogg</option>
|
|
</select>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
<fieldset class="action">
|
|
<input id="save-alert" type="submit" value="Submit" />
|
|
<a href="#" id="cancel-edit" class="cancel cancel-edit">Cancel</a>
|
|
</fieldset>
|
|
</form>
|
|
|
|
<form id="delete-alert-form" action="audio_alerts.pl" method="post">
|
|
<h3>Audio alerts</h3>
|
|
[%IF !( Koha.Preference('AudioAlerts') ) %]
|
|
<div class="dialog alert">
|
|
<p><strong>Note: </strong></p>
|
|
<p>Please enable system preference 'AudioAlerts' to activate sounds.</p>
|
|
</div>
|
|
[% END %]
|
|
<table id="audio-alerts-table">
|
|
<thead id="audio-alerts-table-head">
|
|
<tr>
|
|
<th> </th>
|
|
<th>Precedence</th>
|
|
<th>Change order</th>
|
|
<th>Selector</th>
|
|
<th>Sound</th>
|
|
<th> </th>
|
|
</tr>
|
|
</thead>
|
|
|
|
<tbody id="audio-alerts-table-body">
|
|
[% FOREACH a IN audio_alerts %]
|
|
<tr>
|
|
<td><input type="checkbox" name="delete" value="[% a.id | html %]" /></td>
|
|
<td>[% a.precedence | html %]</td>
|
|
<td style="white-space:nowrap;">
|
|
<a title="Move alert up" href="audio_alerts.pl?action=move&where=up&id=[% a.id | html %]">
|
|
<i class="fa fa-arrow-up fa-lg order-control"></i>
|
|
</a>
|
|
|
|
<a title="Move alert to top" href="audio_alerts.pl?action=move&where=top&id=[% a.id | html %]">
|
|
<i class="fa fa-arrow-up fa-lg overline order-control"></i>
|
|
</a>
|
|
|
|
<a title="Move alert to bottom" href="audio_alerts.pl?action=move&where=bottom&id=[% a.id | html %]">
|
|
<i class="fa fa-arrow-down fa-lg underline order-control"></i>
|
|
</a>
|
|
|
|
<a title="Move alert down" href="audio_alerts.pl?action=move&where=down&id=[% a.id | html %]">
|
|
<i class="fa fa-arrow-down fa-lg order-control"></i>
|
|
</a>
|
|
</td>
|
|
<td>[% a.selector | html %]</td>
|
|
<td>[% a.sound | html %]</td>
|
|
<td>
|
|
<a class="btn btn-default btn-xs edit" data-soundid="[% a.id | html %]" data-precedence="[% a.precedence | html %]" data-selector="[% a.selector | html %]" data-sound="[% a.sound | html %]"><i class="fa fa-pencil"></i> Edit</a></td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
|
|
<p>
|
|
<button id="delete-alerts" type="submit" class="btn btn-default btn-sm disabled"><i class="fa fa-trash"></i> Delete selected alerts</button>
|
|
</p>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") | $raw %]
|
|
<script type="text/javascript">
|
|
var MSG_AUDIO_EMPTY_SOUND = _("Please select or enter a sound.");
|
|
var MSG_AUDIO_CONFIRM_DELETE = _("Are you sure you want to delete the selected audio alerts?");
|
|
var MSG_AUDIO_CHECK_CHECKBOXES = _("Check the box next to the alert you want to delete.")
|
|
</script>
|
|
[% Asset.js("js/audio_alerts.js") | $raw %]
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|