dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
110 lines
5 KiB
Text
110 lines
5 KiB
Text
[% USE raw %]
|
|
[% USE Asset %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › SMS cellular providers</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="admin_sms_providers" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › SMS cellular providers</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
<div id="toolbar" class="btn-toolbar">
|
|
<a class="btn btn-default btn-sm" id="new_provider" href="#"><i class="fa fa-plus"></i> New SMS provider</a>
|
|
</div>
|
|
|
|
<h2>SMS cellular providers</h2>
|
|
|
|
[% IF providers.size %]
|
|
|
|
<table id="providerst">
|
|
<thead>
|
|
<tr>
|
|
<th>Name</th>
|
|
<th>Domain</th>
|
|
<th title="Patrons using this provider">Patrons</th>
|
|
<th> </th>
|
|
</tr>
|
|
</thead>
|
|
|
|
<tbody>
|
|
[% FOREACH p IN providers %]
|
|
<tr>
|
|
<td id="name_[% p.id | html %]">[% p.name | html %]</td>
|
|
<td id="domain_[% p.id | html %]">[% p.domain | html %]</td>
|
|
<td id="patrons_using_[% p.id | html %]">[% p.patrons_using | html %]</td>
|
|
<td class="actions">
|
|
<a class="btn btn-default btn-xs edit" href="#" id="edit_[% p.id | html %]" data-providerid="[% p.id | html %]">
|
|
<i class="fa fa-pencil"></i> Edit
|
|
</a>
|
|
<a class="btn btn-default btn-xs delete" href="#" data-providerid="[% p.id | html %]" data-patrons_using="[% p.patrons_using | html %]" id="delete_[% p.id | html %]">
|
|
<i class="fa fa-trash"></i> Delete
|
|
</a>
|
|
</td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
|
|
[% ELSE %]
|
|
|
|
<div class="dialog message">
|
|
There are no SMS cellular providers defined.
|
|
</div>
|
|
|
|
[% END %]
|
|
|
|
<div id="sms_add_form">
|
|
<form id="sms_form" action="sms_providers.pl" method="post" class="validated">
|
|
<fieldset class="rows">
|
|
<legend>Add an SMS cellular provider</legend>
|
|
<input type="hidden" id="id" name="id" value="" />
|
|
<input type="hidden" id="op" name="op" value="add_update" />
|
|
<ol>
|
|
<li>
|
|
<label for="name" class="required">Name: </label>
|
|
<input type="text" id="name" name="name" required="required" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li>
|
|
<label for="domain" class="required">Domain: </label>
|
|
<input type="text" id="domain" name="domain" required="required" size="40"/>
|
|
<span class="required">Required</span>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
<fieldset class="action">
|
|
<input type="submit" id="submit_save" value="Submit" />
|
|
<input type="submit" value="Submit" id="submit_update" />
|
|
<a class="cancel cancel_edit" id="cancel" href="sms_providers.pl">Cancel</a>
|
|
</fieldset>
|
|
</form>
|
|
</div>
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") | $raw %]
|
|
<script type="text/javascript">
|
|
var MSG_SMS_PATRONS_USING = _("Are you sure you want to delete %s? %s patron(s) are using it!");
|
|
var MSG_SMS_DELETE_CONFIRM = _("Are you sure you want to delete %s?");
|
|
var LABEL_SMS_ADD_PROVIDER = _("Add an SMS cellular provider");
|
|
var LABEL_SMS_EDIT_PROVIDER = _("Edit provider %s");
|
|
</script>
|
|
[% Asset.js("js/sms_providers.js") | $raw %]
|
|
[% END %]
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|