Main Koha release repository https://koha-community.org
Find a file
Tomas Cohen Arazi dd512db60b
Bug 33708: Make staff interface login not require public API (OAuth/OIDC)
This patch makes the URL for staff login not point to the `/public`
namespace. The behavior is not changed for the protocol, but as
`/public` requires several settings to be available, it effectively
requires to enable the OPAC, the public API, etc. This patch
diferentiates both to solve the problem.

I've tested following the Wiki instructions to set keycloak [1] using
the *--sso* switch for `ktd` as well [2].

It is important to set the following URLs as allowed redirect in order
to replicate the issue and verify the fix:

http://localhost:8080/api/v1/public/oauth/login/test/opac
http://localhost:8081/api/v1/oauth/login/test/staff

To test:
1. Login into the staff interface using the SSO link:
=> FAIL: Results in a 'Bad redirect URL' error
2. Apply this patch and repeat 1
=> SUCCESS: You get a permission denied error or you just login,
depending on your setup.

[1] https://wiki.koha-community.org/wiki/Testing_SSO
[2] ktd --sso up -d

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-05-18 11:35:15 -03:00
acqui Bug 8179: Add vendor id on breadcrumb link 2023-05-17 14:44:42 -03:00
admin Bug 33594: Only sort on title main heading 2023-05-18 11:03:28 -03:00
api Bug 8179: Remove leftover/not used embed definitions 2023-05-15 08:53:49 -03:00
authorities Bug 32484: (QA follow-up) Few typos 2023-04-21 10:36:30 -03:00
basket Bug 33223: Replace 'first_valid' with 'notice' for email addresses 2023-05-16 15:17:35 -03:00
bin
C4 Bug 33761: Alter query to remove items with active transfers from available list 2023-05-18 10:54:28 -03:00
catalogue Bug 33167: Cleanup staff detail page 2023-05-12 11:22:45 -03:00
cataloguing Bug 32959: Don't store results of autobarcode in item editor templates 2023-05-18 11:35:13 -03:00
circ Bug 31212: (follow-up) Fix datelastseen when returning item 2023-05-12 17:49:57 -03:00
clubs
course_reserves
debian Bug 33580: Bring back ability to mark item as seen via SIP2 item information request 2023-05-12 11:22:47 -03:00
docs
erm
errors
etc Bug 33580: Bring back ability to mark item as seen via SIP2 item information request 2023-05-12 11:22:47 -03:00
ill
installer Bug 33138: Don't copy tag 147 to authority MARC frameworks 2023-05-18 11:35:14 -03:00
Koha Bug 33708: Make staff interface login not require public API (OAuth/OIDC) 2023-05-18 11:35:15 -03:00
koha-tmpl Bug 29993: Show Syndetics covers when using shelfbrowser controls 2023-05-18 11:35:13 -03:00
labels
lib/CGI/Session/Serialize
members Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl 2023-05-18 11:35:11 -03:00
misc Bug 23773: Send membership expiry notices by sms too 2023-05-18 11:35:14 -03:00
offline_circ
opac Bug 33223: Fix sendshelf 2023-05-16 15:17:36 -03:00
patron_lists
patroncards
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-05 10:18:57 -03:00
pos
recalls Bug 33220: Fix recalls to pull to not show in transit or allocated items 2023-05-16 15:17:29 -03:00
reports Bug 23824: Add a "Save and run" button to reports 2023-04-17 09:39:45 -03:00
reserve Bug 30687: Allow pickup location to be forced when override is allowed 2023-05-12 11:22:49 -03:00
reviews
rotating_collections
serials Bug 11844: Use additional fields for order lines 2023-05-16 12:58:38 +02:00
services
skel
suggestion Bug 33421: Fix filtering suggestions by status 2023-05-18 11:03:27 -03:00
svc Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines 2023-05-12 12:40:21 -03:00
t Bug 33761: Unit test 2023-05-18 10:54:24 -03:00
tags
tools Bug 33595: (bug 26628 follow-up) Fix authorization for tools-home.pl 2023-05-16 11:47:15 +02:00
virtualshelves Bug 33223: Fix sendshelf 2023-05-16 15:17:36 -03:00
xt Bug 33625: Adjust test to deal with cypress tests 2023-05-17 10:24:59 -03:00
.editorconfig
.eslintrc.json
.gitignore Bug 33710: Ignore how-to related files 2023-05-12 17:50:01 -03:00
.htaccess
.mailmap
.perlcriticrc
.proverc.dist
.stylelintrc.json
about.pl Bug 28267: Simplify things 2023-05-05 10:18:36 -03:00
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-07 11:03:32 -03:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-04-13 11:48:00 -03:00
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 32450: DBRev 22.12.00.047 2023-05-17 10:25:10 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 33133: Add fast cataloging to 'Cataloging' page 2023-03-27 12:50:07 +02:00
Makefile.PL
MANIFEST.SKIP
package.json Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo