dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
83 lines
5 KiB
HTML
83 lines
5 KiB
HTML
[% USE Koha %]
|
|
<div id="checkouts">
|
|
[% IF ( issuecount ) %]
|
|
<div id="issues-table-loading-message">
|
|
<p>
|
|
<a id="issues-table-load-now-button" href="#" class="btn btn-default"><i class="fa fa-book"></i> Show checkouts</a>
|
|
</p>
|
|
</div>
|
|
<form name="issues" action="/cgi-bin/koha/tools/export.pl" method="post" class="checkboxed">
|
|
<table id="issues-table" style="width: 100% !Important;">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col"> </th>
|
|
<th scope="col"> </th>
|
|
<th scope="col">Due date</th>
|
|
<th scope="col">Due date</th>
|
|
<th scope="col">Title</th>
|
|
<th scope="col">Item type</th>
|
|
<th scope="col">Location</th>
|
|
<th scope="col">Home library</th>
|
|
<th scope="col">Checked out on</th>
|
|
<th scope="col">Checked out from</th>
|
|
<th scope="col">Call no</th>
|
|
<th scope="col">Charge</th>
|
|
<th scope="col">Fine</th>
|
|
<th scope="col">Price</th>
|
|
<th scope="col">Renew <p class="column-tool"><a href="#" id="CheckAllRenewals">select all</a> | <a href="#" id="UncheckAllRenewals">none</a></p></th>
|
|
<th scope="col">Check in <p class="column-tool"><a href="#" id="CheckAllCheckins">select all</a> | <a href="#" id="UncheckAllCheckins">none</a></p></th>
|
|
<th scope="col">Export <p class="column-tool"><a href="#" id="CheckAllExports">select all</a> | <a href="#" id="UncheckAllExports">none</a></p></th>
|
|
</tr>
|
|
</thead>
|
|
[% INCLUDE 'checkouts-table-footer.inc' %]
|
|
</table>
|
|
|
|
<label for="issues-table-load-immediately">Always show checkouts immediately</label>
|
|
<input id="issues-table-load-immediately" type="checkbox" />
|
|
|
|
<div id="issues-table-actions">
|
|
<fieldset class="action">
|
|
[% IF ( CAN_user_circulate_override_renewals ) %]
|
|
[% IF CAN_user_circulate_override_renewals && Koha.Preference( 'AllowRenewalLimitOverride' ) %]
|
|
<label for="override_limit">Override renewal limit:</label>
|
|
<input type="checkbox" name="override_limit" id="override_limit" value="1" />
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
|
|
<button class="btn btn-default" id="RenewCheckinChecked"><i class="fa fa-check"></i> Renew or check in selected items</button>
|
|
<button class="btn btn-default" id="RenewAll"><i class="fa fa-book"></i> Renew all</button>
|
|
[% END %]
|
|
</fieldset>
|
|
|
|
[% IF Koha.Preference('ExportCircHistory') %]
|
|
<fieldset>
|
|
<label for="issues-table-output-format"><b>Export checkouts using format:</b></label>
|
|
<select name="issues-table-output-format" id="issues-table-output-format">
|
|
<option value="iso2709_995">ISO2709 with items</option>
|
|
<option value="iso2709">ISO2709 without items</option>
|
|
[% IF csv_profiles.size %]
|
|
<option value="csv">CSV</option>
|
|
[% END %]
|
|
</select>
|
|
|
|
[% IF csv_profiles.size %]
|
|
<select name="csv_profile_id">
|
|
[% FOREACH csv_profile IN csv_profiles %]
|
|
<option value="[% csv_profile.export_format_id | html %]">[% csv_profile.profile | html %]</option>
|
|
[% END %]
|
|
</select>
|
|
[% END %]
|
|
<label for="export_remove_fields">Don't export fields:</label> <input type="text" id="export_remove_fields" name="export_remove_fields" value="[% Koha.Preference('ExportRemoveFields') | html %]" title="Use for iso2709 exports" />
|
|
<input type="hidden" name="op" value="export" />
|
|
<input type="hidden" id="output_format" name="output_format" value="iso2709" />
|
|
<input type="hidden" id="dont_export_item" name="dont_export_item" value="0" />
|
|
<input type="hidden" id="record_type" name="record_type" value="bibs" />
|
|
<button class="btn btn-default btn-sm" id="export_submit"><i class="fa fa-download"></i> Export</button>
|
|
</fieldset>
|
|
[% END %]
|
|
</div>
|
|
</form>
|
|
[% ELSE %]
|
|
<p>Patron has nothing checked out.</p>
|
|
[% END %]
|
|
</div>
|