dcd1f5d48c
Here we go, next step then. As we did not fix the performance issue when autofiltering the variables (see bug 20975), the only solution we have is to add the filters explicitely. This patch has been autogenerated (using add_html_filters.pl, see next pathces) and add the html filter to all the variables displayed in the template. Exceptions are made (using the new 'raw' TT filter) to the variable we already listed in the previous versions of this patch. To test: - Use t/db_dependent/Koha/Patrons.t to populate your DB with autogenerated data which contain <script> tags - Remove them from borrower_debarments.comments (there are allowed here) update borrower_debarments set comment="html tags possible here"; - From the interface hit page and try to catch alert box. If you find one it means you find a possible XSS. To know where it comes from: * note the exact URL where you found it * note the alert box content * Dump your DB and search for the string in the dump to identify its location (for instance table.field) Next: * Ideally we would like to use the raw filter when it is not necessary to HTML escape the variables (in big loop for instance) * Provide a QA script to catch missing filters (we want html, uri, url or raw, certainly others that I am forgetting now) * Replace the html filters with uri when needed (!) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
112 lines
5.4 KiB
HTML
112 lines
5.4 KiB
HTML
<fieldset class="rows" id="memberentry_altaddress">
|
|
<legend id="alt_contact_lgd">Alternate contact</legend><ol>
|
|
[% UNLESS noaltcontactsurname %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactsurname ) %]
|
|
<label for="altcontactsurname" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactsurname">
|
|
[% END %]
|
|
Surname:</label>
|
|
<input type="text" name="altcontactsurname" id="altcontactsurname" value="[% patron.altcontactsurname | html %]" />
|
|
[% IF ( mandatoryaltcontactsurname ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactfirstname %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactfirstname ) %]
|
|
<label for="altcontactfirstname" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactfirstname">
|
|
[% END %]
|
|
First name:</label>
|
|
<input type="text" name="altcontactfirstname" id="altcontactfirstname" value="[% patron.altcontactfirstname | html %]" />
|
|
[% IF ( mandatoryaltcontactfirstname ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactaddress1 %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactaddress1 ) %]
|
|
<label for="altcontactaddress1" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactaddress1">
|
|
[% END %]
|
|
Address:</label>
|
|
<input type="text" name="altcontactaddress1" id="altcontactaddress1" value="[% patron.altcontactaddress1 | html %]" size="40" />
|
|
[% IF ( mandatoryaltcontactaddress1 ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactaddress2 %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactaddress2 ) %]
|
|
<label for="altcontactaddress2" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactaddress2">
|
|
[% END %]
|
|
Address 2:</label>
|
|
<input type="text" name="altcontactaddress2" id="altcontactaddress2" value="[% patron.altcontactaddress2 | html %]" size="40" />
|
|
[% IF ( mandatoryaltcontactaddress2 ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactaddress3 %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactaddress3 ) %]
|
|
<label for="altcontactaddress3" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactaddress3">
|
|
[% END %]
|
|
City:</label>
|
|
<input type="text" name="altcontactaddress3" id="altcontactaddress3" value="[% patron.altcontactaddress3 | html %]" size="20" />
|
|
[% IF ( mandatoryaltcontactaddress3 ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactstate %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactstate ) %]
|
|
<label for="altcontactstate" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactstate">
|
|
[% END %]
|
|
State:</label>
|
|
<input type="text" name="altcontactstate" id="altcontactstate" value="[% patron.altcontactstate | html %]" size="20" />
|
|
[% IF ( mandatoryaltcontactstate ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactzipcode %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactzipcode ) %]
|
|
<label for="altcontactzipcode" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactzipcode">
|
|
[% END %]
|
|
ZIP/Postal code:</label>
|
|
<input type="text" name="altcontactzipcode" id="altcontactzipcode" value="[% patron.altcontactzipcode | html %]" size="5" />
|
|
[% IF ( mandatoryaltcontactzipcode ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactcountry %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactcountry ) %]
|
|
<label for="altcontactcountry" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactcountry">
|
|
[% END %]
|
|
Country:</label>
|
|
<input type="text" name="altcontactcountry" id="altcontactcountry" value="[% patron.altcontactcountry | html %]" size="20" />
|
|
[% IF ( mandatoryaltcontactcountry ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
[% UNLESS noaltcontactphone %]
|
|
<li>
|
|
[% IF ( mandatoryaltcontactphone ) %]
|
|
<label for="altcontactphone" class="required">
|
|
[% ELSE %]
|
|
<label for="altcontactphone">
|
|
[% END %]
|
|
Phone:</label>
|
|
<input type="text" name="altcontactphone" id="altcontactphone" value="[% patron.altcontactphone | html %]" />
|
|
[% IF ( mandatoryaltcontactphone ) %]<span class="required">Required</span>[% END %]
|
|
</li>
|
|
[% END %]
|
|
</ol>
|
|
</fieldset>
|