Koha/members/files.pl
Jonathan Druart 9af6c4e34b Bug 19080: Handle non-existing patrons gratefully
This is a recurrent bug we have over the last years. When a script is
called with non-existent borrowernumber it will crashes.
We need to handle this gracefully instead of letting the script crashes.

On bug 18403 a new subroutine is added to the codebase
(output_and_exit_if_error) to handle this kind of errors correctly.
Since it is not pushed yet, I propose to just redirect to a script that
handle it correctly (circulation.pl) instead of adding this message to
all these scripts.

Test plan:
Hit different scripts from the members module and pass a non-existent
borrowernumber.
You must be redirected to circulation.pl with a friendly message.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-08-25 11:03:37 -03:00

141 lines
3.9 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2012 ByWater Solutions
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use strict;
use warnings;
use CGI qw ( -utf8 );
use C4::Auth;
use C4::Output;
use C4::Members;
use C4::Members::Attributes qw(GetBorrowerAttributes);
use C4::Debug;
use Koha::DateUtils;
use Koha::Patrons;
use Koha::Patron::Files;
my $cgi = CGI->new;
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
{
template_name => "members/files.tt",
query => $cgi,
type => "intranet",
authnotrequired => 0,
flagsrequired => { borrowers => 1 },
debug => 1,
}
);
$template->param( 'borrower_files' => 1 );
my $borrowernumber = $cgi->param('borrowernumber');
my $bf = Koha::Patron::Files->new( borrowernumber => $borrowernumber );
my $op = $cgi->param('op') || '';
if ( $op eq 'download' ) {
my $file_id = $cgi->param('file_id');
my $file = $bf->GetFile( id => $file_id );
print $cgi->header(
-type => $file->{'file_type'},
-charset => 'utf-8',
-attachment => $file->{'file_name'}
);
print $file->{'file_content'};
}
else {
my $patron = Koha::Patrons->find( $borrowernumber );
unless ( $patron ) {
print $cgi->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrowernumber");
exit;
}
my $patron_category = $patron->category;
$template->param(%{ $patron->unblessed});
my %errors;
if ( $op eq 'upload' ) {
my $uploaded_file = $cgi->upload('uploadfile');
if ($uploaded_file) {
my $filename = $cgi->param('uploadfile');
my $mimetype = $cgi->uploadInfo($filename)->{'Content-Type'};
$errors{'empty_upload'} = 1 if ( -z $uploaded_file );
if (%errors) {
$template->param( errors => %errors );
}
else {
my $file_content;
while (<$uploaded_file>) {
$file_content .= $_;
}
$bf->AddFile(
name => $filename,
type => $mimetype,
content => $file_content,
description => scalar $cgi->param('description'),
);
}
}
else {
$errors{'no_file'} = 1;
}
} elsif ( $op eq 'delete' ) {
$bf->DelFile( id => scalar $cgi->param('file_id') );
}
$template->param(
categoryname => $patron_category->description,
RoutingSerials => C4::Context->preference('RoutingSerials'),
);
if (C4::Context->preference('ExtendedPatronAttributes')) {
my $attributes = GetBorrowerAttributes($borrowernumber);
$template->param(
ExtendedPatronAttributes => 1,
extendedattributes => $attributes
);
}
$template->param( picture => 1 ) if $patron->image;
$template->param( adultborrower => 1 )
if ( $patron_category->category_type eq 'A' || $patron_category->category_type eq 'I' );
$template->param(
files => Koha::Patron::Files->new( borrowernumber => $borrowernumber )
->GetFilesInfo(),
errors => \%errors,
);
output_html_with_http_headers $cgi, $cookie, $template->output;
}
=head1 AUTHOR
Kyle M Hall <kyle@bywatersolutions.com>
=cut