ddc2906b77
To test: 1) Run the following test and make sure all pass: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t t/db_dependent/Holds.t t/db_dependent/Holds/LocalHoldsPriority.t t/db_dependent/Holds/HoldFulfillmentPolicy.t t/db_dependent/Holds/HoldItemtypeLimit.t t/db_dependent/Circulation/transferbook.t 2) Performe one or more checkouts for a patron, making sure that the circulation rules allows for renewals (for example by setting an earlier due-date). 3) Log in as this patron in OPAC and make sure the list of checkouts is displayed correctly, and that renewing an issue still works. Sponsored-by: Gothenburg University Library Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
72 lines
2.1 KiB
Perl
72 lines
2.1 KiB
Perl
#
|
|
# Status of a Renew Transaction
|
|
#
|
|
|
|
package C4::SIP::ILS::Transaction::Renew;
|
|
|
|
use warnings;
|
|
use strict;
|
|
|
|
use C4::Circulation qw( CanBookBeRenewed GetIssuingCharges AddIssue );
|
|
use Koha::Patrons;
|
|
use Koha::DateUtils;
|
|
|
|
use parent qw(C4::SIP::ILS::Transaction);
|
|
|
|
my %fields = (
|
|
renewal_ok => 0,
|
|
);
|
|
|
|
sub new {
|
|
my $class = shift;
|
|
my $self = $class->SUPER::new();
|
|
|
|
foreach my $element (keys %fields) {
|
|
$self->{_permitted}->{$element} = $fields{$element};
|
|
}
|
|
|
|
@{$self}{keys %fields} = values %fields; # overkill?
|
|
return bless $self, $class;
|
|
}
|
|
|
|
sub do_renew_for {
|
|
my $self = shift;
|
|
my $patron = shift;
|
|
my $checkout = Koha::Checkouts->find({ itemnumber => $self->{item}->{itemnumber} });
|
|
my ($renewokay,$renewerror) = CanBookBeRenewed($patron, $checkout);
|
|
if ($renewokay) { # ok so far check charges
|
|
my ($fee, undef) = GetIssuingCharges($self->{item}->{itemnumber}, $self->{patron}->{borrowernumber});
|
|
if ($fee > 0) {
|
|
$self->{sip_fee_type} = '06';
|
|
$self->{fee_amount} = sprintf '%.2f',$fee;
|
|
if ($self->{fee_ack} eq 'N') {
|
|
$renewokay = 0;
|
|
}
|
|
}
|
|
|
|
}
|
|
if ($renewokay){
|
|
my $issue = AddIssue( $patron, $self->{item}->id, undef, 0 );
|
|
$self->{due} = $self->duedatefromissue($issue, $self->{item}->{itemnumber});
|
|
$self->renewal_ok(1);
|
|
} else {
|
|
$renewerror=~s/on_reserve/Item unavailable due to outstanding holds/;
|
|
$renewerror=~s/too_many/Item has reached maximum renewals/;
|
|
$renewerror=~s/too_unseen/Item has reached maximum consecutive renewals without being seen/;
|
|
$renewerror=~s/item_denied_renewal/Item renewal is not allowed/;
|
|
$renewerror=~s/item_issued_to_other_patron/Item already issued to other borrower/;
|
|
$self->screen_msg($renewerror);
|
|
$self->renewal_ok(0);
|
|
}
|
|
$self->ok(1);
|
|
return;
|
|
}
|
|
|
|
sub do_renew {
|
|
my $self = shift;
|
|
my $patron = Koha::Patrons->find( $self->{patron}->borrowernumber );
|
|
$patron or return; # FIXME we should log that
|
|
return $self->do_renew_for($patron);
|
|
}
|
|
|
|
1;
|