Main Koha release repository https://koha-community.org
Find a file
Jonathan Druart de6a373126 Bug 28349: (bug 26234 follow-up) Correct wrong array merge
Bug 26234 allowed to remove the different classes we use in aoColumnDefs
for sorting columns of table using DT.

However there is a terrible mistake, the merge of existing aoColumnDefs
array with the default one is totally wrong:
  $.extend(true, new_parameters, default_column_defs);
When we actually wanted to do:
  $.extend(true, new_parameters["aoColumnDefs"], default_column_defs);

But it's still wrong, extend is doing a deep copy and the array will be
replaced by the other one, whereas we want to append.

We want to merge default_column_defs with the existing aocolumnDefs,
this patch is doing it explicitely.

This bug only exists when there is an existing aocolumnDefs.

See commit d3f3a55e0b
It happens on:
 * cataloguing/z3950_search.tt
 * reports/guided_reports_start.tt
 * serials/subscription-detail.tt
 * opac-course-reserves.tt
 * opac-detail.tt

However this bug has been hidden as we have in master related bug from
bug 27945, which removes title-string.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-10-28 12:16:37 +02:00
acqui Bug 27287: Make note fields from orders history searchable 2021-10-21 12:24:04 +02:00
admin Bug 14957: Fix perlcritic error on admin/marc-overlay-rules.pl 2021-10-27 09:16:42 +02:00
api Bug 27947: (QA follow-up) Clarify permissions 2021-10-06 10:09:25 +02:00
authorities Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
basket
bin
C4 Bug 29158: (bug 22435 follow-up) Remove ref to account_offset_types.sql in intaller 2021-10-26 16:46:03 +02:00
catalogue Bug 11175: (QA follow-up) Test message contents for analytics error 2021-10-26 16:46:02 +02:00
cataloguing Bug 27526: Fix for prefill preventing duplication 2 2021-10-28 10:54:42 +02:00
circ Bug 28211: Replace use of call_recursive() with call() 2021-10-18 11:28:41 +02:00
clubs
course_reserves
debian Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
docs
errors
etc Bug 20463: (follow-up) Configure short name mrl for Multipart-resource-level index 2021-10-25 14:08:06 +02:00
ill Bug 22614: Migrate original request 2021-09-21 20:22:57 +02:00
installer Bug 26374: update from bug 19974 is not idempotent 2021-10-28 12:16:37 +02:00
Koha Bug 29272: (QA follow-up) Category setup overrides syspref 2021-10-28 12:16:37 +02:00
koha-tmpl Bug 28349: (bug 26234 follow-up) Correct wrong array merge 2021-10-28 12:16:37 +02:00
labels
lib/CGI/Session/Serialize
members Bug 28211: Replace use of call_recursive() with call() 2021-10-18 11:28:41 +02:00
misc Bug 14957: (QA follow-up) Clarify 'context' param 2021-10-26 16:46:02 +02:00
offline_circ Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
opac Bug 29318: Tidy the code 2021-10-26 16:46:03 +02:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards
plugins Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
pos
reports Bug 29271: (QA follow-up) Fetch and send descriptions to template 2021-10-21 10:09:51 +02:00
reserve Bug 29116: Use a pre-existing accessor instead of reimplementing it 2021-10-12 11:15:32 +02:00
reviews
rotating_collections
serials Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
services
skel
suggestion Bug 28946: (bug 23271 follow-up) Missing occurrence in add_user_search.pl 2021-09-14 18:23:28 +02:00
svc Bug 14957: Fix record preview 2021-10-26 16:46:03 +02:00
t Bug 29272: (QA follow-up) Category setup overrides syspref 2021-10-28 12:16:37 +02:00
tags Bug 28785: Adjust check_cookie_auth calls 2021-10-18 11:28:41 +02:00
tmp/modified_authorities
tools Bug 14957: (QA follow-up) Clarify 'context' param 2021-10-26 16:46:02 +02:00
virtualshelves
xt Bug 27622: Fix sample_notices.t 2021-10-07 15:49:01 +02:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml
about.pl Bug 28870: Move email address validation to a specific class method 2021-09-28 10:22:36 +02:00
app.psgi
changelanguage.pl
cpanfile Bug 28870: Remove traces of Email::Valid 2021-09-28 10:22:35 +02:00
fix-perl-path.PL
gulpfile.js Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
help.pl
INSTALL
Koha.pm Bug 14957: DBRev 21.06.00.038 2021-10-26 16:46:03 +02:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
Makefile.PL Bug 18984: Remove NORMARC support 2021-10-07 15:36:40 +02:00
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo