Jonathan Druart
9fb827d59d
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
96 lines
4.3 KiB
Perl
96 lines
4.3 KiB
Perl
#!/usr/bin/env perl
|
|
|
|
use Modern::Perl;
|
|
use Module::Load::Conditional qw/check_install/;
|
|
use Test::More;
|
|
use Test::MockModule;
|
|
|
|
use t::lib::Mocks;
|
|
|
|
use_ok('C4::Members');
|
|
|
|
BEGIN {
|
|
if ( check_install( module => 'Test::DBIx::Class' ) ) {
|
|
plan tests => 25;
|
|
} else {
|
|
plan skip_all => "Need Test::DBIx::Class"
|
|
}
|
|
}
|
|
|
|
use Test::DBIx::Class;
|
|
|
|
my $db = Test::MockModule->new('Koha::Database');
|
|
$db->mock( _new_schema => sub { return Schema(); } );
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $rs = [];
|
|
|
|
my $borrower = Koha::Schema->resultset('Borrower');
|
|
my $cardnumber_size = $borrower->result_source->column_info('cardnumber')->{size};
|
|
|
|
t::lib::Mocks::mock_preference('BorrowerMandatoryField', '');
|
|
my $pref = "10";
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 10, 10 ], '10 => min=10 and max=10');
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{123456789} ), 2, "123456789 is shorter than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890123456} ), 2, "1234567890123456 is longer than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890} ), 0, "1234567890 is equal to $pref");
|
|
|
|
$pref = q|10,10|; # Same as before !
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 10, 10 ], '10,10 => min=10 and max=10');
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{123456789} ), 2, "123456789 is shorter than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890123456} ), 2, "1234567890123456 is longer than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890} ), 0, "1234567890 is equal to $pref");
|
|
|
|
$pref = q|8,10|; # between 8 and 10 chars
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 8, 10 ], '8,10 => min=8 and max=10');
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{12345678} ), 0, "12345678 matches $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890123456} ), 2, "1234567890123456 is longer than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567} ), 2, "1234567 is shorter than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890} ), 0, "1234567890 matches $pref");
|
|
|
|
$pref = q|8,|; # At least 8 chars
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 8, $cardnumber_size ], "8, => min=8 and max=$cardnumber_size");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567} ), 2, "1234567 is shorter than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890123456} ), 0, "1234567890123456 matches $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890} ), 0, "1234567890 matches $pref");
|
|
|
|
$pref = q|,8|; # max 8 chars
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 0, 8 ], ',8 => min=0 and max=8');
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567} ), 0, "1234567 matches $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890123456} ), 2, "1234567890123456 is longer than $pref");
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
is( C4::Members::checkcardnumber( q{1234567890} ), 2, "1234567890 is longer than $pref");
|
|
|
|
$pref = sprintf(',%d', $cardnumber_size+1);
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 0, $cardnumber_size ],
|
|
sprintf(",%d => min=0 and max=%d",$cardnumber_size+1,$cardnumber_size) );
|
|
$dbh->{mock_add_resultset} = $rs;
|
|
|
|
my $generated_cardnumber = sprintf("%s1234567890",q|9|x$cardnumber_size);
|
|
is( C4::Members::checkcardnumber( $generated_cardnumber ), 2, "$generated_cardnumber is longer than $pref => $cardnumber_size is max!");
|
|
|
|
$pref = q|,8|; # max 8 chars
|
|
t::lib::Mocks::mock_preference('CardnumberLength', $pref);
|
|
t::lib::Mocks::mock_preference('BorrowerMandatoryField', 'cardnumber');
|
|
is_deeply( [ C4::Members::get_cardnumber_length() ], [ 1, 8 ], ',8 => min=1 and max=8 if cardnumber is mandatory');
|