Main Koha release repository https://koha-community.org
Find a file
Martin Renvoize e0fdb2db51
Bug 34269: Convert to using codes in select compares
This patch updates the logic in smart rules to compare option values to
codes as apposed to option texts to value descriptions.

0. Apply patch
1. Install another language in the staff interface
   1. ./translate install xx-XX
   2. Check the box of the language in the 'language' system preference
   3. Refresh
2. Create an item type with a parent
   1. Go to Administration > Item types
   2. Create a new item type or modify an existing one, assigning a parent type
      Example: Create a 'Children's books' itemtypetype
      and assig 'Books' as its parent
   3. Create a third item type with the same description but something added in ():
      Example: 'Children's books (3-5)'
3. Create a circulation rule for the parent type
   Example: All/Books, with 2 checkouts allowed
4. Create a circulation rule for:
   All/All with 3 checkouts allowed
5. In English, click on "Edit" next to the parent type rule (All/Books)
   --> Note that the item type in the bottom row (the modifiable row) is changed to 'Books (All)'
6. Modify the number of checkouts allowed (e.g. 99)
   --> The All/Books rule is modified
7. Switch the interface to the other language
8. Click on "Edit" next to the parent type rule (All/Books)
   --> The All/Books rule is modified
9. Add rules for Children's books and Children's books (3-5)
10. Click on "Edit" next to each rule and change a value
   --> Verify that the changed values are always saved for the correct rule

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-08-15 11:25:43 +03:00
acqui Bug 33105: Tidy files 2023-07-20 10:59:31 -03:00
admin Bug 32271: (QA follow-up) Convert all positive numbers to monetary float and convert all 0 equivilents to blank value 2023-07-19 13:00:37 -03:00
api Bug 34387: (QA follow-up) Fix display of 'Import batches' 2023-08-15 11:25:38 +03:00
authorities
basket
bin
C4 Bug 33881: Clear self-check JWT during auth kick out 2023-08-07 21:00:08 -03:00
catalogue
cataloguing Bug 34288: Allow access to the cataloguing module with tools permission 2023-07-18 12:46:53 -03:00
circ Bug 28966: Prefetch patron data for holds queue viewer 2023-07-25 16:25:38 -03:00
clubs
course_reserves
debian Bug 28493: Make koha-passwd display the username 2023-07-19 13:00:41 -03:00
docs
erm
errors
etc
ill
installer Bug 30451: DBRev 23.06.00.014 2023-08-15 11:25:41 +03:00
Koha Bug 30524: (QA follow-up) Only generate CSRF token if it will be used 2023-08-07 21:00:06 -03:00
koha-tmpl Bug 34269: Convert to using codes in select compares 2023-08-15 11:25:43 +03:00
labels
lib/CGI/Session/Serialize
members Bug 22990: Add CSRF protection to boraccount, pay and suggestion 2023-08-07 21:00:01 -03:00
misc Bug 34059: Add only issues from the branch that is creating the notice 2023-08-15 11:25:39 +03:00
offline_circ Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
opac Bug 34023: Prevent HTML injection in "back to results" link from search page 2023-08-07 21:00:04 -03:00
patron_lists
patroncards
plugins
pos Bug 30619: Add email receipt to POS 2022-09-07 15:59:34 -07:00
recalls
reports
reserve Bug 34178: Cache ItemsAnyAvailableAndNotRestricted in memory and don't precalculate 2023-07-19 13:00:42 -03:00
reviews Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
rotating_collections Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
serials
services
skel
suggestion Bug 22990: (follow-up) Fix suggestion.pl 2023-08-07 21:00:04 -03:00
svc Bug 33444: Update AddRenewal to take a hashref of params 2023-07-19 12:06:52 -03:00
t Bug 30524: (QA follow-up) Fix tests 2023-08-07 21:00:07 -03:00
tags
tools Bug 34368: Add CSRF token to Content Management pages 2023-08-07 21:00:00 -03:00
virtualshelves Bug 22990: Fix for shelves table 2023-08-07 21:00:02 -03:00
xt Bug 30002: Remove unused xt/perltidyrc 2023-06-08 08:32:40 -03:00
.editorconfig
.eslintrc.json
.gitignore
.htaccess
.mailmap
.perlcriticrc
.perltidyrc
.proverc.dist
.stylelintrc.json
about.pl
app.psgi
build-resources.PL
changelanguage.pl
cpanfile Bug 33964: (QA follow-up) Remove library from cpanfile 2023-07-25 08:25:41 -03:00
cypress.json
fix-perl-path.PL
gulpfile.js
help.pl
INSTALL
Koha.pm Bug 30451: DBRev 23.06.00.014 2023-08-15 11:25:41 +03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl
Makefile.PL
MANIFEST.SKIP
package.json
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js
yarn.lock

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo