ed7543287b
Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious This patch: - adds a Template::Toolkit plugin that generates <script> and <link> tags for JS and CSS files, and inserts automatically the Koha version in the filename - use the new plugin to remove all occurences of [% KOHA_VERSION %] - remove the code that was adding KOHA_VERSION as a template variable Test plan: 1. Apply patch 2. Go to several different pages in Koha (opac and intranet) while checking your browser's dev tools (there should be no 404 for JS and CSS files, and the Koha version should appear in filenames) and the server logs (there should be no "File not found") 3. `git grep KOHA_VERSION` should return nothing 4. prove t/db_dependent/Koha/Template/Plugin/Asset.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
74 lines
2.8 KiB
Text
74 lines
2.8 KiB
Text
[% USE Asset %]
|
|
[% USE Branches %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Circulation and fine rules › Clone circulation and fine rules</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
<body id="admin_clone-rules" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › <a href="/cgi-bin/koha/admin/smart-rules.pl">Circulation and fine rules</a> › Clone circulation and fine rules</div>
|
|
|
|
<div id="doc3" class="yui-t1">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
<h2>Cloning circulation and fine rules
|
|
[% IF frombranch %] from "[% Branches.GetName( frombranch ) %]"[% END %]
|
|
[% IF tobranch %] to "[% Branches.GetName( tobranch ) %]"[% END %]
|
|
</h2>
|
|
|
|
[% IF ( result ) %]
|
|
[% IF ( error ) %]
|
|
<div class="dialog alert">Cloning of circulation and fine rules failed!</div>
|
|
[% ELSE %]
|
|
<div class="dialog message"><p>The rules have been cloned.</p></div>
|
|
[% END %]
|
|
<a href="/cgi-bin/koha/admin/smart-rules.pl">Return to circulation and fine rules</a>
|
|
[% ELSE %]
|
|
|
|
<p class="help">Use carefully! If the destination library already has circulation and fine rules, they will be deleted without warning!</p>
|
|
<form action="/cgi-bin/koha/admin/clone-rules.pl" method="post">
|
|
[% UNLESS ( frombranch ) %]
|
|
<fieldset>
|
|
<legend>Please choose a library to clone rules from:</legend>
|
|
<label for="frombranch">Source library:</label>
|
|
<select name="frombranch" id="frombranch">
|
|
<option value="">Default</option>
|
|
[% PROCESS options_for_libraries libraries => Branches.all() %]
|
|
</select>
|
|
[% IF ( tobranch ) %]<input type="hidden" name="tobranch" value="[% tobranch %]" />[% END %]
|
|
</fieldset>
|
|
[% END %]
|
|
|
|
[% UNLESS ( tobranch ) %]
|
|
<fieldset>
|
|
<legend>Please choose the library to clone the rules to:</legend>
|
|
<label for="tobranch">Destination library:</label>
|
|
<select name="tobranch" id="tobranch">
|
|
<option value="">Default</option>
|
|
[% PROCESS options_for_libraries libraries => Branches.all() %]
|
|
</select>
|
|
[% IF ( frombranch ) %]<input type="hidden" name="frombranch" value="[% frombranch %]" />[% END %]
|
|
</fieldset>
|
|
[% END %]
|
|
<input type="submit" value="Submit" />
|
|
</form>
|
|
|
|
[% END %]
|
|
</div>
|
|
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
[% Asset.js("js/admin-menu.js") %]
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|