Kyle M Hall
858083c8e9
Steps to reproduce: 1) Log into staff intranet 2) Set logged in branch 3) Browse to tools/overdue notice triggers 4) Select a branch from the pulldown that is not your logged in branch 5) use the "Check out" bar at the top of the page to search for a patron to check out to 6) Once you have landed here, click the "check out" tab link again, or the Edit button ( any action really ) 7) Note your logged in branch has now changed to the once selected when editing the notice/status triggers This is due to the way the patron search passes the branchcode to be used via the form. This form assumes the branchcode variable is always the currently logged in branch, which may not and is not always the case. Test Plan: 1) Apply this patch 2) Repeat the steps to reproduce above 3) Note your logged in branch does not change Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Funny bug :) This patch fixes the described issue and should not introduce regression. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
50 lines
2.2 KiB
HTML
50 lines
2.2 KiB
HTML
[% USE Branches %]
|
|
[% IF ( CAN_user_circulate ) %][% IF ( CircAutocompl ) %]<script type="text/javascript">
|
|
//<![CDATA[
|
|
$(document).ready(function(){
|
|
$( "#findborrower" ).autocomplete({
|
|
source: "/cgi-bin/koha/circ/ysearch.pl",
|
|
minLength: 3,
|
|
select: function( event, ui ) {
|
|
$( "#findborrower" ).val( ui.item.cardnumber );
|
|
$("#patronsearch").submit();
|
|
return false;
|
|
}
|
|
})
|
|
.data( "autocomplete" )._renderItem = function( ul, item ) {
|
|
return $( "<li></li>" )
|
|
.data( "item.autocomplete", item )
|
|
.append( "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>" + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>" )
|
|
.appendTo( ul );
|
|
};
|
|
|
|
});
|
|
//]]>
|
|
</script>[% END %]
|
|
<div id="circ_search" class="residentsearch">
|
|
<p class="tip">Enter patron card number or partial name:</p>
|
|
<form action="/cgi-bin/koha/circ/circulation.pl" id="patronsearch" method="post">
|
|
[% IF ( CircAutocompl ) %]
|
|
<div class="autocomplete">
|
|
<input autocomplete="off" id="findborrower" name="findborrower" size="40" class="focus" type="text" />
|
|
<input id="autocsubmit" type="submit" class="submit" value="Submit" />
|
|
<input name="branch" value="[% Branches.GetLoggedInBranchcode() %]" type="hidden" />
|
|
<input name="printer" value="" type="hidden" />
|
|
[% IF ( stickyduedate ) %]
|
|
<input type="hidden" name="duedatespec" value="[% duedatespec %]" />
|
|
<input type="hidden" name="stickyduedate" value="[% stickyduedate %]" />
|
|
[% END %]
|
|
</div>
|
|
[% ELSE %]
|
|
<input id="findborrower" name="findborrower" size="40" class="focus" type="text" />
|
|
<input name="branch" value="[% branch %]" type="hidden" />
|
|
<input name="printer" value="" type="hidden" />
|
|
[% IF ( stickyduedate ) %]
|
|
<input type="hidden" name="duedatespec" value="[% duedatespec %]" />
|
|
<input type="hidden" name="stickyduedate" value="[% stickyduedate %]" />
|
|
[% END %]
|
|
<input value="Submit" class="submit" type="submit" />
|
|
[% END %]
|
|
</form>
|
|
</div>
|
|
[% END %]
|