Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/admin
History
Jonathan Druart 6b7e17f9fd Bug 28567: Fix 0 vs "" vs undef on the admin library form 
There are two things here:
* Branches.pickup_location has a default = 1 in DB, we should not set to undef if 0
or it will be set to 1 when stored.
* The other fields are all text (varchar, mediumtext or longtext) and
can be NULL. They are correct set to NULL when a new library is created
but set to an empty string when the library is modified. That's not
consistent

Test plan:
0. Don't apply the patch
1. Create a new library, set pickup location to "No"
2. Save
=> Pickup location is set to YES
=> In DB notice that the different values you didn't fill in are set to
NULL
3. Edit the library
4. Save
=> In DB notice that the different values you didn't fill in are now set
to an empty string
5. Apply the patch, restart_all
6. Run the updatedatabase script
=> In DB all the empty string values are set to NULL
7. Repeat 1 to 4 and confirm that everything is now working as expected

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-30 15:54:12 +02:00
..
searchengine/elasticsearch Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
add_user_search.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
additional-fields.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
admin-home.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
adveditorshortcuts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
aqbudgetperiods.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
aqbudgets.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
aqcontract.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
aqplan.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
audio_alerts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
auth_subfields_structure.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
auth_tag_structure.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
authorised_values.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
authtypes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
background_jobs.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
biblio_framework.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
branch_transfer_limits.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
branches.pl Bug 28567: Fix 0 vs "" vs undef on the admin library form 2021-07-30 15:54:12 +02:00
cash_registers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
categories.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_budget_parent.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_parent_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
checkmarc.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
cities.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
classsources.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
clone-rules.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
columns_settings.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
columns_settings.yml Bug 28408: Add new column to the table settings config 2021-07-26 11:02:20 +02:00
credit_types.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
currency.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debit_types.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
desks.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
didyoumean.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edi_accounts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edi_ean_accounts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
import_export_framework.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
item_circulation_alerts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
items_search_field.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
items_search_fields.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
itemtypes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
koha2marclinks.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
library_groups.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
localization.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc_subfields_structure.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marctagstructure.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
matching-rules.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
oai_set_mappings.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
oai_sets.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
overdrive.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
patron-attr-types.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
preferences.pl Bug 28624: Remove Smart::Comments 2021-07-26 12:46:32 +02:00
share_content.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
smart-rules.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
sms_providers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
smtp_servers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
sru_modmapping.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
systempreferences.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transfer_limits.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transport-cost-matrix.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
usage_statistics.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
z3950servers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00