d0cc5fa97a
When borrowerRelationship is empty in system preferences, Relationship
dropdown is not required and we accept empty value.
Also fixes bug that didn't let you to pick empty value even when you
specified that it should be possible in system preferences but in the
end of the string (i.e. "|father|mother" worked,
but "father|mother|" don't).
To reproduce (borrowerRelationship can be empty):
1) Go to system preferences and make borrowerRelationship empty.
2) Create a new patron who is assumed to have a guarantor or modify
the existing one.
3) Under "Guarantor Information" click on "Search to add" button.
After performing the search, select a user to act as guarantor. Try to save your changes.
4) Observe that relationship field is required in order to save but
you can't actually choose anything as it doesn't contain anything.
5) Apply the patch.
6) Repeat steps above.
7) Observe that it allows you to save the form now.
To reproduce (can't choose empty value bug):
1) Go to system preferences and set borrowerRelationship exactly
to "father|mother|".
2) Create a new patron who is assumed to have a guarantor or modify
the existing one.
3) Under "Guarantor Information" click on "Search to add" button.
After performing the search, select a user to act as guarantor.
4) Observe that there's no option to leave relationship field empty.
5) Apply the patch.
6) Repeat steps above.
7) Observe that it has empty option that you can choose and save
the form.
Mentored-by: Andrew Nugged <nugged@gmail.com>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
|
||
|---|---|---|
| .. | ||
| accountline-details.pl | ||
| apikeys.pl | ||
| boraccount.pl | ||
| cancel-charge.pl | ||
| default_messageprefs.pl | ||
| deletemem.pl | ||
| discharge.pl | ||
| discharges.pl | ||
| files.pl | ||
| guarantor_search.pl | ||
| holdshistory.pl | ||
| housebound.pl | ||
| ill-requests.pl | ||
| mancredit.pl | ||
| maninvoice.pl | ||
| member-flags.pl | ||
| member-password.pl | ||
| member.pl | ||
| memberentry.pl | ||
| members-home.pl | ||
| members-update-do.pl | ||
| members-update.pl | ||
| merge-patrons.pl | ||
| mod_debarment.pl | ||
| moremember.pl | ||
| notices.pl | ||
| patronimage.pl | ||
| pay.pl | ||
| paycollect.pl | ||
| print_overdues.pl | ||
| printfeercpt.pl | ||
| printinvoice.pl | ||
| printslip.pl | ||
| purchase-suggestions.pl | ||
| readingrec.pl | ||
| routing-lists.pl | ||
| setstatus.pl | ||
| statistics.pl | ||
| summary-print.pl | ||
| update-child.pl | ||