Koha-community/Koha
13
7
Fork 0
Code Issues Releases Wiki Activity
Koha/t/db_dependent
History
Nick Clemens e46ab82e28 Bug 18990: Overdue Notices are not sending through SMS correctly 
Bug 18478 fixed sms via email problems under the assumption that
to_address was either smsalertnumber or blank.

It seems overdues set the to_address to email. This patch changes the
code to enforce that an sms sent with emial driver will use the
smsalertnumebr and provider defined for the borrower, regardless of what
is set in the queue

To test:
 1 - Define a messaging prefs for a patron to recieve hold notices via
  SMS
 2 - Ensure you have defined an SMS message for an overdue letter
 3 - Set an SMS alert number for patron
 4 - Set the SMS::Send driver to 'Email'
 5 - Checkout an item as overdue to trigger notice above
 6 - Run overdue_notices.pl
 6 - Check the db and note the address is email
 7 - run process_message_queue.pl
 8 - Check db - address is email followed by service provider
 9 - Apply patch
 10 - repeat
 11 - Message to_address should be populated with smsalertnumber

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-12-07 09:37:11 -03:00
..
Acquisition Bug 15685: (QA follow-up) Address QA issues 2017-10-11 13:08:47 -03:00
api/v1 Bug 7317: (QA followup) Rename 'branch' for 'library' 2017-11-09 11:42:16 -03:00
Auth
Authority Bug 17380: (QA followup) Fix parameter in tests 2017-09-12 12:07:47 -03:00
Biblio Bug 18951: Adjust Isbd.t 2017-07-24 13:37:18 -03:00
Circulation Bug 18357: Handle unlimited on-site checkouts 2017-11-26 13:00:17 -03:00
Creators
data
Exporter Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds Bug 18547: (QA follow-up) Add comments to make tests clearer 2017-11-26 11:30:22 -03:00
Illrequest Bug 7317: Remove traces of UnmediatedILL 2017-11-09 11:42:16 -03:00
Items Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
Koha Bug 14919: Add test for Koha::Patron->old_holds subroutine 2017-10-27 16:05:01 -03:00
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
LDAP
Letters Bug 19277: Make sure the tests will pass even if they are slow 2017-09-12 11:29:11 -03:00
Members Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
OAI Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Patron Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record
Reports Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml' 2017-10-25 12:14:32 -03:00
Reserves Bug 19437: (followup) Rearrange CancelExpiredReserves tests - fix typos 2017-10-09 13:47:02 -03:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-26 14:36:34 -03:00
selenium Bug 18298: Fix selenium tests 2017-10-17 12:40:45 -03:00
Serials Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
SIP Bug 19386: [QA Follow-up] Remove some default values 2017-10-06 12:00:19 -03:00
Template/Plugin Bug 19655: Add tests 2017-11-26 12:59:31 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
www Bug 19392: Clean-up behind auth_values_input_www.t 2017-09-29 17:12:19 -03:00
XSLT_Handler
00-strict.t Bug 19178: Remove outdated sms/* scripts and related files 2017-10-27 14:10:29 -03:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 12768: Replacement cost and processing fee management 2017-10-20 17:14:33 -03:00
Acquisition.t Bug 19256: (QA followup) Remove warn from unit test 2017-09-07 15:03:04 -03:00
AdditionalField.t
Amazon.t
ArticleRequests.t Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
AudioAlerts.t
Auth.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
Auth_with_cas.t Bug 19373: Update tests 2017-10-16 09:38:41 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Bookseller.t Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
Breeding.t
Budgets.t Bug 18999: (QA followup) ModReceiveOrder expects a hashref 2017-09-29 13:03:38 -03:00
Calendar.t Bug 9031: (QA follow-up) Final changes to Calendar::days_between 2017-10-27 14:09:04 -03:00
Charset.t
check_sysprefs.t
Circulation.t Bug 12768: Fix up unit tests a bit more 2017-10-20 17:14:35 -03:00
ClassSource.t
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
Context.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Contract.t
CourseReserves.t
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
DecreaseLoanHighHolds.t Bug 19423: Prevent DecreaseLoanHighHolds.t to fail randomly 2017-10-06 12:30:18 -03:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 16187: Do not use DateTime directly 2017-10-20 16:51:25 -03:00
Holds.t Bug 19766: (bug 19058 follow-up) Fix Preview routing slip 2017-12-07 09:37:01 -03:00
HoldsQueue.t Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Illrequestattributes.t Bug 7317: (followup) Make tests independent of data on the DB 2017-11-09 11:42:15 -03:00
Illrequests.t Bug 7317: (QA followup) Rename 'branch' for 'library' 2017-11-09 11:42:16 -03:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
Installer.t
Items.t Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Elasticsearch_Indexer.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 19559: Add tests 2017-11-26 12:59:31 -03:00
Languages.t
Letters.t Bug 18990: Overdue Notices are not sending through SMS correctly 2017-12-07 09:37:11 -03:00
Linker_FirstMatch.t
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t Bug 19069: Fix 'does not match' behaviour in MARC modification template 2017-10-27 14:09:01 -03:00
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-08-25 12:12:04 -03:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 19176: Compare the number of seconds when comparing dates in tests 2017-10-30 14:55:18 -03:00
Plugins.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
Reserves.t Bug 19437: Rearranging tests for CancelExpiredReserves 2017-10-09 13:47:02 -03:00
rollingloans.t Bug 17829: Execute rollingloans tests in a transaction 2017-07-26 16:39:17 -03:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search.t Bug 17664: Silence non-zebra warnings in t/db_dependent/Search.t 2017-10-06 12:09:57 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t
Service.t
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Stats.t Bug 18882: (QA follow-up) Ensure stats with no or undef location are set to NULL in db 2017-11-08 13:34:37 -03:00
SuggestionEngine_ExplodedTerms.t Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t 2017-11-01 13:10:18 -03:00
Suggestions.t
sysprefs.t
Tags.t
Templates.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
TestBuilder.t Bug 15339: Remove extra 'my' 2017-09-07 13:56:08 -03:00
Upload.t Bug 19420: (QA Follow-up) Fix test, correct POD 2017-11-08 13:31:37 -03:00
UsageStats.t Bug 10748: Add the ability to block return of lost items 2017-11-08 11:07:09 -03:00
Virtualshelves.t Bug 19176: Compare the number of seconds when comparing dates in tests 2017-10-30 14:55:18 -03:00
XISBN.t Bug 19440: Identify overlimit problems in XISBN tests 2017-10-09 16:15:52 -03:00
XSLT_Handler.t Bug 17807: Add format parameter to XSLT_Handler->transform 2017-08-30 15:06:40 -03:00
zebra_config.pl