Tomas Cohen Arazi
74ac5baba5
The plugins handling code expects plugins implementing an 'uninstall' method for cleanup purposes. It executes this method, and then moves on with removing the configuration entries in the storage, and the plugin itself. But the 'plugins-home.tt' template makes the tool display the 'Uninstall' link in the dropdown ONLY when the plugin has the 'uninstall' method. This patch fixes the issue. To reproduce: - Install the KitchenSink plugin [1] => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Edit the code for the plugin: $ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm - Remove the uninstall sub - Restart everything: $ restart_all - Reload the browser => FAIL: There's no 'Uninstall' option in the actions dropdown. - Apply this patch - Restart everything $ restart_all - Reload the browser => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Sign off :-D [1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
148 lines
8.9 KiB
Text
148 lines
8.9 KiB
Text
[% USE KohaDates %]
|
|
[% SET footerjs = 1 %]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Tools › Plugins </title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
</head>
|
|
|
|
<body id="plugins_plugins_home" class="plugins">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'prefs-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs">
|
|
<a href="/cgi-bin/koha/mainpage.pl">Home</a> ›
|
|
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> ›
|
|
Plugins
|
|
</div>
|
|
|
|
<div id="doc3" class="yui-t1">
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
<div class="details">
|
|
|
|
[% IF ( CAN_user_plugins_manage ) %]
|
|
<div class="btn-toolbar" id="toolbar">
|
|
<a href="/cgi-bin/koha/plugins/plugins-upload.pl" id="upload_plugin" class="btn btn-default btn-sm"><i class="fa fa-upload"></i> Upload plugin</a>
|
|
<div class="btn-group">
|
|
<button class="btn btn-default btn-sm dropdown-toggle" data-toggle="dropdown"><i class="fa fa-eye"></i> View plugins by class <span class="caret"></span></button>
|
|
<ul class="dropdown-menu">
|
|
<li><a href="/cgi-bin/koha/plugins/plugins-home.pl">View all plugins</a></li>
|
|
<li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=report">View report plugins</a></li>
|
|
<li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=tool">View tool plugins</a></li>
|
|
<li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=to_marc">View MARC conversion plugins</a></li>
|
|
<li><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=opac_online_payment">View online payment plugins</a></li>
|
|
</ul>
|
|
</div>
|
|
</div>
|
|
[% END %]
|
|
<h1>Plugins</h1>
|
|
|
|
[% UNLESS ( plugins ) %]
|
|
[% UNLESS ( method ) %]
|
|
<div class="dialog message">No plugins installed</div>
|
|
[% ELSE %]
|
|
[% IF method == 'tool' %]
|
|
<div class="dialog message">No plugins that can be used as a tool are installed</div>
|
|
[% ELSIF method == 'report' %]
|
|
<div class="dialog message">No plugins that can create a report are installed</div>
|
|
[% ELSIF method == 'to_marc' %]
|
|
<div class="dialog message">No plugins that can convert files to MARC records are installed</div>
|
|
[% ELSIF method == 'opac_online_payment' %]
|
|
<div class="dialog message">No plugins that can process online payments via the public catalog are installed</div>
|
|
[% ELSE %]
|
|
<div class="dialog message">Unknown plugin type <i>[% method %]</i></div>
|
|
[% END %]
|
|
[% END %]
|
|
[% ELSE %]
|
|
<table>
|
|
<tr>
|
|
<th>Name</th>
|
|
<th>Description</th>
|
|
<th>Author</th>
|
|
<th>Plugin version</th>
|
|
<th>Minimum Koha version</th>
|
|
<th>Maximum Koha version</th>
|
|
<th>Last updated</th>
|
|
[% IF ( CAN_user_plugins_configure || CAN_user_plugins_manage || CAN_user_plugins_report || CAN_user_plugins_tool ) %]
|
|
<th>Actions</th>
|
|
[% END %]
|
|
</tr>
|
|
|
|
[% FOREACH plugin IN plugins %]
|
|
<tr>
|
|
<td><strong>[% plugin.metadata.name %]</strong></td>
|
|
<td>
|
|
[% plugin.metadata.description %]
|
|
|
|
[% IF ( plugin.metadata.minimum_version && koha_version < plugin.metadata.minimum_version ) %]
|
|
<div class="error">Warning: This report was written for a newer version of Koha. Run at your own risk.</div>
|
|
[% END %]
|
|
|
|
[% IF ( plugin.metadata.maximum_version && koha_version > plugin.metadata.maximum_version ) %]
|
|
<div class="error">Warning: This report was written for an older version of Koha. Run at your own risk.</div>
|
|
[% END %]
|
|
</td>
|
|
<td>[% plugin.metadata.author %]</td>
|
|
<td>[% plugin.metadata.version %]</td>
|
|
<td>[% plugin.metadata.minimum_version %]</td>
|
|
<td>[% plugin.metadata.maximum_version %]</td>
|
|
<td>[% plugin.metadata.date_updated | $KohaDates %]</td>
|
|
[% IF ( CAN_user_plugins_configure || CAN_user_plugins_manage || CAN_user_plugins_report || CAN_user_plugins_tool ) %]
|
|
<td class="actions">
|
|
<div class="dropdown">
|
|
<a class="btn btn-default btn-xs dropdown-toggle" id="pluginactions[% plugin.class %]" role="button" data-toggle="dropdown" href="#">
|
|
Actions <b class="caret"></b>
|
|
</a>
|
|
<ul class="dropdown-menu pull-right" role="menu" aria-labelledby="pluginactions[% plugin.class %]">
|
|
[% IF ( CAN_user_plugins_report ) %]
|
|
[% IF plugin.can('report') %]
|
|
<li><a href="/cgi-bin/koha/plugins/run.pl?class=[% plugin.class %]&method=report"><i class="fa fa-table"></i> Run report</a></li>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% IF ( CAN_user_plugins_tool ) %]
|
|
[% IF plugin.can('tool') %]
|
|
<li><a href="/cgi-bin/koha/plugins/run.pl?class=[% plugin.class %]&method=tool"><i class="fa fa-wrench"></i> Run tool</a></li>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
[% IF ( CAN_user_plugins_configure ) %]
|
|
[% IF plugin.can('configure') %]
|
|
<li><a href="/cgi-bin/koha/plugins/run.pl?class=[% plugin.class %]&method=configure"><i class="fa fa-cog"></i> Configure</a></li>
|
|
[% END %]
|
|
[% END %]
|
|
[% IF ( CAN_user_plugins_manage ) %]
|
|
<li><a class="uninstall_plugin" data-plugin-name="[% plugin.metadata.name %]" href="/cgi-bin/koha/plugins/plugins-uninstall.pl?class=[% plugin.class %]"><i class="fa fa-trash"></i> Uninstall</a></li>
|
|
[% END %]
|
|
</ul>
|
|
</div>
|
|
</td>
|
|
[% END %]
|
|
[% END %]
|
|
</table>
|
|
[% END %]
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="yui-b noprint">
|
|
[% INCLUDE 'tools-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
|
|
[% MACRO jsinclude BLOCK %]
|
|
<script type="text/javascript" src="[% interface %]/[% theme %]/js/tools-menu_[% KOHA_VERSION %].js"></script>
|
|
[% INCLUDE 'calendar.inc' %]
|
|
<script type="text/javascript">
|
|
$(document).ready(function(){
|
|
$(".uninstall_plugin").on("click", function(){
|
|
$(".dropdown").removeClass("open");
|
|
var plugin_name = $(this).data("plugin-name");
|
|
return confirmDelete( _("Are you sure you want to uninstall the plugin %s?").format( plugin_name ) );
|
|
});
|
|
});
|
|
</script>
|
|
[% END %]
|
|
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|