Koha/Koha/SuggestionEngine.pm
Jonathan Druart 9d6d641d1f Bug 17600: Standardize our EXPORT_OK
On bug 17591 we discovered that there was something weird going on with
the way we export and use subroutines/modules.
This patch tries to standardize our EXPORT to use EXPORT_OK only.

That way we will need to explicitely define the subroutine we want to
use from a module.

This patch is a squashed version of:
Bug 17600: After export.pl
Bug 17600: After perlimport
Bug 17600: Manual changes
Bug 17600: Other manual changes after second perlimports run
Bug 17600: Fix tests

And a lot of other manual changes.

export.pl is a dirty script that can be found on bug 17600.

"perlimport" is:
git clone https://github.com/oalders/App-perlimports.git
cd App-perlimports/
cpanm --installdeps .
export PERL5LIB="$PERL5LIB:/kohadevbox/koha/App-perlimports/lib"
find . \( -name "*.pl" -o -name "*.pm" \) -exec perl App-perlimports/script/perlimports --inplace-edit --no-preserve-unused --filename {} \;

The ideas of this patch are to:
* use EXPORT_OK instead of EXPORT
* perltidy the EXPORT_OK list
* remove '&' before the subroutine names
* remove some uneeded use statements
* explicitely import the subroutines we need within the controllers or
modules

Note that the private subroutines (starting with _) should not be
exported (and not used from outside of the module except from tests).

EXPORT vs EXPORT_OK (from
https://www.thegeekstuff.com/2010/06/perl-exporter-examples/)
"""
Export allows to export the functions and variables of modules to user’s namespace using the standard import method. This way, we don’t need to create the objects for the modules to access it’s members.

@EXPORT and @EXPORT_OK are the two main variables used during export operation.

@EXPORT contains list of symbols (subroutines and variables) of the module to be exported into the caller namespace.

@EXPORT_OK does export of symbols on demand basis.
"""

If this patch caused a conflict with a patch you wrote prior to its
push:
* Make sure you are not reintroducing a "use" statement that has been
removed
* "$subroutine" is not exported by the C4::$MODULE module
means that you need to add the subroutine to the @EXPORT_OK list
* Bareword "$subroutine" not allowed while "strict subs"
means that you didn't imported the subroutine from the module:
  - use $MODULE qw( $subroutine list );
You can also use the fully qualified namespace: C4::$MODULE::$subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-07-16 08:58:47 +02:00

199 lines
4.7 KiB
Perl

package Koha::SuggestionEngine;
# Copyright 2012 C & P Bibliography Services
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
=head1 NAME
Koha::SuggestionEngine - Dispatcher class for suggestion engines
=head1 SYNOPSIS
use Koha::SuggestionEngine;
my $suggestor = Koha::SuggestionEngine->new(%params);
$suggestor->get_suggestions($search)
=head1 DESCRIPTION
Dispatcher class for retrieving suggestions. SuggestionEngines must
extend Koha::SuggestionEngine::Base, be in the Koha::SuggestionEngine::Plugin
namespace, and provide the following methods:
B<get_suggestions ($search)> - get suggestions from the plugin for the
specified search.
These methods may be overriden:
B<initialize (%params)> - initialize the plugin
B<destroy ()> - destroy the plugin
These methods should not be overridden unless you are very sure of what
you are doing:
B<new ()> - create a new plugin object
=head1 FUNCTIONS
=cut
use strict;
use warnings;
use Module::Load::Conditional qw( can_load );
use Module::Pluggable::Object;
use base qw(Class::Accessor);
__PACKAGE__->mk_accessors(qw( schema plugins options record ));
=head2 new
my $suggestor = Koha::SuggestionEngine->new(%params);
Create a new suggestor class. Available parameters are:
=over 8
=item B<plugins>
What plugin(s) to use. This must be an arrayref to a list of plugins. Plugins
can be specified either with a complete class path, or, if they are in the
Koha::SuggestionEngine::Plugin namespace, as only the plugin name, and
"Koha::SuggestionEngine::Plugin" will be prepended to it before the plugin
is loaded.
=back
=cut
sub new {
my $class = shift;
my $param = shift;
my $options = $param->{options} || '';
my @plugins = ();
foreach my $plugin ( @{$param->{plugins}} ) {
next unless $plugin;
my $plugin_module =
$plugin =~ m/:/
? $plugin
: "Koha::SuggestionEngine::Plugin::${plugin}";
if ( can_load( modules => { $plugin_module => undef } ) ) {
my $object = $plugin_module->new();
$plugin_module->initialize($param);
push @plugins, $object;
}
}
my $self = $class->SUPER::new(
{
plugins => \@plugins,
options => $options
}
);
bless $self, $class;
return $self;
}
=head2 get_suggestions
my $suggestions = $suggester->get_suggestions(\%params)
Get a list of suggestions based on the search passed in. Available parameters
are:
=over 8
=item B<search>
Required. The search for which suggestions are desired.
=item B<count>
Optional. The number of suggestions to retrieve. Defaults to 10.
=back
=cut
sub get_suggestions {
my $self = shift;
my $param = shift;
return unless $param->{'search'};
my $number = $param->{'count'} || 10;
my %suggestions;
my $index = scalar @{ $self->plugins };
foreach my $pluginobj ( @{ $self->plugins } ) {
next unless $pluginobj;
my $pluginres = $pluginobj->get_suggestions($param);
foreach my $suggestion (@$pluginres) {
$suggestions{ $suggestion->{'search'} }->{'relevance'} +=
$suggestion->{'relevance'} * $index;
$suggestions{ $suggestion->{'search'} }->{'label'} |=
$suggestion->{'label'};
}
$index--;
}
my @results = ();
for (
sort {
$suggestions{$b}->{'relevance'} <=> $suggestions{$a}->{'relevance'}
} keys %suggestions
)
{
last if ( $#results == $number - 1 );
push @results,
{
'search' => $_,
relevance => $suggestions{$_}->{'relevance'},
label => $suggestions{$_}->{'label'}
};
}
return \@results;
}
sub DESTROY {
my $self = shift;
foreach my $pluginobj ( @{ $self->plugins } ) {
$pluginobj->destroy();
}
}
=head2 AvailablePlugins
my @available_plugins = Koha::SuggestionEngine::AvailablePlugins();
Get a list of available plugins.
=cut
sub AvailablePlugins {
my $path = 'Koha::SuggestionEngine::Plugin';
my $finder = Module::Pluggable::Object->new( search_path => $path );
return $finder->plugins;
}
1;