Koha/t/db_dependent
Jonathan Druart e63eee05a0 Bug 17969: Refactor the way <<items.content>> is generated
<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-08-30 15:06:25 -03:00
..
Acquisition Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
api/v1 Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth
Authorities Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Biblio Bug 18951: Adjust Isbd.t 2017-07-24 13:37:18 -03:00
Circulation Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Creators
data
Exporter Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
Items Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t 2017-08-25 11:53:44 -03:00
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
LDAP
Letters
Members Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
OAI Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Patron Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record
Reports
Reserves Bug 19025: Move GetReserveInfo to Koha::Holds 2017-08-30 15:06:10 -03:00
Search Bug 18976: (follow-up) Fix t/db_dependent/Search/History.t cleanup 2017-07-26 14:36:34 -03:00
selenium Bug 18982: Remove data in the correct order 2017-07-26 13:50:44 -03:00
Serials Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
SIP Bug 18996: [QA Follow-up] Remove global variables from Message.t 2017-08-20 08:27:27 -03:00
Template/Plugin Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
www Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
XSLT_Handler
00-strict.t
01-test_dbic.t
Accounts.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Acquisition.t Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
AdditionalField.t
Amazon.t
ArticleRequests.t
AudioAlerts.t
Auth.t Bug 18976: Fix t/db_dependent/Auth.t cleanup 2017-07-26 14:36:34 -03:00
Auth_with_cas.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t
BackgroundJob.t
Barcodes.t
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Bookseller.t Bug 19130: Remove ->search() overloading and adjust tests 2017-08-25 11:53:43 -03:00
Breeding.t
Budgets.t Bug 18941 - Unit tests 2017-08-10 16:25:34 -03:00
Calendar.t
Charset.t
check_sysprefs.t
Circulation.t Bug 18292 - t/db_dependent/Circulation.t doesn't need to return 1; 2017-08-15 12:17:42 -03:00
ClassSource.t
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
Context.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Contract.t
CourseReserves.t
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
DecreaseLoanHighHolds.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
FrameworkPlugin.t
Heading_MARC21.t
Hold.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds.t Bug 19025: Move GetReserveInfo to Koha::Holds 2017-08-30 15:06:10 -03:00
HoldsQueue.t Bug 18605: Remove TRUNCATE from C4/HoldsQueue.pm 2017-07-24 14:12:27 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
Installer.t
Items.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t
Koha_Database.t
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Elasticsearch_Indexer.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Languages.t
Letters.t Bug 17969: Refactor the way <<items.content>> is generated 2017-08-30 15:06:25 -03:00
Linker_FirstMatch.t
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-08-25 12:12:04 -03:00
MungeMarcPrice.t
NewsChannels.t
Overdues.t
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Plugins.t
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t
RecordProcessor_EmbedSeeFromHeadings.t
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
Reserves.t Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
rollingloans.t Bug 17829: Execute rollingloans tests in a transaction 2017-07-26 16:39:17 -03:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t
Service.t
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t
Stats.t
SuggestionEngine_ExplodedTerms.t
Suggestions.t
sysprefs.t
Tags.t
Templates.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
TestBuilder.t
Upload.t
UsageStats.t
Virtualshelves.t Bug 18672: [QA Follow-up] Simplify without sleep 2017-07-17 13:19:43 -03:00
XISBN.t
XSLT_Handler.t
zebra_config.pl