Koha/C4
Tomas Cohen Arazi 14e2185f94 Bug 19841: Make AddMember raise an exception if categorycode is invalid
This patch makes C4::Members::AddMember raise a Koha::Exceptions::BadParameter
exception. The current behaviour is to just explode. Code calling
AddReturn should work as expected, unless they are looking for a
specific failure message.

It is just explodes in a way we know what happened, in the case the
categorycode is invalid.

To test:
- Apply the Unit tests patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> FAIL: Tests fail because AddReturn doesn't raise an exception
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Members.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Dominic Pichette <dominic.pichette@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-12-26 12:52:34 -03:00
..
AuthoritiesMarc
Barcodes
ClassSortRoutine
Creators
External
Form
Heading
ILSDI Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Installer Bug 19450: Fixed WebService::ILS bug upstream (0.17) 2017-12-21 13:09:17 -03:00
Labels Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Linker
Members
OAI
Output
Patroncards Bug 18550: [Follow-up] Add POD descriptions to subs 2017-10-06 12:09:55 -03:00
Reports Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml' 2017-10-25 12:14:32 -03:00
Search
Serials
SIP Bug 19651: SIP/ILS/Item misses title and author 2017-11-26 12:59:31 -03:00
Utils Bug 19418: (bug 12833 follow-up) Add missing use statement 2017-10-10 10:18:35 -03:00
Accounts.pm Bug 10021: Drop columns notify_id and notify_level from accountlines 2017-12-11 11:34:18 -03:00
Acquisition.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Auth.pm Bug 12227: Remove the demo functionality 2017-12-11 11:34:20 -03:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm Bug 19373: CAS logout - Redirect to the previous page (Intranet) 2017-10-16 09:38:41 -03:00
Auth_with_ldap.pm
Auth_with_shibboleth.pm
AuthoritiesMarc.pm Bug 18458: Fix subfields ordering when Merging authority records 2017-12-22 13:15:36 -03:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Bookseller.pm
Boolean.pm
Breeding.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Budgets.pm Bug 18999: Modified SQL query in GetBudgetSpent() in C4/Budgets.pm 2017-09-29 13:03:38 -03:00
Calendar.pm Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT 2017-07-06 14:29:04 -03:00
Charset.pm Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag" 2017-07-26 14:01:51 -03:00
Circulation.pm Bug 19444: Do not auto renew if patron is expired and BlockExpiredPatronOpacActions is set 2017-12-18 12:16:26 -03:00
ClassSortRoutine.pm
ClassSource.pm
Context.pm Bug 19788: Preserve case sensitivity when creating Local preferences 2017-12-22 13:15:37 -03:00
Contract.pm
CourseReserves.pm Bug 18276: Remove GetBiblioFromItemNumber - Course reserves 2017-07-10 12:09:24 -03:00
Creators.pm
Debug.pm
Heading.pm
HoldsQueue.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
HTML5Media.pm
Images.pm
ImportBatch.pm Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
ImportExportFramework.pm
InstallAuth.pm Bug 19514: Add client-side check 2017-12-14 16:58:13 -03:00
Installer.pm Bug 14826: account_offset_types.sql is not in the mandatory subdir 2017-10-20 18:14:06 -03:00
ItemCirculationAlertPreference.pm
Items.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Koha.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Labels.pm
Languages.pm
Letters.pm Bug 18990: Overdue Notices are not sending through SMS correctly 2017-12-07 09:37:11 -03:00
Linker.pm
Log.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
MarcModificationTemplates.pm Bug 19069: Fix 'does not match' behaviour in MARC modification template 2017-10-27 14:09:01 -03:00
Matcher.pm Bug 18131: Followup - Use data if biblionumber_tag < 10 2017-11-26 12:59:51 -03:00
Members.pm Bug 19841: Make AddMember raise an exception if categorycode is invalid 2017-12-26 12:52:34 -03:00
Message.pm
NewsChannels.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Output.pm
Overdues.pm Bug 10021: Drop columns notify_id and notify_level from accountlines 2017-12-11 11:34:18 -03:00
Patroncards.pm
Print.pm
Record.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Reports.pm
Reserves.pm Bug 19299: Replace C4::Reserves::GetReservesForBranch with Koha::Holds->waiting 2017-12-11 11:34:19 -03:00
Ris.pm Bug 10306: Core module changes for multiple mappings 2017-12-07 14:44:15 -03:00
RotatingCollections.pm
Scheduler.pm
Scrubber.pm
Search.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Serials.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Service.pm
ShelfBrowser.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
SMS.pm Bug 19134: C4::SMS falils on long driver name 2017-08-25 10:51:24 -03:00
SocialData.pm
Stats.pm Bug 18882: (QA follow-up) Ensure stats with no or undef location are set to NULL in db 2017-11-08 13:34:37 -03:00
Suggestions.pm
Tags.pm
Templates.pm Bug 17989: Resolve "verbatim paragraph in NAME section" warning in C4::Templates 2017-11-01 13:10:17 -03:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm
UsageStats.pm Bug 19713: Remove 2 occurences of OpacShowLibrariesPullDownMobile 2017-12-20 13:34:09 -03:00
XISBN.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
XSLT.pm Bug 18921: Resolve a few warnings in C4/XSLT.pm 2017-09-07 14:34:42 -03:00