Koha-community/Koha: Main Koha release repository - Koha - Koha: The world's first free and open source library system

Main Koha release repository https://koha-community.org

Tree: e7d4c773be

History

Jonathan Druart 6d5b056a14 Bug 17323: Column search_history.time cannot be null When doing a search, with SearchHistory pref switched on: DBD::mysql::st execute failed: Column 'time' cannot be null [for Statement " INSERT INTO search_history( userid, sessionid, query_desc, query_cgi, type, total, time ) VALUES( ?, ?, ?, ?, ?, ?, ? ) " with ParamValues: 0="7874", 1='12338a0bd8da63e32c79ee84f8493a07', 2="kw,wrdl: d", 3='q=d', 4='biblio', 5=6104, 6=undef] at C4/Search/History.pm line 34. Since MySLQ 5.7, undef does not mean "the default value". To let the DBMS set the default value (CURRENT_TIMESTAMP), the parameter should not be passed Test plan: OPAC+Intranet, swith the 2 SearchHistory syspref on Do a search => Without this patch, you will get an error in the log and the row will not be inserted in the table. => With this patch, everything must go fine Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Not verified with MySQL 5.7. But this looks good to me. Works under Jessie. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>	8 years ago
..
History.pm	Bug 17323: Column search_history.time cannot be null	8 years ago
PazPar2.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	9 years ago

Jonathan Druart 6d5b056a14 Bug 17323: Column search_history.time cannot be null

When doing a search, with SearchHistory pref switched on:

DBD::mysql::st execute failed: Column 'time' cannot be null [for Statement "
        INSERT INTO search_history(
            userid, sessionid, query_desc, query_cgi, type, total, time
        ) VALUES(
            ?, ?, ?, ?, ?, ?, ?
        )
    " with ParamValues: 0="7874", 1='12338a0bd8da63e32c79ee84f8493a07', 2="kw,wrdl: d", 3='q=d', 4='biblio', 5=6104, 6=undef] at C4/Search/History.pm line 34.

Since MySLQ 5.7, undef does not mean "the default value".
To let the DBMS set the default value (CURRENT_TIMESTAMP), the parameter should not be passed

Test plan:
OPAC+Intranet, swith the 2 SearchHistory syspref on
Do a search
=> Without this patch, you will get an error in the log and the row will not be inserted in the table.
=> With this patch, everything must go fine

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Not verified with MySQL 5.7. But this looks good to me.
Works under Jessie.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

8 years ago

History.pm

Bug 17323: Column search_history.time cannot be null

8 years ago

PazPar2.pm

Bug 9978: Replace license header with the correct license (GPLv3+)

9 years ago