Koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketheader.tt
Julian Maurice ed7543287b Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere
Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-04-13 11:49:44 -03:00

148 lines
6.8 KiB
Text

[% USE Asset %]
[% USE Branches %]
[% USE Koha %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Acquisitions &rsaquo;
[% IF ( add_form ) %]
[% IF ( basketno ) %]Edit basket '[% basketname %]'
[% ELSE %]Add a basket to [% booksellername %]
[% END %]
[% END %]
</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="acq_basketheader" class="acq">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'acquisitions-search.inc' %]
<div id="breadcrumbs">
<a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo;
<a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> &rsaquo;
<a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]">[% booksellername %]</a> &rsaquo;
[% IF ( add_form ) %]
[% IF ( basketno ) %]Edit basket '[% basketname |html %]'
[% ELSE %]Add a basket to [% booksellername %]
[% END %]
[% END %]
</div>
<div class="main container-fluid">
<div class="row">
<div class="col-md-10 col-md-offset-1 col-lg-8 col-lg-offset-2">
[% IF ( add_form ) %]
[% IF ( basketno ) %]
<h1>Edit basket [% basketname |html %]</h1>
[% ELSE %]<h1>Add a basket to [% booksellername %]</h1>
[% END %]
<form name="Aform" action="[% script_name %]" method="post" class="validated">
<input type="hidden" name="booksellerid" value="[% booksellerid %]" />
<fieldset class="rows">
<ol>
[% IF ( basketno ) %]
<li>
<input type="hidden" name="basketno" value="[% basketno %]" />
<input type="hidden" name="is_an_edit" value="1" />
</li>
[% END %]
<li>
<label for="basketname" class="required">Basket name: </label> &nbsp;
<input type="text" name="basketname" id="basketname" size="40" maxlength="80" value="[% basketname %]" required="required" class="required" />
<span class="required">Required</span>
</li>
<li>
<label for="billingplace">Billing place:</label>
<select name="billingplace" id="billingplace">
<option value="">--</option>
[% PROCESS options_for_libraries libraries => Branches.all( selected => billingplace ) %]
</select>
</li>
<li>
<label for="deliveryplace">Delivery place:</label>
<select name="deliveryplace" id="deliveryplace">
<option value="">--</option>
[% PROCESS options_for_libraries libraries => Branches.all( selected => deliveryplace ) %]
</select>
</li>
<li>
<label for="basketbooksellerid">Vendor: </label> &nbsp;
<select name="basketbooksellerid" id="basketbooksellerid">
[% FOREACH b IN booksellers %]
[% IF booksellerid == b.id %]
<option value="[% b.id %]" selected="selected">[% b.name %]</option>
[% ELSE %]
<option value="[% b.id %]">[% b.name %]</option>
[% END %]
[% END %]
</select>
</li>
<li>
<label for="basketnote">Internal note: </label> &nbsp;
<textarea name="basketnote" id="basketnote" rows="5" cols="40">[% basketnote |html %]</textarea>
</li>
<li>
<label for="basketbooksellernote">Vendor note: </label> &nbsp;
<textarea name="basketbooksellernote" id="basketbooksellernote" rows="5" cols="40">[% basketbooksellernote |html %]</textarea>
</li>
[% IF ( contractloop ) %]
<li><label for="basketcontractnumber">Contract: </label>
<select id="basketcontractnumber" name="basketcontractnumber">
<option value=""></option>
[% FOREACH contractloo IN contractloop %]
[% IF ( contractloo.selected ) %]
<option value="[% contractloo.contractnumber %]" selected="selected">[% contractloo.contractname %]</option>
[% ELSE %]
<option value="[% contractloo.contractnumber %]">[% contractloo.contractname %]</option>
[% END %]
[% END %]
</select>
</li>
[% END %]
<li>
<label for="is_standing">Orders are standing:</label>
[% IF is_standing %]
<input type="checkbox" id="is_standing" name="is_standing" checked="checked" />
[% ELSE %]
<input type="checkbox" id="is_standing" name="is_standing"/>
[% END %]
<div class="hint">Standing orders do not close when received.</div>
</li>
[% UNLESS basketno %]
<li>
<label for="create_items">Create items when:</label>
<select name="create_items" id="create_items">
[% SWITCH Koha.Preference('AcqCreateItem') %]
[% CASE 'receiving' %]<option value="">use default (receiving an order)</option>
[% CASE 'cataloguing' %]<option value="">use default (cataloging the record)</option>
[% CASE %]<option value="">use default (placing an order)</option>
[% END %]
<option value="ordering">placing an order</option>
<option value="receiving">receiving an order</option>
<option value="cataloguing">cataloging the record</option>
</select>
</li>
[% END %]
</ol>
</fieldset>
<fieldset class="action">
<input type="hidden" name="op" value="add_validate" />
<input type="submit" value="Save" />
[% IF ( basketno ) %]
<a class="cancel" href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno %]">Cancel</a>
[% ELSE %]
<a class="cancel" href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]">Cancel</a>
[% END %]
</fieldset>
</form>
[% END %]
</div>
</div>
[% MACRO jsinclude BLOCK %]
[% Asset.js("js/acquisitions-menu.js") %]
[% Asset.js("js/acq.js") %]
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]