David Cook
06ef68046e
This patch replaces trim() with $.trim() in admin/categorie.tt, as $.trim() is more cross-platform (ie it is supported in "< IE9"). _TEST PLAN_ Before applying patch: 0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools 1) Go to Administration > Patron categories 2) Click "Edit" next to a category 3) Click "Save" at the bottom 4) Note the form doesn't submit (you can also notice the error in the console log) Apply the patch: 5) Hold down shift + refresh the page 6) Click "Save" at the bottom" 7) Note that the form does submit and there are no errors reported Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> No regression found using iceweasel. I did not know the staff interface was IE compatible. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
455 lines
21 KiB
Text
455 lines
21 KiB
Text
[% USE KohaDates -%]
|
|
[% INCLUDE 'doc-head-open.inc' %]
|
|
<title>Koha › Administration › Patron categories › [% IF ( add_form ) %][% IF ( categorycode ) %]Modify category '[% categorycode |html %]'[% ELSE %]New category[% END %][% END %]
|
|
[% IF ( delete_confirm ) %][% IF ( patrons_in_category > 0 ) %]Cannot delete: category [% categorycode |html %] in use[% ELSE %]Confirm deletion of category '[% categorycode |html %]'[% END %][% END %]
|
|
</title>
|
|
[% INCLUDE 'doc-head-close.inc' %]
|
|
[% INCLUDE 'calendar.inc' %]
|
|
<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" />
|
|
[% INCLUDE 'datatables.inc' %]
|
|
<script type="text/javascript" id="js">
|
|
//<![CDATA[
|
|
$(document).ready(function() {
|
|
$("#table_categorie").dataTable($.extend(true, {}, dataTablesDefaults, {
|
|
"aoColumnDefs": [
|
|
{ "aTargets": [ -1, -2 ], "bSortable": false, "bSearchable": false },
|
|
{ "aTargets": [ 3,4,5 ], "sType": "natural" },
|
|
],
|
|
"aaSorting": [[ 1, "asc" ]],
|
|
"sPaginationType": "four_button"
|
|
}));
|
|
|
|
$( "#enrolmentperioddate" ).datepicker({ minDate: 1 }); // Require that "until date" be in the future
|
|
|
|
if ( $("#branches option:selected").length < 1 ) {
|
|
$("#branches option:first").attr("selected", "selected");
|
|
}
|
|
});
|
|
function isNotNull(f,noalert) {
|
|
if (f.value.length ==0) {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
//
|
|
function isNum(v,maybenull) {
|
|
var n = new Number(v.value);
|
|
if (isNaN(n)) {
|
|
return false;
|
|
}
|
|
if (maybenull==0 && v.value=='') {
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
// to check if the data are correctly entered.
|
|
function Check(ff) {
|
|
var ok=0;
|
|
var _alertString=_("Form not submitted because of the following problem(s)");
|
|
_alertString +="\n-------------------------------------------------------------------\n\n";
|
|
ff.categorycode.value = $.trim(ff.categorycode.value);
|
|
if (ff.categorycode.value.length==0) {
|
|
ok=1;
|
|
_alertString += _("- categorycode missing") + "\n";
|
|
}
|
|
else{
|
|
var patt=/^[a-zA-Z0-9\-_]+$/g;
|
|
if ( !patt.test(ff.categorycode.value) ) {
|
|
ok=1;
|
|
_alertString += _("- category code can only contain the following characters: letters, numbers, - and _") + "\n";
|
|
}
|
|
}
|
|
if (!(ff.category_type.value)){
|
|
ok=1;
|
|
_alertString += _("- category type missing") + "\n";
|
|
}
|
|
if (!(isNotNull(ff.description,1))) {
|
|
ok=1;
|
|
_alertString += _("- description missing") + "\n";
|
|
}
|
|
if (!isNum(ff.upperagelimit,0) && ff.category_type.value=='C') {
|
|
ok=1;
|
|
_alertString += _("- upperagelimit is not a number") + "\n";
|
|
|
|
}
|
|
if(!(ff.enrolmentperioddate.value || ff.enrolmentperiod.value)) {
|
|
ok=1;
|
|
_alertString += _("- either Enrollment period or Until date must be provided") + "\n";
|
|
}
|
|
if(ff.enrolmentperioddate.value && ff.enrolmentperiod.value){
|
|
document.getElementById('enrolmentmessage').className = "error";
|
|
return false;
|
|
}
|
|
|
|
if (ok) { // if there is a problem
|
|
alert(_alertString);
|
|
return false;
|
|
}
|
|
// if all is good
|
|
ff.submit();
|
|
}
|
|
//]]>
|
|
</script>
|
|
<style type="text/css">#enrolmentmessage.hint { display : none; }</style>
|
|
</head>
|
|
<body id="admin_categorie" class="admin">
|
|
[% INCLUDE 'header.inc' %]
|
|
[% INCLUDE 'patrons-admin-search.inc' %]
|
|
|
|
<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › [% IF ( add_form ) %] <a href="/cgi-bin/koha/admin/categorie.pl">Patron categories</a> › [% IF ( categorycode ) %]Modify category '[% categorycode |html %]'[% ELSE %]New category[% END %][% END %]
|
|
[% IF ( delete_confirm ) %] <a href="/cgi-bin/koha/admin/categorie.pl">Patron categories</a> › [% IF ( patrons_in_category > 0 ) %]Cannot delete: Category [% categorycode |html %] in use[% ELSE %]Confirm deletion of category '[% categorycode |html %]'[% END %][% END %]
|
|
[% IF ( delete_confirmed ) %] <a href="/cgi-bin/koha/admin/categorie.pl">Patron categories</a> › Category deleted[% END %]
|
|
[% IF ( else ) %]Patron categories[% END %]</div>
|
|
|
|
<div id="doc3" class="yui-t2">
|
|
|
|
<div id="bd">
|
|
<div id="yui-main">
|
|
<div class="yui-b">
|
|
|
|
[% FOR m IN messages %]
|
|
<div class="dialog [% m.type %]">
|
|
[% SWITCH m.code %]
|
|
[% CASE 'error_on_insert' %]
|
|
An error occurred when inserting this patron category. The patron category might already exist.
|
|
[% CASE 'error_on_delete' %]
|
|
An error occurred when deleting this patron category. Check the logs.
|
|
[% CASE 'success_on_insert' %]
|
|
Patron category added successfully
|
|
[% CASE 'success_on_delete' %]
|
|
Patron category deleted successfully.
|
|
[% CASE %]
|
|
[% m.code %]
|
|
[% END %]
|
|
</div>
|
|
[% END %]
|
|
|
|
[% IF ( add_form ) %]
|
|
<form name="Aform" action="[% script_name %]" method="post">
|
|
<input type="hidden" name="op" value="add_validate" />
|
|
<input type="hidden" name="checked" value="0" />
|
|
[% IF ( categorycode ) %]
|
|
<h1>Modify category [% categorycode |html %]</h1>
|
|
[% ELSE %]
|
|
<h1>New category</h1>
|
|
[% END %]
|
|
<fieldset class="rows">
|
|
<ol>[% IF ( categorycode ) %]
|
|
<li><span class="label">Category code: </span>[% categorycode |html %]
|
|
<input type="hidden" name="categorycode" value="[% categorycode |html %]" /><input type="hidden" name="is_a_modif" value="1" /></li>
|
|
[% ELSE %]
|
|
<li>
|
|
<label for="categorycode" class="required">Category code: </label>
|
|
<input type="text" name="categorycode" id="categorycode" size="10" maxlength="10" onblur="toUC(this)" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
[% END %]
|
|
<li>
|
|
<label for="description" class="required">Description: </label>
|
|
<input type="text" name="description" id="description" size="40" maxlength="80" value="[% description |html %]" />
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li><label for="enrolmentperiod" class="required">Enrollment period: </label>
|
|
<fieldset>
|
|
<legend>Choose one</legend>
|
|
<ol>
|
|
<li><label for="enrolmentperiod" style="width:6em;">In months: </label>
|
|
<input type="text" name="enrolmentperiod" id="enrolmentperiod" size="3" maxlength="3" value="[% IF ( enrolmentperiod ) %][% enrolmentperiod %][% END %]" /> months</li>
|
|
<li><label for="enrolmentperioddate" style="width:6em;">Until date: </label>
|
|
<input type="text" name="enrolmentperioddate" id="enrolmentperioddate" value="[% enrolmentperioddate | $KohaDates %]" />
|
|
<div id="enrolmentmessage" class="hint" style="margin-left:0;">Cannot have "months" and "until date" at the same time</div>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
</li>
|
|
<li><label for="dateofbirthrequired">Age required: </label> <input type="text" name="dateofbirthrequired" id="dateofbirthrequired" value="[% dateofbirthrequired %]" size="3" maxlength="3" /> years</li>
|
|
<li><label for="upperagelimit">Upperage limit: </label> <input type="text" name="upperagelimit" id="upperagelimit" size="3" maxlength="3" value="[% upperagelimit %]" /> years</li>
|
|
<li><label for="enrolmentfee">Enrollment fee: </label><input type="text" name="enrolmentfee" id="enrolmentfee" size="6" value="[% enrolmentfee %]" /></li>
|
|
<li><label for="overduenoticerequired">Overdue notice required: </label> <select name="overduenoticerequired" id="overduenoticerequired">
|
|
[% IF ( overduenoticerequired ) %]
|
|
<option value="0">No</option>
|
|
<option value="1" selected="selected">Yes</option>
|
|
[% ELSE %]
|
|
<option value="0" selected="selected">No</option>
|
|
<option value="1">Yes</option>
|
|
[% END %]
|
|
</select></li>
|
|
<li><label for="hidelostitems">Lost items in staff client: </label> <select name="hidelostitems" id="hidelostitems">
|
|
[% IF ( hidelostitems ) %]
|
|
<option value="0">Shown</option>
|
|
<option value="1" selected="selected">Hidden by default</option>
|
|
[% ELSE %]
|
|
<option value="0" selected="selected">Shown</option>
|
|
<option value="1">Hidden by default</option>
|
|
[% END %]
|
|
</select></li>
|
|
<li><label for="reservefee">Hold fee: </label><input type="text" name="reservefee" id="reservefee" size="6" value="[% reservefee %]" /></li>
|
|
<li>
|
|
<label for="category_type" class="required">Category type: </label>
|
|
<select name="category_type" id="category_type">
|
|
[% IF ( type_n ) %]<option value="" selected="selected">Select a category type</option>[% ELSE %]<option value="">Select a category type</option>[% END %]
|
|
[% IF ( type_A ) %]<option value="A" selected="selected">Adult</option>[% ELSE %]<option value="A">Adult</option>[% END %]
|
|
[% IF ( type_C ) %]<option value="C" selected="selected">Child</option>[% ELSE %]<option value="C">Child</option>[% END %]
|
|
[% IF ( type_S ) %]<option value="S" selected="selected">Staff</option>[% ELSE %]<option value="S">Staff</option>[% END %]
|
|
[% IF ( type_I ) %]<option value="I" selected="selected">Organization</option>[% ELSE %]<option value="I">Organization</option>[% END %]
|
|
[% IF ( type_P ) %]<option value="P" selected="selected">Professional</option>[% ELSE %]<option value="P">Professional</option>[% END %]
|
|
[% IF ( type_X ) %]<option value="X" selected="selected">Statistical</option>[% ELSE %]<option value="X">Statistical</option>[% END %]
|
|
</select>
|
|
<span class="required">Required</span>
|
|
</li>
|
|
<li><label for="branches">Branches limitation: </label>
|
|
<select id="branches" name="branches" multiple size="10">
|
|
<option value="">All branches</option>
|
|
[% FOREACH branch IN branches_loop %]
|
|
[% IF ( branch.selected ) %]
|
|
<option selected="selected" value="[% branch.branchcode %]">[% branch.branchname %]</option>
|
|
[% ELSE %]
|
|
<option value="[% branch.branchcode %]">[% branch.branchname %]</option>
|
|
[% END %]
|
|
[% END %]
|
|
</select>
|
|
<span>Select <i>All branches</i> if this category type must to be displayed all the time. Otherwise select libraries you want to associate with this value.
|
|
</span>
|
|
</li>
|
|
<li><label for="block_expired">Block expired patrons</label>
|
|
<select name="block_expired" id="block_expired">
|
|
[% IF ( BlockExpiredPatronOpacActions == -1 ) %]
|
|
<option value="-1" selected="selected"> Follow system preference BlockExpiredPatronOpacActions </option>
|
|
[% ELSE %]
|
|
<option value="-1"> Follow system preference BlockExpiredPatronOpacActions </option>
|
|
[% END %]
|
|
|
|
[% IF ( BlockExpiredPatronOpacActions == 1 ) %]
|
|
<option value="1" selected="selected"> Block </option>
|
|
[% ELSE %]
|
|
<option value="1"> Block </option>
|
|
[% END %]
|
|
|
|
[% IF ( BlockExpiredPatronOpacActions == 0 ) %]
|
|
<option value="0" selected="selected"> Don't block </option>
|
|
[% ELSE %]
|
|
<option value="0"> Don't block </option>
|
|
[% END %]
|
|
</select>
|
|
<span>
|
|
Choose whether patrons of this category be blocked from public catalog actions such as renewing and placing holds when their cards have expired.
|
|
</span>
|
|
</li>
|
|
<li>
|
|
<label for="default_privacy">Default privacy: </label>
|
|
<select id="default_privacy" name="default_privacy">
|
|
[% SWITCH default_privacy %]
|
|
[% CASE 'forever' %]
|
|
<option value="default">Default</option>
|
|
<option value="never">Never</option>
|
|
<option value="forever" selected="selected">Forever</option>
|
|
[% CASE 'never' %]
|
|
<option value="default">Default</option>
|
|
<option value="never" selected="selected">Never</option>
|
|
<option value="forever">Forever</option>
|
|
[% CASE %]
|
|
<option value="default" selected="selected">Default</option>
|
|
<option value="never">Never</option>
|
|
<option value="forever">Forever</option>
|
|
[% END %]
|
|
</select>
|
|
<span>Controls how long a patrons checkout history is kept for new patrons of this category. "Never" anonymizes checkouts on return, and "Forever" keeps a patron's checkout history indefinitely. When set to "Default", the amount of history kept is controlled by the cronjob <i>batch_anonymise.pl</i> which should be set up by your system administrator.</span>
|
|
</li>
|
|
</ol>
|
|
</fieldset>
|
|
|
|
[% IF ( EnhancedMessagingPreferences ) %]
|
|
<fieldset class="rows">
|
|
<h4>Default messaging preferences for this patron category</h4>
|
|
[% INCLUDE 'messaging-preference-form.inc' %]
|
|
</fieldset>
|
|
[% END %]
|
|
<fieldset class="action"><input type="button" value="Save" onclick="Check(this.form);" /> </fieldset>
|
|
</form>
|
|
|
|
[% END %]
|
|
|
|
[% IF ( delete_confirm ) %]
|
|
<form action="[% script_name %]" method="post">
|
|
<fieldset>
|
|
<legend>
|
|
[% IF ( patrons_in_category > 0 ) %]
|
|
Category [% categorycode |html %] is in use. Deletion not possible!
|
|
[% ELSE %]
|
|
Confirm deletion of category [% categorycode |html %]
|
|
[% END %]
|
|
</legend>
|
|
|
|
[% IF ( totalgtzero ) %]<div class="dialog alert"><strong>This category is used [% total %] times</strong>. Deletion not possible</div>[% END %]
|
|
<table>
|
|
<tr><th scope="row">Category code: </th><td>[% categorycode |html %]</td></tr>
|
|
<tr><th scope="row">Description: </th><td>[% description |html %]</td></tr>
|
|
<tr><th scope="row">Enrollment period: </th>
|
|
<td>
|
|
[% IF ( enrolmentperiod ) %]
|
|
[% enrolmentperiod %] months
|
|
[% ELSE %]
|
|
until [% enrolmentperioddate | $KohaDates %]
|
|
[% END %]
|
|
</td>
|
|
</tr>
|
|
<tr><th scope="row">Age required: </th><td>[% dateofbirthrequired %] years</td></tr>
|
|
<tr><th scope="row">Upperage limit: </th><td>[% upperagelimit %] years</td></tr>
|
|
<tr><th scope="row">Enrollment fee: </th><td>[% enrolmentfee %]</td></tr>
|
|
<tr><th scope="row">Receives overdue notices: </th><td>[% IF ( overduenoticerequired ) %]Yes[% ELSE %]No[% END %]</td></tr>
|
|
<tr><th scope="row">Lost items in staff client</th><td>[% IF ( hidelostitems ) %]Hidden by default[% ELSE %]Shown[% END %]</td></tr>
|
|
<tr><th scope="row">Hold fee: </th><td>[% reservefee %]</td></tr>
|
|
<tr>
|
|
<th scope="row">Default privacy: </th>
|
|
<td>
|
|
[% SWITCH category.default_privacy %]
|
|
[% CASE 'default' %]
|
|
Default
|
|
[% CASE 'never' %]
|
|
Never
|
|
[% CASE 'forever' %]
|
|
Forever
|
|
[% END %]
|
|
</td>
|
|
</tr>
|
|
</table>
|
|
<fieldset class="action">[% IF ( totalgtzero ) %]
|
|
<input type="submit" value="OK" /></form>
|
|
[% ELSE %]
|
|
<input type="hidden" name="op" value="delete_confirmed" />
|
|
<input type="hidden" name="categorycode" value="[% categorycode |html %]" /> <input type="submit" value="Delete this category" /> <a class="cancel" href="/cgi-bin/koha/admin/categorie.pl">Cancel</a>
|
|
[% END %]</fieldset></fieldset></form>
|
|
[% END %]
|
|
|
|
[% IF ( else ) %]
|
|
|
|
<div id="toolbar" class="btn-toolbar">
|
|
<a class="btn btn-small" id="newcategory" href="/cgi-bin/koha/admin/categorie.pl?op=add_form"><i class="icon-plus"></i> New category</a>
|
|
</div>
|
|
|
|
<h2>Patron category administration</h2>
|
|
[% IF ( searchfield ) %]
|
|
You Searched for [% searchfield %]</span>
|
|
[% END %]
|
|
[% IF ( loop ) %]
|
|
<div id="pagertable_categorie">
|
|
</div>
|
|
<table id="table_categorie">
|
|
<thead>
|
|
<tr>
|
|
<th scope="col">Code</th>
|
|
<th scope="col">Category name</th>
|
|
<th scope="col">Type</th>
|
|
<th scope="col">Enrollment period</th>
|
|
<th scope="col">Age required</th>
|
|
<th scope="col">Upper age limit</th>
|
|
<th scope="col">Enrollment fee</th>
|
|
<th scope="col">Overdue</th>
|
|
<th scope="col">Lost items</th>
|
|
<th scope="col">Hold fee</th>
|
|
[% IF ( EnhancedMessagingPreferences ) %]
|
|
<th scope="col">Messaging</th>
|
|
[% END %]
|
|
<th scope="col">Branches limitations</th>
|
|
<th scope="col">Default privacy</th>
|
|
<th scope="col"> </th>
|
|
<th scope="col"> </th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
[% FOREACH loo IN loop %]
|
|
<tr>
|
|
<td>[% loo.categorycode |html %]</td>
|
|
<td>
|
|
<a href="[% loo.script_name %]?op=add_form&categorycode=[% loo.categorycode |uri %]">[% loo.description |html %]</a>
|
|
</td>
|
|
<td>
|
|
[% IF ( loo.type_A ) %]Adult[% END %]
|
|
[% IF ( loo.type_C ) %]Child[% END %]
|
|
[% IF ( loo.type_P ) %]Prof.[% END %]
|
|
[% IF ( loo.type_I ) %]Org.[% END %]
|
|
[% IF ( loo.type_S ) %]Staff[% END %]
|
|
[% IF ( loo.type_X ) %]Statistical[% END %]
|
|
</td>
|
|
<td>
|
|
[% IF ( loo.enrolmentperiod ) %]
|
|
[% loo.enrolmentperiod %] months
|
|
[% ELSE %]
|
|
until [% loo.enrolmentperioddate | $KohaDates %]
|
|
[% END %]
|
|
|
|
</td>
|
|
<td>[% loo.dateofbirthrequired %] years</td>
|
|
<td>[% loo.upperagelimit %] years</td>
|
|
<td>[% loo.enrolmentfee %]</td>
|
|
<td>[% IF ( loo.overduenoticerequired ) %]Yes[% ELSE %]No[% END %]</td>
|
|
<td>[% IF ( loo.hidelostitems ) %]Hidden[% ELSE %]Shown[% END %]</td>
|
|
<td>[% loo.reservefee %]</td>
|
|
[% IF ( EnhancedMessagingPreferences ) %]
|
|
<td style="white-space: nowrap; font-size:80%;">
|
|
[% IF ( loo.messaging_prefs ) %]
|
|
[% FOREACH prefs IN loo.messaging_prefs %]
|
|
[% FOREACH transport IN prefs.transports %]
|
|
[% IF ( transport.transport ) %]
|
|
[% IF ( prefs.Item_Due ) %]Item due
|
|
[% ELSIF ( prefs.Advance_Notice ) %]Advance notice
|
|
[% ELSIF ( prefs.Upcoming_Events ) %]Upcoming events
|
|
[% ELSIF ( prefs.Hold_Filled ) %]Hold filled
|
|
[% ELSIF ( prefs.Item_Check_in ) %]Item check-in
|
|
[% ELSIF ( prefs.Item_Checkout ) %]Item checkout
|
|
[% ELSE %]Unknown
|
|
[% END %]:
|
|
<strong>[% transport.transport %]</strong><br />
|
|
[% ELSE %]None<br />[% END %]
|
|
[% END %]
|
|
[% END %]
|
|
[% ELSE %]
|
|
None
|
|
[% END %]
|
|
</td>
|
|
[% END %]
|
|
<td>
|
|
[% IF loo.branches.size > 0 %]
|
|
[% branches_str = "" %]
|
|
[% FOREACH branch IN loo.branches %]
|
|
[% branches_str = branches_str _ " " _ branch.branchname _ "(" _ branch.branchcode _ ")" %]
|
|
[% END %]
|
|
<span title="[% branches_str %]">
|
|
[% IF loo.branches.size > 1 %]
|
|
[% loo.branches.size %] branches limitations
|
|
[% ELSE %]
|
|
[% loo.branches.size %] branch limitation
|
|
[% END %]
|
|
</span>
|
|
[% ELSE %]
|
|
No limitation
|
|
[% END %]
|
|
</td>
|
|
<td>
|
|
[% SWITCH loo.default_privacy %]
|
|
[% CASE 'default' %]
|
|
Default
|
|
[% CASE 'never' %]
|
|
Never
|
|
[% CASE 'forever' %]
|
|
Forever
|
|
[% END %]
|
|
</td>
|
|
<td><a href="[% loo.script_name %]?op=add_form&categorycode=[% loo.categorycode |uri %]">Edit</a></td>
|
|
<td><a href="[% loo.script_name %]?op=delete_confirm&categorycode=[% loo.categorycode |uri %]">Delete</a></td>
|
|
</tr>
|
|
[% END %]
|
|
</tbody>
|
|
</table>
|
|
[% ELSE %]
|
|
<div class="dialog alert">No categories have been defined. <a href="/cgi-bin/koha/admin/categorie.pl?op=add_form">Create a new category</a>.</div>
|
|
[% END %]
|
|
[% END %]
|
|
|
|
</div>
|
|
</div>
|
|
<div class="yui-b">
|
|
[% INCLUDE 'admin-menu.inc' %]
|
|
</div>
|
|
</div>
|
|
[% INCLUDE 'intranet-bottom.inc' %]
|