Koha/cataloguing
Jonathan Druart d561273ef8 Bug 21986: Do not escape quotation marks when cataloguing
In several places we escape quotation marks using
  $value =~ s/"/"/g;
All the occurrences are wrong and must be removed.
Most of them are leftover of bug 11638 (Remove HTML from
addbiblio.pl), which removes the construction of html from pl scripts.

The problem has been highlighted by bug 13618, I did not track down why
the issue did not exist before (?)

Test plan:
0/ Use strings with quotation marks, like:
'Fiddle tune history : "bad" tunes'
You can also use other html characters to make the tests more complete,
like 'Fiddle tune history : <"bad" tunes>'
1/ authorities/authorities.pl
a. Edit an authority filling different fields with quotation marks
b. Edit it again
=> The display (inputs' values) is wrong, if you save the escaped quotes
will be inserted
2/ cataloguing/addbiblio.pl
Same editing a bibliographic record
3/ cataloguing/additem.pl
Same editing items
4/ members/memberentry.pl
Edit a patron's record and fill some fields with quotation marks
+ fields borrowernotes and opacnotes
=> The quotes are inserted directly in DB (escape is done before the
insert!)
5/ opac/opac-review.pl
For QA only: $js_ok_review is never used
6/ tools/batchMod.pl
For QA only: $value is always undefined at that point

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-12-14 13:33:28 +00:00
..
value_builder Bug 20435: Allow lowercase prefix in inventory value builder 2018-11-06 17:42:31 +00:00
addbiblio.pl Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
addbooks.pl Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories 2018-11-02 10:33:09 +00:00
additem.pl Bug 21986: Do not escape quotation marks when cataloguing 2018-12-14 13:33:28 +00:00
editor.pl Bug 16424: Add framework support to advanced MARC editor 2018-09-28 19:01:50 +00:00
linkitem.pl Bug 20829: Handle non-existent barcode when linking to host item 2018-06-08 09:48:11 -04:00
merge.pl Bug 18593: Move suggestions when bibliographic records are merged 2018-03-26 17:01:10 -03:00
merge_ajax.pl
moveitem.pl Bug 19996: (QA follow-up) Remove commented use warnings; 2018-02-05 09:45:47 -03:00
plugin_launcher.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
ysearch.pl
z3950_auth_search.pl Bug 21318: Add control number as an option to search authority using Z39.50 2018-10-01 11:11:37 +00:00
z3950_search.pl Bug 19996: use Modern::Perl in cataloguing perl scripts 2018-02-05 09:45:47 -03:00