Mirko Tietgen eba47394d1 Bug 18547: On shelf holds allowed > "If all unavailable" ignores default hold policy ... If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Followed test plan in the intranet and OPAC, worked as intended. With few assumptions made: - when the hold works, should be on the item 1 (Centerville) item 2 is only there to trigger the bug - the circ rules were identically setup on each branch and in "Standard rules for all libraries" Signed-off-by: Victor Grousset <victor.grousset@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2017-11-26 11:30:17 -03:00
..
AuthoritiesMarc	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Barcodes	Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead	2016-09-13 17:21:05 +00:00
ClassSortRoutine	Bug 16011: $VERSION - Remove use vars qw();	2016-03-24 17:20:39 +00:00
Creators	Bug 14143 - Patron cards: Crash (confusion between table names creator_templates and club_template_enrollment_fields)	2017-04-28 08:39:41 -04:00
External	Bug 17189: Replace occurrences of 'use Koha::Cache'	2016-09-08 10:24:47 +00:00
Form	Bug 16259: Replace CGI->param with CGI->multi_param in list context - part 2	2016-05-16 17:28:06 +00:00
Heading	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
ILSDI	Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel	2017-09-12 12:42:58 -03:00
Installer	Bug 18137: List Mojolicious::Plugin::OpenAPI and JSON::Validator as dependencies	2017-09-21 11:27:05 -03:00
Labels	Bug 19040: Refactor GetMarcBiblio parameters	2017-08-25 10:23:42 -03:00
Linker	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Members	Bug 17825: (followup) Remove unused function AttributeTypeExists	2017-03-31 14:37:21 +00:00
OAI	Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios	2017-06-13 16:18:59 -03:00
Output	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Patroncards	Bug 18550: [Follow-up] Add POD descriptions to subs	2017-10-06 12:09:55 -03:00
Reports	Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml'	2017-10-25 12:14:32 -03:00
Search	Bug 17323: Column search_history.time cannot be null	2016-11-18 13:51:37 +00:00
Serials	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
SIP	Bug 10748: (QA follow-up) Add comment in SIP's do_checkin	2017-11-08 11:07:48 -03:00
Utils	Bug 19418: (bug 12833 follow-up) Add missing use statement	2017-10-10 10:18:35 -03:00
Accounts.pm	Bug 12768: Fix bad merge resolution conflict	2017-10-23 16:59:13 -03:00
Acquisition.pm	Bug 19528: Fix a few typos like corrosponding	2017-10-27 14:09:04 -03:00
Auth.pm	Bug 17989: Include full path logic in _get_template_file	2017-11-01 13:10:17 -03:00
Auth_cas_servers.yaml.sample	Bug 17065 - Rename C4/Auth_cas_servers.yaml.orig	2016-08-08 13:16:36 +00:00
Auth_with_cas.pm	Bug 19373: CAS logout - Redirect to the previous page (Intranet)	2017-10-16 09:38:41 -03:00
Auth_with_ldap.pm	Bug 14625 - LDAP: skip extended patron attributes in 'borrowers' attribute update	2017-05-19 09:52:05 -04:00
Auth_with_shibboleth.pm	Bug 12026: [QA Follow-up] Fix a POD line	2017-03-31 14:28:18 +00:00
AuthoritiesMarc.pm	Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05	2017-10-09 13:46:41 -03:00
BackgroundJob.pm	Bug 16011: $VERSION - Remove empty BEGIN block	2016-03-24 17:20:41 +00:00
Barcodes.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Biblio.pm	Bug 19528: Fix a few typos like corrosponding	2017-10-27 14:09:04 -03:00
Bookseller.pm	Bug 14535: Update the supplier filter too	2017-03-31 12:38:44 +00:00
Boolean.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Breeding.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
Budgets.pm	Bug 18999: Modified SQL query in GetBudgetSpent() in C4/Budgets.pm	2017-09-29 13:03:38 -03:00
Calendar.pm	Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT	2017-07-06 14:29:04 -03:00
Charset.pm	Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag"	2017-07-26 14:01:51 -03:00
Circulation.pm	Bug 18882: Add location code to statistics table for checkouts and renewals	2017-11-08 13:34:32 -03:00
ClassSortRoutine.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
ClassSource.pm	Bug 17208: Checking if classification source or filing rule already exists before adding	2016-12-23 11:33:48 +00:00
Context.pm	Bug 18771: CGI.pm: Subroutine multi_param redefined	2017-07-06 14:29:03 -03:00
Contract.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
CourseReserves.pm	Bug 18276: Remove GetBiblioFromItemNumber - Course reserves	2017-07-10 12:09:24 -03:00
Creators.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Debug.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Heading.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
HoldsQueue.pm	Bug 19040: Refactor GetMarcBiblio parameters	2017-08-25 10:23:42 -03:00
HTML5Media.pm	Bug 17501: Remove Koha::Upload::get from Koha::Upload	2017-01-20 14:20:05 +00:00
Images.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
ImportBatch.pm	Bug 19049: [QA Follow-up] Mock config, default format	2017-08-15 12:17:42 -03:00
ImportExportFramework.pm	Bug 17389: Clear logs	2016-10-11 16:18:10 +00:00
InstallAuth.pm	Bug 18578: Use subdirectory in /tmp for session storage during installation	2017-05-19 10:46:37 -04:00
Installer.pm	Bug 14826: account_offset_types.sql is not in the mandatory subdir	2017-10-20 18:14:06 -03:00
ItemCirculationAlertPreference.pm	Bug 15407: Koha::Patron::Categories - replace C4::Category->all	2016-09-08 13:29:03 +00:00
Items.pm	Bug 19350 - Holds without link in 773 trigger SQL::Abstract::puke	2017-10-03 12:16:49 -03:00
Koha.pm	Bug 17843: Remove C4::Koha::getitemtypeinfo	2017-07-05 13:42:21 -03:00
Labels.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Languages.pm	Bug 16770: Remove wrong caching of 3 subroutines in C4::Lancuages	2016-06-24 14:05:56 +00:00
Letters.pm	Bug 18894: (QA follow-up) POD changes	2017-11-08 13:35:28 -03:00
Linker.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
Log.pm	Bug 19528: Fix a few typos like corrosponding	2017-10-27 14:09:04 -03:00
MarcModificationTemplates.pm	Bug 19069: Fix 'does not match' behaviour in MARC modification template	2017-10-27 14:09:01 -03:00
Matcher.pm	Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic	2017-06-15 15:27:46 -03:00
Members.pm	Bug 13178: Correct Max cardnumberlength	2017-10-27 14:10:27 -03:00
Message.pm	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
NewsChannels.pm	Bug 19528: Fix a few typos like corrosponding	2017-10-27 14:09:04 -03:00
Output.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
Overdues.pm	Bug 14826: (QA follow-up) Only use plural modules in other modules	2017-10-20 17:14:32 -03:00
Patroncards.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Print.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
Record.pm	Bug 19040: Refactor GetMarcBiblio parameters	2017-08-25 10:23:42 -03:00
Reports.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
Reserves.pm	Bug 18547: On shelf holds allowed > "If all unavailable" ignores default hold policy	2017-11-26 11:30:17 -03:00
Ris.pm	Bug 16245: [QA Follow-up] Replace typeofrecord2 by biblevel	2016-10-21 14:51:55 +00:00
RotatingCollections.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
Scheduler.pm	Bug 16011: $VERSION - Remove comments	2016-03-24 17:20:29 +00:00
Scrubber.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
Search.pm	Bug 19040: Refactor GetMarcBiblio parameters	2017-08-25 10:23:42 -03:00
Serials.pm	Bug 19528: Fix a few typos like corrosponding	2017-10-27 14:09:04 -03:00
Service.pm	Bug 7550: [QA Follow-up] Resolve param warning from sco-patron-image	2017-05-08 09:00:26 -04:00
ShelfBrowser.pm	Bug 19040: Refactor GetMarcBiblio parameters	2017-08-25 10:23:42 -03:00
SMS.pm	Bug 19134: C4::SMS falils on long driver name	2017-08-25 10:51:24 -03:00
SocialData.pm	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Stats.pm	Bug 18882: (QA follow-up) Ensure stats with no or undef location are set to NULL in db	2017-11-08 13:34:37 -03:00
Suggestions.pm	Bug 17762: Send lang to GetPreparedLetter	2017-05-09 20:56:41 +00:00
Tags.pm	Bug 16637: Dependency for C4::Tags not listed	2016-06-10 18:05:10 +00:00
Templates.pm	Bug 17989: Resolve "verbatim paragraph in NAME section" warning in C4::Templates	2017-11-01 13:10:17 -03:00
TmplToken.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
TmplTokenType.pm	Bug 16011: $VERSION - Remove the $VERSION init	2016-03-24 17:20:28 +00:00
TTParser.pm	Bug 14383: C4: Fix some typos (mostly in comments and documentation)	2015-06-22 17:34:45 -03:00
UsageStats.pm	Bug 10748: Add the ability to block return of lost items	2017-11-08 11:07:09 -03:00
XISBN.pm	Bug 19440: Identify overlimit problems in XISBN tests	2017-10-09 16:15:52 -03:00
XSLT.pm	Bug 18921: Resolve a few warnings in C4/XSLT.pm	2017-09-07 14:34:42 -03:00