b37e510eb8
When there are a lot of budgets with the same owner, most of the time of
acqui-home.pl is spent loading the same patron over and over.
This patch makes sure each borrower is loaded only once.
Test plan:
0. Do not apply the patch yet
1. Create a thousand budgets with the following command (make sure the
budget_owner_id is an existing borrowernumber):
perl -MKoha::Database -e '
my $schema = Koha::Database->schema;
my $period = $schema->resultset("Aqbudgetperiod")->create({
budget_period_startdate => "2000-01-01",
budget_period_enddate => "2999-12-31"
});
$schema->resultset("Aqbudget")->create({
budget_owner_id => 1,
budget_period_id => $period->id
}) for (1..1000)
'
2. Measure the time it takes to load acqui/acqui-home.pl (do it several
times and keep the average time)
3. Apply the patch
4. Repeat step 2
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 24b33936a5
)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
141 lines
4.6 KiB
Perl
Executable file
141 lines
4.6 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2008 - 2009 BibLibre SARL
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
=head1 NAME
|
|
|
|
acqui-home.pl
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
this script is the main page for acqui
|
|
|
|
=cut
|
|
|
|
use Modern::Perl;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth qw( get_template_and_user );
|
|
use C4::Output qw( output_html_with_http_headers );
|
|
use C4::Budgets qw( GetBudgetHierarchy GetBudget CanUserUseBudget );
|
|
use C4::Members;
|
|
use Koha::Acquisition::Currencies;
|
|
use Koha::Patrons;
|
|
use Koha::Suggestions;
|
|
|
|
my $query = CGI->new;
|
|
my ( $template, $loggedinuser, $cookie, $userflags ) = get_template_and_user(
|
|
{ template_name => 'acqui/acqui-home.tt',
|
|
query => $query,
|
|
type => 'intranet',
|
|
flagsrequired => { acquisition => '*' },
|
|
}
|
|
);
|
|
|
|
my $status = $query->param('status') || "ASKED";
|
|
# Get current branch count and total viewable count, if they don't match then pass
|
|
# both to template
|
|
if( C4::Context->only_my_library ){
|
|
my $local_pendingsuggestions_count = Koha::Suggestions->search({ status => "ASKED", branchcode => C4::Context->userenv()->{'branch'} })->count();
|
|
$template->param( suggestions_count => $local_pendingsuggestions_count );
|
|
} else {
|
|
my $pendingsuggestions = Koha::Suggestions->search({ status => "ASKED" });
|
|
my $local_pendingsuggestions_count = $pendingsuggestions->search({ 'me.branchcode' => C4::Context->userenv()->{'branch'} })->count();
|
|
my $pendingsuggestions_count = $pendingsuggestions->count();
|
|
$template->param(
|
|
all_pendingsuggestions => $pendingsuggestions_count != $local_pendingsuggestions_count ? $pendingsuggestions_count : 0,
|
|
suggestions_count => $local_pendingsuggestions_count
|
|
);
|
|
}
|
|
|
|
my $budget_arr = GetBudgetHierarchy;
|
|
|
|
my $total = 0;
|
|
my $totspent = 0;
|
|
my $totordered = 0;
|
|
my $totcomtd = 0;
|
|
my $totavail = 0;
|
|
|
|
my $total_active = 0;
|
|
my $totspent_active = 0;
|
|
my $totordered_active = 0;
|
|
my $totavail_active = 0;
|
|
|
|
my @budget_loop;
|
|
my %patrons = ( $loggedinuser => Koha::Patrons->find($loggedinuser) );
|
|
my $loggedinpatron = $patrons{$loggedinuser}->unblessed;
|
|
foreach my $budget ( @{$budget_arr} ) {
|
|
next unless (CanUserUseBudget($loggedinpatron, $budget, $userflags));
|
|
|
|
if ( my $borrowernumber = $budget->{budget_owner_id} ) {
|
|
unless ( exists $patrons{$borrowernumber} ) {
|
|
$patrons{$borrowernumber} = Koha::Patrons->find($borrowernumber);
|
|
}
|
|
$budget->{budget_owner} = $patrons{$borrowernumber};
|
|
}
|
|
|
|
if ( !defined $budget->{budget_amount} ) {
|
|
$budget->{budget_amount} = 0;
|
|
}
|
|
if ( !defined $budget->{budget_spent} ) {
|
|
$budget->{budget_spent} = 0;
|
|
}
|
|
if ( !defined $budget->{budget_ordered} ) {
|
|
$budget->{budget_ordered} = 0;
|
|
}
|
|
$budget->{'budget_avail'} =
|
|
$budget->{'budget_amount'} - ( $budget->{'budget_spent'} + $budget->{'budget_ordered'} );
|
|
$budget->{'total_avail'} =
|
|
$budget->{'budget_amount'} - ( $budget->{'total_spent'} + $budget->{'total_ordered'} );
|
|
|
|
$total += $budget->{'budget_amount'};
|
|
$totspent += $budget->{'budget_spent'};
|
|
$totordered += $budget->{'budget_ordered'};
|
|
$totavail += $budget->{'budget_avail'};
|
|
|
|
if ($budget->{budget_period_active}){
|
|
$total_active += $budget->{'budget_amount'};
|
|
$totspent_active += $budget->{'budget_spent'};
|
|
$totordered_active += $budget->{'budget_ordered'};
|
|
$totavail_active += $budget->{'budget_avail'};
|
|
}
|
|
|
|
push @budget_loop, $budget;
|
|
}
|
|
|
|
$template->param(
|
|
type => 'intranet',
|
|
loop_budget => \@budget_loop,
|
|
total => $total,
|
|
totspent => $totspent,
|
|
totordered => $totordered,
|
|
totcomtd => $totcomtd,
|
|
totavail => $totavail,
|
|
total_active => $total_active,
|
|
totspent_active => $totspent_active,
|
|
totordered_active => $totordered_active,
|
|
totavail_active => $totavail_active,
|
|
);
|
|
|
|
my $cur = Koha::Acquisition::Currencies->get_active;
|
|
if ( $cur ) {
|
|
$template->param(
|
|
currency => $cur->currency,
|
|
);
|
|
}
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|