Koha/acqui
Katrin Fischer d924e892a8 Bug 17458: Remove use of datereceived from order receive page
Before this patch the order receive page (parcel.pl) would show
... Received by: <current user> On: <current date>

This is not really helpful. Whenever you viewed an invoice, it
would tell you it was _you_ who received that _today_.

As we don't store a creator of an invoice and the order lines
in an invoice could have been received by different people (which
we also don't know about), the "Received by" is removed by this patch.

Instead of today's date, we can show the shipment date entered for
the invoice. Again: different order lines could have been received
on different dates for this shipment. So only the shipment date makes
sense as it's on invoice level.

This also makes changes to the page title, breadcrumby and page heading:
When the invoice is closed, they will read:
  Receipt summary for [vendor] ...
When the invoice is not closed, they wil read:
  Receive orders from [vendor] ...

To test:
- Create a basket with some orders in acq
- Close the basket
- Receive shipment and create an invoice
  - Make sure shipment date is not set to today
- Verify the information shown on top of parcel.pl is you and today
- Change staff users
- Go to your invoice, it's now this user and today
- Apply patch
- Received by: should be gone and the On: replaced by Shipment date:
  with the date you selected
- Check the page title, breadcrumbs and headings read all the same 'Receive orders...'
- Finish receiving and close the invoice
- "Go to receipt page"
- Verify they now read "Receipt summary.."

If you have older invoices in your system, it would work
even better with these as you'd see that always today's date
is displaying without the patch.

Signed-off-by: Marjorie <marjorie.barry-vila@collecto.ca>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2020-09-28 16:09:10 +02:00
..
acqui-home.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
add_user_search.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
addorder.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
addorderiso2709.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
ajax-getauthvaluedropbox.pl Bug 22391: Remove group by clause in ajax-getauthvaluedropbox.pl 2019-02-21 16:48:28 +00:00
basket.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
basketgroup.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
basketheader.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
booksellers.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
cancelorder.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
check_budget_total.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
check_uniqueness.pl Bug 23463: Replace SearchItemsByField by SearchItems 2020-03-23 09:26:09 +00:00
duplicate_orders.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
edi_ean.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
edifactmsgs.pl Bug 23682: Fix use Koha::Plugins::Handler statements 2020-09-03 15:00:48 +02:00
edimsg.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
finishreceive.pl Bug 23596: Edit suggestion's reason when receiving 2020-04-14 16:30:16 +01:00
histsearch.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
invoice-files.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
invoice.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
invoices.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
lateorders-export.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
lateorders.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
modordernotes.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
neworderempty.pl Bug 10921: Prevent an order from a closed basket to be edited 2020-09-18 11:49:29 +02:00
newordersubscription.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
newordersuggestion.pl Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion 2019-05-15 16:46:47 +00:00
ordered.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
orderreceive.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
parcel.pl Bug 17458: Remove use of datereceived from order receive page 2020-09-28 16:09:10 +02:00
parcels.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
showorder.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
spent.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
supplier.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
transferorder.pl
uncertainprice.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
updatesupplier.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
z3950_search.pl Bug 21921: Add date publication year to biblio Z39.50 search form in acquisition 2020-02-17 13:44:34 +00:00