Koha/opac/opac-sendbasket.pl
Chris Cormack 9d6ca5e67a Bug 36520: Sanitize input in opac-sendbasket.pl
To test
1/ Add some items to your cart in the opac
2/ Choose send cart
3/ Open firefox developer tools and switch to the network tab
4/ Send cart
5/ In the network tab, find the post request and choose copy as curl
6/ Edit the curl command to add )+AND+(SELECT+1+FROM+(SELECT(SLEEP(6)))x)--+-  to the bib_list parameter
7/ Run the curl notice it takes a long time to respond, if you want to check run the curl without the above part added
8/ Apply the patch and restart plack
9/ Run the modified curl and notice no longer the slow down
10/ Test in browser and make sure the basket is still sent

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2024-06-07 13:16:28 +00:00

129 lines
4 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright Doxulting 2004
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# Koha is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use CGI qw ( -utf8 );
use Encode;
use C4::Auth qw( get_template_and_user );
use C4::Biblio qw(GetMarcSubjects);
use C4::Output qw( output_html_with_http_headers );
use C4::Templates;
use Koha::Biblios;
use Koha::Email;
use Koha::Patrons;
use Koha::Token;
my $query = CGI->new;
my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
{
template_name => "opac-sendbasketform.tt",
query => $query,
type => "opac",
}
);
my $patron = Koha::Patrons->find($borrowernumber);
my $user_email = $patron ? $patron->notice_email_address : undef;
my $bib_list = $query->param('bib_list') || '';
my $email_add = $query->param('email_add');
if ( $email_add ) {
die "Wrong CSRF token"
unless Koha::Token->new->check_csrf(
{
session_id => scalar $query->cookie('CGISESSID'),
token => scalar $query->param('csrf_token'),
}
);
my $comment = $query->param('comment');
my @bibs = split( /\//, $bib_list );
my $iso2709;
foreach my $bib (@bibs) {
$bib = int($bib);
my $biblio = Koha::Biblios->find($bib) or next;
$iso2709 .= $biblio->metadata->record->as_usmarc();
}
if ( !defined $iso2709 ) {
$template->param( error => 'NO_BODY' );
}
else {
my %loops = ( biblio => \@bibs, );
my %substitute = ( comment => $comment, );
my $letter = C4::Letters::GetPreparedLetter(
module => 'catalogue',
letter_code => 'CART',
lang => $patron->lang,
tables => {
borrowers => $borrowernumber,
},
message_transport_type => 'email',
loops => \%loops,
substitute => \%substitute,
);
my $attachment = {
filename => 'basket.iso2709',
type => 'application/octet-stream',
content => Encode::encode( "UTF-8", $iso2709 ),
};
my $message_id = C4::Letters::EnqueueLetter(
{
letter => $letter,
message_transport_type => 'email',
to_address => $email_add,
reply_address => $user_email,
attachments => [$attachment],
}
);
C4::Letters::SendQueuedMessages( { message_id => $message_id } ) if $message_id;
$template->param( SENT => 1 );
}
$template->param( email_add => $email_add );
output_html_with_http_headers $query, $cookie, $template->output, undef,
{ force_no_caching => 1 };
} elsif( !$user_email ) {
$template->param( email_add => 1, error => 'NO_REPLY_ADDRESS' );
output_html_with_http_headers $query, $cookie, $template->output;
} else {
my $new_session_id = $query->cookie('CGISESSID');
$template->param(
bib_list => $bib_list,
url => "/cgi-bin/koha/opac-sendbasket.pl",
suggestion => C4::Context->preference("suggestion"),
virtualshelves => C4::Context->preference("virtualshelves"),
csrf_token =>
Koha::Token->new->generate_csrf( { session_id => $new_session_id, } ),
);
output_html_with_http_headers $query, $cookie, $template->output, undef,
{ force_no_caching => 1 };
}