Koha/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt
Julian Maurice ed7543287b Bug 20538: Remove the need of writing [% KOHA_VERSION %] everywhere
Having to write [% KOHA_VERSION %] for each url is bad because:
- It's easily forgettable when adding new <script> or <link>
- It prevents grep'ing for the full filename
- It violates the DRY principle
- If at some point we want to change the "force js and css reload"
  mechanism, it will be tedious

This patch:
- adds a Template::Toolkit plugin that generates <script> and
  <link> tags for JS and CSS files, and inserts automatically the Koha
  version in the filename
- use the new plugin to remove all occurences of [% KOHA_VERSION %]
- remove the code that was adding KOHA_VERSION as a template variable

Test plan:
1. Apply patch
2. Go to several different pages in Koha (opac and intranet) while
   checking your browser's dev tools (there should be no 404 for JS and
   CSS files, and the Koha version should appear in filenames) and the
   server logs (there should be no "File not found")
3. `git grep KOHA_VERSION` should return nothing
4. prove t/db_dependent/Koha/Template/Plugin/Asset.t

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-04-13 11:49:44 -03:00

197 lines
10 KiB
Text

[% USE Asset %]
[% SET footerjs = 1 %]
[% INCLUDE 'doc-head-open.inc' %]
<title>Koha &rsaquo; Tools &rsaquo; Patron card creator &rsaquo; Templates &rsaquo; [% IF (template_id) %]Edit ([% template_id %])[% ELSE %]New[% END %]</title>
[% INCLUDE 'doc-head-close.inc' %]
</head>
<body id="pcard_edit-template" class="tools pcard">
[% INCLUDE 'header.inc' %]
[% INCLUDE 'cat-search.inc' %]
<div id="breadcrumbs">
<a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo;
<a href="/cgi-bin/koha/tools/tools-home.pl">Tools</a> &rsaquo;
<a href="/cgi-bin/koha/patroncards/home.pl">Patron card creator</a> &rsaquo;
<a href="/cgi-bin/koha/patroncards/manage.pl?card_element=template">Templates</a> &rsaquo;
[% IF (template_id) %]Edit ([% template_id %])[% ELSE %]New[% END %]
</div>
<div id="doc3" class="yui-t2">
<div id="bd">
<div id="yui-main">
<div class="yui-b">
<div class="yui-g">
[% INCLUDE 'patroncards-toolbar.inc' %]
<div class="yui-u first">
</div>
</div>
<form name="input" action="/cgi-bin/koha/patroncards/edit-template.pl" method="get">
<div class="yui-g">
<h3>[% IF (template_id) %]Edit[% ELSE %]Create[% END %] patron card template[% IF (template_id) %] ([% template_id %])[% END %]</h3>
<div class="yui-u first">
<fieldset class="rows">
<ol>
<li>
<span class="label">Template ID:</span>[% IF ( template_id ) %][% template_id %][% ELSE %]N/A[% END %]
</li>
<li>
<label for="template_code">Template code:</label>
<input type="text" size="30" maxlength="43" name="template_code" id="template_code" value="[% template_code %]" />
</li>
<li>
<label for="template_desc">Template description:</label>
<textarea cols="30" rows="3" id="template_desc" name="template_desc">[% template_desc %]</textarea>
</li>
<li>
<label for="units">Units:</label>
<select id="units" name="units">
[% FOREACH unit IN units %]
[% IF ( unit.selected ) %]
<option value="[% unit.type %]" selected="selected">
[% ELSE %]
<option value="[% unit.type %]">
[% END %]
[% SWITCH unit.type %]
[% CASE 'POINT' %]
<span>PostScript Points</span>
[% CASE 'AGATE' %]
<span>Adobe Agates</span>
[% CASE 'INCH' %]
<span>US Inches</span>
[% CASE 'MM' %]
<span>SI Millimeters</span>
[% CASE 'CM' %]
<span>SI Centimeters</span>
[% END %]
</option>
[% END %]
</select>
</li>
<li>
<label for="page_height">Page height:</label>
<input type="text" size="4" name="page_height" id="page_height" value="[% page_height %]" />
</li>
<li>
<label for="page_width">Page width:</label>
<input type="text" size="4" name="page_width" id="page_width" value="[% page_width %]" />
</li>
<li>
<label for="card_height">Card height:</label>
<input type="text" size="4" name="card_height" id="card_height" value="[% card_height %]" />
</li>
<li>
<label for="card_width">Card width:</label>
<input type="text" size="4" name="card_width" id="card_width" value="[% card_width %]" />
</li>
</ol>
</fieldset>
</div>
<div class="yui-u">
<fieldset class="rows">
<ol><li>
<label for="top_margin">Top page margin:</label>
<input type="text" size="4" name="top_margin" id="top_margin" value="[% top_margin %]" />
</li>
<li>
<label for="left_margin">Left page margin:</label>
<input type="text" size="4" name="left_margin" id="left_margin" value="[% left_margin %]" />
</li>
<li>
<label for="cols">Number of columns:</label>
<input type="text" size="4" name="cols" id="cols" value="[% cols %]" />
</li>
<li>
<label for="rows">Number of rows:</label>
<input type="text" size="4" name="rows" id="rows" value="[% rows %]" />
</li>
<li>
<label for="col_gap">Gap between columns:</label>
<input type="text" size="4" name="col_gap" id="col_gap" value="[% col_gap %]" />
</li>
<li>
<label for="row_gap">Gap between rows:</label>
<input type="text" size="4" name="row_gap" id="row_gap" value="[% row_gap %]" />
</li>
<li>
<label for="profile_id">Profile:</label>
[% IF ( profile_list ) %]
<select id="profile_id" name="profile_id">
[% FOREACH profile_lis IN profile_list %]
[% IF ( profile_lis.selected ) %]
<option value="[% profile_lis.profile_id %]" selected="selected">
[% ELSE %]
<option value="[% profile_lis.profile_id %]">
[% END %]
[% profile_lis.printer_name %]/[% profile_lis.paper_bin %]
</option>
[% END %]
</select>
[% ELSE %]
<a href="/cgi-bin/koha/patroncards/edit-profile.pl?op=new">Click here to define a printer profile.</a>
[% END %]
</li>
</ol>
</fieldset>
</div>
</div>
<div class="yui-g">
<fieldset class="action">
<input type="submit" class="submit" value="Save" />
<a class="cancel" href="/cgi-bin/koha/patroncards/manage.pl?card_element=template">Cancel</a>
<input type="hidden" name="op" value="save" />
[% IF ( template_id ) %]
<input type="hidden" name="template_id" value="[% template_id %]" />
[% END %]
</fieldset>
</div>
</form>
</div>
</div>
<div class="yui-b">
[% INCLUDE 'tools-menu.inc' %]
</div>
</div>
[% MACRO jsinclude BLOCK %]
[% Asset.js("js/tools-menu.js") %]
<script>
$(document).ready(function(){
var selectedUnit = $("#units option:selected").attr("value");
var unitfields = $("#page_height,#page_width,#card_width,#card_height,#top_margin,#left_margin,#col_gap,#row_gap");
$(unitfields).after("<span class=\"unit\">"+getUnit(selectedUnit)+"</span>");
$("#units").change(function(){
$(".unit").html(getUnit($(this).val()));
});
function getUnit(unit){
switch(unit){
case "POINT":
var unit = " pt";
break;
case "AGATE":
var unit = " ag";
break;
case "INCH":
var unit = " in";
break;
case "MM":
var unit = " mm";
break;
case "CM":
var unit = " cm";
break;
default:
var unit = "";
}
return unit;
}
});
</script>
[% END %]
[% INCLUDE 'intranet-bottom.inc' %]