Koha/members
emilyrose eea0310a62 Bug 34870: Perform UTF8 encoding before redirection
Display special characters correctly when writing off an invoice.

The issue arises because pay.pl does not perform UTF-8 encoding on the “notes” parameter before redirecting the page. By using uri_escape_utf8, characters with a code above 255 are also UTF-8 encoded. Then, paycollect.pl can collect the information without any trouble.

This patch work with “;” and “:” characters.

TEST PLAN
1) Go to any patron profile > Accounting
2) Click “Create manual invoice”
3) Fill the fields and click the “Save” button
4) Repeat steps 2 and 3
5) Click “Make a payment”
6) Add a note with special characters for each one (e.g., éçö)
7) Select the created invoices and click the “Write off selected” button
8) In the note field, you should see “�” symbols where the special characters are supposed to be
9) Click the “Cancel” button
10) Now add a note with “:;” for one of the invoices
11) Select the invoices and click the “Write off selected” button
12) You should see a page with an error 500
13) Go back to the “Make a payment” page
14) Apply the patch
15) Add a note with special characters for each one (e.g., éçö)
16) Add “:;” to one of the note fields
17) Select the invoices and click the “Write off selected” button
18) Now the special characters are displayed correctly

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 1c01617634)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2023-10-05 14:35:21 -10:00
..
accountline-details.pl
apikeys.pl
boraccount.pl Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
cancel-charge.pl
default_messageprefs.pl
deletemem.pl
discharge.pl
discharges.pl
files.pl
holdshistory.pl
housebound.pl
ill-requests.pl
mancredit.pl Bug 29987: (follow-up) Fix missing payment type 2022-10-21 10:18:53 -03:00
maninvoice.pl
member-flags.pl
member-password.pl
member.pl Bug 34094: Use DefaultPatronSearchMethod consistently 2023-07-17 16:04:31 +01:00
memberentry.pl Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
members-home.pl
members-update-do.pl Bug 31893: Use checkauth and do not fetch about.tt template 2023-01-20 13:56:30 +00:00
members-update.pl
merge-patrons.pl
mod_debarment.pl
moremember.pl Bug 26598: Display guarantee's fines on guarantor's details page 2023-04-06 10:03:16 -03:00
notices.pl Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. 2022-10-24 14:12:16 -03:00
patronimage.pl
pay.pl Bug 34870: Perform UTF8 encoding before redirection 2023-10-05 14:35:21 -10:00
paycollect.pl
print_overdues.pl
printfeercpt.pl
printinvoice.pl
printnotice.pl Bug 31714: Add Generic way to print patron slips 2022-10-21 10:09:03 -03:00
printslip.pl Bug 33010: Do not filter checkins with logged in patrons branch in printslip.pl 2023-05-18 11:35:11 -03:00
purchase-suggestions.pl
readingrec.pl
recallshistory.pl
routing-lists.pl
search.pl
setstatus.pl
statistics.pl
summary-print.pl
two_factor_auth.pl Bug 30588: (QA follow-up) Adjust flags for two_factor_auth.pl 2022-10-21 11:37:01 -03:00
update-child.pl