331ca7df3e
The sth was created before the query. The query was modified after the sth creation and an error was raised. Test plan: 0/ Don't apply the patch 1/ Create a budget A (amount=1000) 2/ Create a fund A1 (amount=1000) 3/ Create a child fund A11 (amount=1000) 4/ Edit A11 and change the amount to 2000 You are able to do it, an error appears in the Koha log: "check_parent_total.pl: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed" 5/ Apply the patch, edit A11 and save. You get an error 6/ Edit A11 and change the amount to <=1000 7/ Verify that there is no regression on adding/removing/editing budgets and funds. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described, no regressions found. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
113 lines
3.9 KiB
Perl
Executable file
113 lines
3.9 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it under the
|
|
# terms of the GNU General Public License as published by the Free Software
|
|
# Foundation; either version 2 of the License, or (at your option) any later
|
|
# version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
|
|
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License along
|
|
# with Koha; if not, write to the Free Software Foundation, Inc.,
|
|
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
|
|
use strict;
|
|
#use warnings; FIXME - Bug 2505
|
|
use CGI;
|
|
use C4::Context;
|
|
use C4::Output;
|
|
use C4::Auth;
|
|
use C4::Budgets;
|
|
|
|
=head1 DESCRIPTION
|
|
|
|
This script checks the amount unallocated from the new parent budget , or the period - if no parent_id is given
|
|
|
|
This script is called from aqbudgets.pl during an 'add' or 'mod' budget, from the JSscript Check() function,
|
|
to determine whether the new parent budget (or period) has enough unallocated funds for the save to complete.
|
|
|
|
=cut
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
my $input = new CGI;
|
|
|
|
my $total = $input->param('total');
|
|
my $budget_id = $input->param('budget_id');
|
|
my $parent_id = $input->param('parent_id');
|
|
my $period_id = $input->param('period_id');
|
|
my $returncode;
|
|
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{ template_name => "acqui/ajax.tmpl",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
debug => 0,
|
|
}
|
|
);
|
|
my ($period, $parent , $budget);
|
|
$period = GetBudgetPeriod($period_id) if $period_id;
|
|
$parent = GetBudget($parent_id) if defined $parent_id;
|
|
$budget = GetBudget($budget_id) if defined $budget_id;
|
|
|
|
# CHECK THE PARENT BUDGET FOR ENOUGHT AMOUNT UNALLOCATED, IF NOT THEN RETURN 1
|
|
my ($sub_unalloc , $period_sum, $budget_period_unalloc);
|
|
|
|
if ($parent) {
|
|
my $query = " SELECT SUM(budget_amount) as sum FROM aqbudgets where budget_parent_id = ? ";
|
|
my @sql_params;
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute( $parent->{'budget_id'} );
|
|
my $sum = $sth->fetchrow_hashref;
|
|
$sth->finish;
|
|
$sub_unalloc = $parent->{'budget_amount'} - $sum->{sum};
|
|
# TRICKY.. , IF THE PARENT IS THE CURRENT PARENT - THEN SUBSTRACT CURRENT BUDGET FROM TOTAL
|
|
$sub_unalloc += $budget->{'budget_amount'} if ( $budget->{'budget_parent_id'} == $parent_id ) ;
|
|
}
|
|
|
|
# ELSE , IF NO PARENT PASSED, THEN CHECK UNALLOCATED FOR PERIOD, IF NOT THEN RETURN 2
|
|
else {
|
|
my $query = qq| SELECT SUM(budget_amount) as sum
|
|
FROM aqbudgets WHERE budget_period_id = ? and budget_parent_id IS NULL |;
|
|
my @sql_params;
|
|
push @sql_params, $period_id;
|
|
if ($budget_id){
|
|
$query.=qq| and budget_id <> ? |;
|
|
push @sql_params,$budget_id;
|
|
}
|
|
|
|
my $sth = $dbh->prepare($query);
|
|
$sth->execute(@sql_params);
|
|
$period_sum = $sth->fetchrow_hashref;
|
|
$sth->finish;
|
|
$budget_period_unalloc = $period->{'budget_period_total'} - $period_sum->{'sum'} if $period->{'budget_period_total'};
|
|
}
|
|
|
|
# FIXME - we really need a better way to do this consistently
|
|
# and across the board, be it bigints, Math::FixedPoint, a
|
|
# modernized version of Math::Curency that isn't tied to the system
|
|
# locale, or something else.
|
|
$total = sprintf( "%.2f", $total );
|
|
$sub_unalloc = sprintf( "%.2f", $sub_unalloc );
|
|
$budget_period_unalloc = sprintf( "%.2f", $budget_period_unalloc );
|
|
|
|
if ( $parent_id) {
|
|
if ( ($total > $sub_unalloc ) && $sub_unalloc ) {
|
|
$returncode = 1;
|
|
}
|
|
} elsif ( ( $total > $budget_period_unalloc ) && $budget_period_unalloc ) {
|
|
$returncode = 2;
|
|
|
|
} else {
|
|
$returncode = 0;
|
|
}
|
|
|
|
|
|
output_html_with_http_headers $input, $cookie, $returncode;
|
|
1;
|