Tomas Cohen Arazi
cc30dc39bf
This patch makes creating a manual credit from the UI record the account
offset as 'Manual Credit', and properly set account_offsets.credit_id
instead of account_offsets.debit_id.
To test:
- Create a manual credit (of 'Credit' type) for a known patron (acevedo?)
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM account_offsets;
=> FAIL: The account offset for the manual credit has type=Manual Debit,
credit_id=NULL and debit_id=accountlines_id
- Run the atomic update:
$ updatedatabase
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been corrected and now has
type=Manual Credit, credit_id=accountlines_id and debit_id=NULL
- Create a new manual credit (of 'Forgiven' type) for a known patron
- Run:
$ sudo koha-mysql kohadev
> SELECT * FROM account_offsets;
=> SUCCESS: The account offset has been stored correctly as a credit!
- Sign off :-D
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
124 lines
4.2 KiB
Perl
Executable file
124 lines
4.2 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
#written 11/1/2000 by chris@katipo.oc.nz
|
|
#script to display borrowers account details
|
|
|
|
|
|
# Copyright 2000-2002 Katipo Communications
|
|
# Copyright 2010 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use CGI qw ( -utf8 );
|
|
|
|
use C4::Members;
|
|
use C4::Accounts;
|
|
use C4::Items;
|
|
use C4::Members::Attributes qw(GetBorrowerAttributes);
|
|
|
|
use Koha::Account;
|
|
use Koha::Patrons;
|
|
use Koha::Patron::Categories;
|
|
use Koha::Token;
|
|
|
|
my $input=new CGI;
|
|
my $flagsrequired = { borrowers => 'edit_borrowers', updatecharges => 1 };
|
|
|
|
my $borrowernumber=$input->param('borrowernumber');
|
|
|
|
my $patron = Koha::Patrons->find( $borrowernumber );
|
|
unless ( $patron ) {
|
|
print $input->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrowernumber");
|
|
exit;
|
|
}
|
|
my $add=$input->param('add');
|
|
|
|
if ($add){
|
|
|
|
my ( $user_id ) = checkauth( $input, 0, $flagsrequired, 'intranet' );
|
|
|
|
if ( $user_id ) {
|
|
|
|
die "Wrong CSRF token"
|
|
unless Koha::Token->new->check_csrf( {
|
|
session_id => scalar $input->cookie('CGISESSID'),
|
|
token => scalar $input->param('csrf_token'),
|
|
});
|
|
|
|
# Note: If the logged in user is not allowed to see this patron an invoice can be forced
|
|
# Here we are trusting librarians not to hack the system
|
|
my $barcode = $input->param('barcode');
|
|
my $item_id;
|
|
if ($barcode) {
|
|
$item_id = GetItemnumberFromBarcode($barcode);
|
|
}
|
|
my $description = $input->param('desc');
|
|
my $note = $input->param('note');
|
|
my $amount = $input->param('amount') || 0;
|
|
my $type = $input->param('type');
|
|
|
|
Koha::Account->new({ patron_id => $borrowernumber })->add_credit({
|
|
amount => $amount,
|
|
description => $description,
|
|
item_id => $item_id,
|
|
note => $note,
|
|
type => $type,
|
|
user_id => $user_id
|
|
});
|
|
|
|
print $input->redirect("/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber");
|
|
}
|
|
} else {
|
|
my ($template, $loggedinuser, $cookie) = get_template_and_user(
|
|
{
|
|
template_name => "members/mancredit.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { borrowers => 'edit_borrowers',
|
|
updatecharges => 'remaining_permissions' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
my $logged_in_user = Koha::Patrons->find( $loggedinuser ) or die "Not logged in";
|
|
output_and_exit_if_error( $input, $cookie, $template, { module => 'members', logged_in_user => $logged_in_user, current_patron => $patron } );
|
|
if ( $patron->is_child ) {
|
|
my $patron_categories = Koha::Patron::Categories->search_limited({ category_type => 'A' }, {order_by => ['categorycode']});
|
|
$template->param( 'CATCODE_MULTI' => 1) if $patron_categories->count > 1;
|
|
$template->param( 'catcode' => $patron_categories->next->categorycode ) if $patron_categories->count == 1;
|
|
}
|
|
|
|
if (C4::Context->preference('ExtendedPatronAttributes')) {
|
|
my $attributes = GetBorrowerAttributes($borrowernumber);
|
|
$template->param(
|
|
ExtendedPatronAttributes => 1,
|
|
extendedattributes => $attributes
|
|
);
|
|
}
|
|
|
|
$template->param(
|
|
patron => $patron,
|
|
finesview => 1,
|
|
csrf_token => Koha::Token->new->generate_csrf(
|
|
{ session_id => scalar $input->cookie('CGISESSID') }
|
|
),
|
|
);
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
}
|