ef539cd035
This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. Amended to make patch apply and follwoing comments on IRC by putti http://irc.koha-community.org/koha/2015-11-06#i_1752803 (misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84) 6.11.2015 /mv Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
253 lines
9.7 KiB
Perl
Executable file
253 lines
9.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This script loops through each overdue item, determines the fine,
|
|
# and updates the total amount of fines due by each user. It relies on
|
|
# the existence of /tmp/fines, which is created by ???
|
|
# Doesn't really rely on it, it relies on being able to write to /tmp/
|
|
# It creates the fines file
|
|
#
|
|
# This script is meant to be run nightly out of cron.
|
|
|
|
# Copyright 2011-2012 BibLibre
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
use Modern::Perl;
|
|
|
|
BEGIN {
|
|
|
|
# find Koha's Perl modules
|
|
# test carefully before changing this
|
|
use FindBin;
|
|
eval { require "$FindBin::Bin/kohalib.pl" };
|
|
}
|
|
|
|
use Date::Calc qw/Date_to_Days/;
|
|
|
|
use C4::Context;
|
|
use C4::Circulation;
|
|
use C4::Overdues;
|
|
use C4::Calendar qw(); # don't need any exports from Calendar
|
|
use C4::Biblio;
|
|
use C4::Debug; # supplying $debug and $cgi_debug
|
|
use C4::Log;
|
|
use Getopt::Long;
|
|
use List::MoreUtils qw/none/;
|
|
use Koha::DateUtils;
|
|
|
|
my $help = 0;
|
|
my $verbose = 0;
|
|
my @pcategories;
|
|
my @categories;
|
|
my %catamounts;
|
|
my @libraries;
|
|
my $delay;
|
|
my $useborrowerlibrary;
|
|
my $borrowernumberlimit;
|
|
my $borrowersalreadyapplied; # hashref of borrowers for whom we already applied the fine, so it's only applied once
|
|
my $debug = $ENV{'DEBUG'} || 0;
|
|
my $bigdebug = 0;
|
|
|
|
GetOptions(
|
|
'h|help' => \$help,
|
|
'v|verbose' => \$verbose,
|
|
'c|category:s'=> \@pcategories,
|
|
'l|library:s' => \@libraries,
|
|
'd|delay:i' => \$delay,
|
|
'u|use-borrower-library' => \$useborrowerlibrary,
|
|
'b|borrower:i' => \$borrowernumberlimit
|
|
);
|
|
my $usage = << 'ENDUSAGE';
|
|
|
|
This script calculates and charges overdue fines to patron accounts.
|
|
|
|
If the Koha System Preference 'finesMode' is set to 'production', the fines are charged to the patron accounts.
|
|
If set to 'test', the fines are calculated but not applied.
|
|
|
|
Please note that the fines won't be applied on a holiday.
|
|
|
|
This script has the following parameters :
|
|
-h --help: this message
|
|
-v --verbose
|
|
-c --category borrower_category,amount (repeatable)
|
|
-l --library (repeatable)
|
|
-d --delay
|
|
-u --use-borrower-library: use borrower's library, regardless of the CircControl syspref
|
|
-b --borrower borrowernumber: only for one given borrower
|
|
|
|
ENDUSAGE
|
|
die $usage if $help;
|
|
|
|
cronlogaction();
|
|
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
# Processing categories
|
|
foreach (@pcategories) {
|
|
my ($category, $amount) = split(',', $_);
|
|
push @categories, $category;
|
|
$catamounts{$category} = $amount;
|
|
}
|
|
|
|
use vars qw(@borrower_fields @item_fields @other_fields);
|
|
use vars qw($fldir $libname $control $mode $delim $dbname $today_iso $today_days);
|
|
use vars qw($filename);
|
|
|
|
CHECK {
|
|
@borrower_fields = qw(cardnumber categorycode surname firstname email phone address citystate);
|
|
@item_fields = qw(itemnumber barcode date_due);
|
|
@other_fields = qw(type days_overdue fine);
|
|
$libname = C4::Context->preference('LibraryName');
|
|
$control = C4::Context->preference('CircControl');
|
|
$mode = C4::Context->preference('finesMode');
|
|
$dbname = C4::Context->config('database');
|
|
$delim = "\t"; # ? C4::Context->preference('delimiter') || "\t";
|
|
|
|
}
|
|
|
|
INIT {
|
|
$debug and print "Each line will contain the following fields:\n",
|
|
"From borrowers : ", join( ', ', @borrower_fields ), "\n",
|
|
"From items : ", join( ', ', @item_fields ), "\n",
|
|
"Per overdue: ", join( ', ', @other_fields ), "\n",
|
|
"Delimiter: '$delim'\n";
|
|
}
|
|
$debug and (defined $borrowernumberlimit) and print "--borrower limitation: borrower $borrowernumberlimit\n";
|
|
my ($numOverdueItems, $data);
|
|
if (defined $borrowernumberlimit) {
|
|
($numOverdueItems, $data) = checkoverdues($borrowernumberlimit);
|
|
} else {
|
|
$data = Getoverdues();
|
|
$numOverdueItems = scalar @$data;
|
|
}
|
|
my $overdueItemsCounted = 0;
|
|
my %calendars = ();
|
|
$today_iso = output_pref( { dt => dt_from_string, dateonly => 1, dateformat => 'iso' } );
|
|
my ($tyear, $tmonth, $tday) = split( /-/, $today_iso );
|
|
$today_days = Date_to_Days( $tyear, $tmonth, $tday );
|
|
|
|
for ( my $i = 0 ; $i < scalar(@$data) ; $i++ ) {
|
|
next if $data->[$i]->{'itemlost'};
|
|
my $datedue;
|
|
my $datedue_days;
|
|
eval {
|
|
$datedue = eval { output_pref( { dt => dt_from_string( $data->[$i]->{'date_due'} ), dateonly => 1, dateformat => 'iso' } ); };
|
|
$datedue_days = Date_to_Days( split( /-/, $datedue ) );
|
|
};
|
|
if ($@) {
|
|
warn "Error on date for borrower " . $data->[$i]->{'borrowernumber'} . ": $@date_due: " . $data->[$i]->{'date_due'} . "\ndatedue_days: " . $datedue_days . "\nSkipping";
|
|
next;
|
|
}
|
|
my $due_str = eval { output_pref( { dt => dt_from_string( $datedue ), dateonly => 1 } ); };
|
|
unless ( defined $data->[$i]->{'borrowernumber'} ) {
|
|
print STDERR "ERROR in Getoverdues line $i: issues.borrowernumber IS NULL. Repair 'issues' table now! Skipping record.\n";
|
|
next; # Note: this doesn't solve everything. After NULL borrowernumber, multiple issues w/ real borrowernumbers can pile up.
|
|
}
|
|
my $borrower = BorType( $data->[$i]->{'borrowernumber'} );
|
|
|
|
# Skipping borrowers that are not in @categories
|
|
$bigdebug and warn "Skipping borrower from category " . $borrower->{categorycode} if none { $borrower->{categorycode} eq $_ } @categories;
|
|
next if none { $borrower->{categorycode} eq $_ } @categories;
|
|
|
|
my $branchcode =
|
|
( $useborrowerlibrary ) ? $borrower->{branchcode}
|
|
: ( $control eq 'ItemHomeLibrary' ) ? $data->[$i]->{homebranch}
|
|
: ( $control eq 'PatronLibrary' ) ? $borrower->{branchcode}
|
|
: $data->[$i]->{branchcode};
|
|
# In final case, CircControl must be PickupLibrary. (branchcode comes from issues table here).
|
|
|
|
# Skipping branchcodes that are not in @libraries
|
|
$bigdebug and warn "Skipping library $branchcode" if none { $branchcode eq $_ } @libraries;
|
|
next if none { $branchcode eq $_ } @libraries;
|
|
|
|
my $calendar;
|
|
unless ( defined( $calendars{$branchcode} ) ) {
|
|
$calendars{$branchcode} = C4::Calendar->new( branchcode => $branchcode );
|
|
}
|
|
$calendar = $calendars{$branchcode};
|
|
my $isHoliday = $calendar->isHoliday( $tday, $tmonth, $tyear );
|
|
|
|
# Reassing datedue_days if -delay specified in commandline
|
|
$bigdebug and warn "Using commandline supplied delay : $delay" if ($delay);
|
|
$datedue_days += $delay if ($delay);
|
|
|
|
( $datedue_days <= $today_days ) or next; # or it's not overdue, right?
|
|
|
|
$overdueItemsCounted++;
|
|
my ( $amount, $type, $unitcounttotal, $unitcount ) = CalcFine(
|
|
$data->[$i],
|
|
$borrower->{'categorycode'},
|
|
$branchcode,
|
|
dt_from_string( $datedue ),
|
|
dt_from_string( $today_iso ),
|
|
);
|
|
|
|
# Reassign fine's amount if specified in command-line
|
|
$amount = $catamounts{$borrower->{'categorycode'}} if (defined $catamounts{$borrower->{'categorycode'}});
|
|
|
|
# We check if there is already a fine for the given borrower
|
|
my $fine = GetFine(undef, $data->[$i]->{'borrowernumber'});
|
|
if ($fine > 0) {
|
|
$debug and warn "There is already a fine for borrower " . $data->[$i]->{'borrowernumber'} . ". Nothing to do here. Skipping this borrower";
|
|
next;
|
|
}
|
|
|
|
# FIXME: $type NEVER gets populated by anything.
|
|
( defined $type ) or $type = '';
|
|
|
|
# Don't update the fine if today is a holiday.
|
|
# This ensures that dropbox mode will remove the correct amount of fine.
|
|
if ( $mode eq 'production' and !$borrowersalreadyapplied->{$data->[$i]->{'borrowernumber'}}) {
|
|
# If we're on a holiday, warn the user (if debug) that no fine will be applied
|
|
if($isHoliday) {
|
|
$debug and warn "Today is a holiday. The fine for borrower " . $data->[$i]->{'borrowernumber'} . " will not be applied";
|
|
} else {
|
|
$debug and warn "Creating fine for borrower " . $data->[$i]->{'borrowernumber'} . " with amount : $amount";
|
|
|
|
# We mark this borrower as already processed
|
|
$borrowersalreadyapplied->{$data->[$i]->{'borrowernumber'}} = 1;
|
|
|
|
my $borrowernumber = $data->[$i]->{'borrowernumber'};
|
|
my $itemnumber = $data->[$i]->{'itemnumber'};
|
|
|
|
# And we create the fine
|
|
my $sth4 = $dbh->prepare( "SELECT title FROM biblio LEFT JOIN items ON biblio.biblionumber=items.biblionumber WHERE items.itemnumber=?" );
|
|
$sth4->execute($itemnumber);
|
|
my $title = $sth4->fetchrow;
|
|
|
|
my $nextaccntno = C4::Accounts::getnextacctno($borrowernumber);
|
|
my $desc = "staticfine";
|
|
my $query = "INSERT INTO accountlines
|
|
(borrowernumber,itemnumber,date,amount,description,accounttype,amountoutstanding,lastincrement,accountno)
|
|
VALUES (?,?,now(),?,?,'F',?,?,?)";
|
|
my $sth2 = $dbh->prepare($query);
|
|
$bigdebug and warn "query: $query\nw/ args: $borrowernumber, $itemnumber, $amount, $desc, $amount, $amount, $nextaccntno\n";
|
|
$sth2->execute( $borrowernumber, $itemnumber, $amount, $desc, $amount, $amount, $nextaccntno );
|
|
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($verbose) {
|
|
print <<EOM;
|
|
Fines assessment -- $today_iso
|
|
Number of Overdue Items:
|
|
counted $overdueItemsCounted
|
|
reported $numOverdueItems
|
|
|
|
EOM
|
|
}
|
|
|