Main Koha release repository https://koha-community.org
Find a file
Paul Derscheid ef803755f5
Bug 32418: Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl
Check whether the current op is edititem or dupeitem and if so check
whether the itemnumber supplied as a query param actually exists.

If it doesn't, redirect to the additem op and hide all UI elements except
for a dialog that gives options to add a new item to the record or to
view the records holdings.

This behaviour was adapted from the addbiblio view, as suggested by
Fridolin.

To test:
1. Go to any record
2. Hit the edit button on an item in the holdings table
3. Modify the URL so that the query param for the itemnumber is either
    3.1 empty: /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=
    3.2 an itemnumber that doesn't exist:
      /cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=384&itemnumber=9999999999
    3.3 whatever else you come up with..
4. Check the same thing for the dupe option (op=dupeitem)
5. Sign off

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2023-04-14 11:35:20 -03:00
acqui Bug 32437: Honor overlay setting in staged batch when adding to a basket 2023-03-31 13:13:27 +02:00
admin Bug 32447: Clean up table configuraton settings for holdings table 2023-03-31 19:19:26 +02:00
api Bug 33066: Use KohaTable for LicensesList 2023-04-10 07:38:43 -03:00
authorities Bug 30930: (QA follow-up) Tidy code block 2023-04-06 10:03:19 -03:00
basket Bug 33160: Use hostinfo to display title information when 773$w is empty 2023-04-06 09:47:23 -03:00
bin
C4 Bug 32013: Autorenewal batch indexing 2023-04-12 09:26:56 -03:00
catalogue Bug 33070: Remove use of can_edit_items 2023-03-17 09:59:02 -03:00
cataloguing Bug 32418: Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl 2023-04-14 11:35:20 -03:00
circ Bug 31615: Allow checkin of items bundles without verifying their contents 2023-04-06 10:45:03 -03:00
clubs
course_reserves
debian Bug 33168: (follow-up) Swap spaces for tabs 2023-04-04 11:26:20 +02:00
docs
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors
etc Bug 32716: larger proxy_buffer_size in NGINX example config 2023-04-14 11:35:18 -03:00
ill
installer Bug 33368: DBRev 22.12.00.019 2023-04-06 12:53:25 -03:00
Koha Bug 33481: Pass content-type when requesting EBSCO's webservice 2023-04-14 11:35:17 -03:00
koha-tmpl Bug 32418: Can't call method 'unblessed' on an undefined value at cataloguing/additem.pl 2023-04-14 11:35:20 -03:00
labels
lib/CGI/Session/Serialize
members Bug 26598: Display guarantee's fines on guarantor's details page 2023-04-06 10:03:16 -03:00
misc Bug 32334: Fix spelling 2023-04-12 11:22:04 -03:00
offline_circ
opac Bug 29311: (QA follow-up) Fix an existing spelling typo 2023-04-06 10:03:14 -03:00
patron_lists
patroncards
plugins
pos
recalls
reports Bug 27513: Add notes to variables for report parameters template 2023-04-06 09:47:25 -03:00
reserve Bug 33198: Don't calculate pickup locations per bib unless placing multiple holds 2023-03-27 11:50:18 +02:00
reviews
rotating_collections
serials
services
skel
suggestion
svc Bug 33408: Fetch sysprefs from svc/config/systempreferences 2023-04-13 11:47:58 -03:00
t Bug 33408: Remove obsolete tests and template sys pref code 2023-04-13 11:48:02 -03:00
tags
tools Bug 33341: Address some perlcritic errors in 5.36 2023-03-28 14:50:33 +02:00
virtualshelves Bug 3150: (QA follow-up) Tidy scripts 2023-03-27 12:49:47 +02:00
xt Bug 33227: Unit tests 2023-03-20 09:39:49 -03:00
.editorconfig
.eslintrc.json
.gitignore Bug 32609: Add compiled css files to gitignore 2023-02-10 11:07:52 -03:00
.htaccess
.mailmap
.perlcriticrc
.proverc.dist
.stylelintrc.json
about.pl Bug 30403: (QA follow-up) Add new YAML syspref to about.pl 2023-04-06 11:28:19 -03:00
app.psgi
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
cpanfile Bug 32558: (QA follow-up) Move ForkManager to required 2023-03-07 11:03:32 -03:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-04-13 11:48:00 -03:00
fix-perl-path.PL
gulpfile.js Bug 32978: Replace node-sass with dart-sass 2023-02-22 10:03:39 -03:00
help.pl
INSTALL
Koha.pm Bug 33368: DBRev 22.12.00.019 2023-04-06 12:53:25 -03:00
koha_perl_deps.pl
kohaversion.pl
LICENSE
mainpage.pl Bug 33133: Add fast cataloging to 'Cataloging' page 2023-03-27 12:50:07 +02:00
Makefile.PL Bug 32806: (follow-up) Rename main.js to erm.js 2023-02-27 11:12:01 -03:00
MANIFEST.SKIP
package.json Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00
README
README.md
README.robots
rewrite-config.PL
tsconfig.json
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-27 11:12:01 -03:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo