Marcel de Rooy b711984885 Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee ... The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>		2015-08-26 10:26:54 -03:00
..
errors	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
rss
sco	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
svc	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
ilsdi.pl	Revert "Bug 6679: Fixing code so it passes basic Perl:::Critic tests"	2015-05-26 14:16:31 -03:00
maintenance.pl	Bug 13758: Move the Koha version from kohaversion.pl	2015-05-07 11:39:04 -03:00
oai.pl	Bug 3206: (QA followup) OAI repository deleted records support.	2015-07-08 14:55:17 -03:00
opac-account.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-addbybiblionumber.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-alert-subscribe.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-authorities-home.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-authoritiesdetail.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-basket.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-blocked.pl	Bug 11944: use CGI( -utf8 ) everywhere	2015-01-13 13:07:21 -03:00
opac-browser.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-changelanguage.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-course-details.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-course-reserves.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-detail.pl	Bug 14496: Improving opac-detail.pl performances	2015-07-10 10:53:48 -03:00
opac-discharge.pl	Bug 14280: Add branches fields to discharges letters	2015-06-11 13:12:32 -03:00
opac-downloadcart.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-downloadshelf.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-export.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-ics.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-idref.pl	Bug 8992: Interfacing with the Idref webservice	2015-04-28 15:46:26 -03:00
opac-image.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-imageviewer.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-ISBDdetail.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-main.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-MARCdetail.pl	Bug 10938: Item columns displayed in random order - OPAC	2015-06-05 14:13:39 -03:00
opac-memberentry.pl	Bug 14675: Don't update details if no changes made	2015-08-20 13:42:04 -03:00
opac-messaging.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-modrequest-suspend.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-modrequest.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-mymessages.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-news-rss.pl	Bug 7843: (QA followup) Make news selection persistant	2015-04-30 16:33:21 -03:00
opac-overdrive-search.pl	Bug 11944: use CGI( -utf8 ) everywhere	2015-01-13 13:07:21 -03:00
opac-passwd.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-patron-image.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-privacy.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-ratings-ajax.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-ratings.pl	Bug 14440: get_template_and_user can not have an empty template_name (opac-ratings.pl)	2015-06-25 14:41:21 -03:00
opac-readingrecord.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-registration-verify.pl	Bug 11693: Default emailing preferences not loaded for self registering patron	2015-07-24 13:44:39 -03:00
opac-renew.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
opac-reserve.pl	Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee	2015-08-26 10:26:54 -03:00
opac-restrictedpage.pl	Bug 13485: Use the Koha template plugin to access syspref values	2015-08-11 15:15:36 -03:00
opac-retrieve-file.pl	Bug 6874: [QA Follow-up] Adjustments for opac-retrieve	2015-08-07 15:23:36 -03:00
opac-review.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-search-history.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-search.pl	Bug 14371: Facets should be sorted by label (displayed) not title (link value)	2015-06-22 11:49:01 -03:00
opac-sendbasket.pl	Bug 14330: Remove unused email_sender from sendbasket/sendshelf	2015-06-08 10:38:08 -03:00
opac-sendshelf.pl	Bug 14330: Remove unused email_sender from sendbasket/sendshelf	2015-06-08 10:38:08 -03:00
opac-serial-issues.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-shareshelf.pl	Bug 5010: Fix OPACBaseURL to include protocol	2015-06-04 10:00:04 -03:00
opac-shelves.pl	Bug 13986: Implement fix for OPAC	2015-05-15 16:01:47 -03:00
opac-showmarc.pl	Bug 11944: use CGI( -utf8 ) everywhere	2015-01-13 13:07:21 -03:00
opac-showreviews.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-suggestions.pl	Bug 4137: Fix the OPACViewOthersSuggestions behavior	2015-06-19 11:34:27 -03:00
opac-tags.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-tags_subject.pl	Bug 14412: SQL injection possible	2015-06-22 11:00:10 -03:00
opac-topissues.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
opac-user.pl	Bug 7976: Remove the borrow permission	2015-06-05 13:43:34 -03:00
tracklinks.pl	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
unapi	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00