Jonathan Druart
9af6c4e34b
This is a recurrent bug we have over the last years. When a script is called with non-existent borrowernumber it will crashes. We need to handle this gracefully instead of letting the script crashes. On bug 18403 a new subroutine is added to the codebase (output_and_exit_if_error) to handle this kind of errors correctly. Since it is not pushed yet, I propose to just redirect to a script that handle it correctly (circulation.pl) instead of adding this message to all these scripts. Test plan: Hit different scripts from the members module and pass a non-existent borrowernumber. You must be redirected to circulation.pl with a friendly message. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
229 lines
7.4 KiB
Perl
Executable file
229 lines
7.4 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# script to edit a member's flags
|
|
# Written by Steve Tonnesen
|
|
# July 26, 2002 (my birthday!)
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Output;
|
|
use C4::Auth qw(:DEFAULT :EditPermissions);
|
|
use C4::Context;
|
|
use C4::Members;
|
|
use C4::Members::Attributes qw(GetBorrowerAttributes);
|
|
#use C4::Acquisitions;
|
|
|
|
use Koha::Patron::Categories;
|
|
use Koha::Patrons;
|
|
|
|
use C4::Output;
|
|
use Koha::Patron::Images;
|
|
use Koha::Token;
|
|
|
|
my $input = new CGI;
|
|
|
|
my $flagsrequired = { permissions => 1 };
|
|
my $member=$input->param('member');
|
|
my $patron = Koha::Patrons->find( $member );
|
|
unless ( $patron ) {
|
|
print $input->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$member");
|
|
exit;
|
|
}
|
|
|
|
my $category_type = $patron->category->category_type;
|
|
my $bor = $patron->unblessed;
|
|
if( $category_type eq 'S' ) {
|
|
$flagsrequired->{'staffaccess'} = 1;
|
|
}
|
|
my ($template, $loggedinuser, $cookie) = get_template_and_user({
|
|
template_name => "members/member-flags.tt",
|
|
query => $input,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => $flagsrequired,
|
|
debug => 1,
|
|
});
|
|
|
|
|
|
my %member2;
|
|
$member2{'borrowernumber'}=$member;
|
|
|
|
if ($input->param('newflags')) {
|
|
|
|
die "Wrong CSRF token"
|
|
unless Koha::Token->new->check_csrf({
|
|
session_id => scalar $input->cookie('CGISESSID'),
|
|
token => scalar $input->param('csrf_token'),
|
|
});
|
|
|
|
|
|
my $dbh=C4::Context->dbh();
|
|
|
|
my @perms = $input->multi_param('flag');
|
|
my %all_module_perms = ();
|
|
my %sub_perms = ();
|
|
foreach my $perm (@perms) {
|
|
if ($perm !~ /:/) {
|
|
$all_module_perms{$perm} = 1;
|
|
} else {
|
|
my ($module, $sub_perm) = split /:/, $perm, 2;
|
|
push @{ $sub_perms{$module} }, $sub_perm;
|
|
}
|
|
}
|
|
|
|
# construct flags
|
|
my $module_flags = 0;
|
|
my $sth=$dbh->prepare("SELECT bit,flag FROM userflags ORDER BY bit");
|
|
$sth->execute();
|
|
while (my ($bit, $flag) = $sth->fetchrow_array) {
|
|
if (exists $all_module_perms{$flag}) {
|
|
$module_flags += 2**$bit;
|
|
}
|
|
}
|
|
|
|
$sth = $dbh->prepare("UPDATE borrowers SET flags=? WHERE borrowernumber=?");
|
|
$sth->execute($module_flags, $member);
|
|
|
|
# deal with subpermissions
|
|
$sth = $dbh->prepare("DELETE FROM user_permissions WHERE borrowernumber = ?");
|
|
$sth->execute($member);
|
|
$sth = $dbh->prepare("INSERT INTO user_permissions (borrowernumber, module_bit, code)
|
|
SELECT ?, bit, ?
|
|
FROM userflags
|
|
WHERE flag = ?");
|
|
foreach my $module (keys %sub_perms) {
|
|
next if exists $all_module_perms{$module};
|
|
foreach my $sub_perm (@{ $sub_perms{$module} }) {
|
|
$sth->execute($member, $sub_perm, $module);
|
|
}
|
|
}
|
|
|
|
print $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$member");
|
|
} else {
|
|
|
|
my $flags = C4::Members::patronflags( $bor );
|
|
my $accessflags;
|
|
my $dbh = C4::Context->dbh();
|
|
# FIXME This needs to be improved to avoid doing the same query
|
|
my $sth = $dbh->prepare("select bit,flag from userflags");
|
|
$sth->execute;
|
|
while ( my ( $bit, $flag ) = $sth->fetchrow ) {
|
|
if ( $bor->{flags} && $bor->{flags} & 2**$bit ) {
|
|
$accessflags->{$flag} = 1;
|
|
}
|
|
}
|
|
|
|
my $all_perms = get_all_subpermissions();
|
|
my $user_perms = get_user_subpermissions($bor->{'userid'});
|
|
$sth = $dbh->prepare("SELECT bit, flag FROM userflags ORDER BY bit");
|
|
$sth->execute;
|
|
my @loop;
|
|
|
|
while (my ($bit, $flag) = $sth->fetchrow) {
|
|
my $checked='';
|
|
if ($accessflags->{$flag}) {
|
|
$checked= 1;
|
|
}
|
|
|
|
my %row = ( bit => $bit,
|
|
flag => $flag,
|
|
checked => $checked,
|
|
);
|
|
|
|
my @sub_perm_loop = ();
|
|
my $expand_parent = 0;
|
|
if ($checked) {
|
|
if (exists $all_perms->{$flag}) {
|
|
$expand_parent = 1;
|
|
foreach my $sub_perm (sort keys %{ $all_perms->{$flag} }) {
|
|
push @sub_perm_loop, {
|
|
id => "${flag}_$sub_perm",
|
|
perm => "$flag:$sub_perm",
|
|
code => $sub_perm,
|
|
checked => 1
|
|
};
|
|
}
|
|
}
|
|
} else {
|
|
if (exists $user_perms->{$flag}) {
|
|
$expand_parent = 1;
|
|
# put selected ones first
|
|
foreach my $sub_perm (sort keys %{ $user_perms->{$flag} }) {
|
|
push @sub_perm_loop, {
|
|
id => "${flag}_$sub_perm",
|
|
perm => "$flag:$sub_perm",
|
|
code => $sub_perm,
|
|
checked => 1
|
|
};
|
|
}
|
|
}
|
|
# then ones not selected
|
|
if (exists $all_perms->{$flag}) {
|
|
foreach my $sub_perm (sort keys %{ $all_perms->{$flag} }) {
|
|
push @sub_perm_loop, {
|
|
id => "${flag}_$sub_perm",
|
|
perm => "$flag:$sub_perm",
|
|
code => $sub_perm,
|
|
checked => 0
|
|
} unless exists $user_perms->{$flag} and exists $user_perms->{$flag}->{$sub_perm};
|
|
}
|
|
}
|
|
}
|
|
$row{expand} = $expand_parent;
|
|
if ($#sub_perm_loop > -1) {
|
|
$row{sub_perm_loop} = \@sub_perm_loop;
|
|
}
|
|
push @loop, \%row;
|
|
}
|
|
|
|
if ( $category_type eq 'C') {
|
|
my $patron_categories = Koha::Patron::Categories->search_limited({ category_type => 'A' }, {order_by => ['categorycode']});
|
|
$template->param( 'CATCODE_MULTI' => 1) if $patron_categories->count > 1;
|
|
$template->param( 'catcode' => $patron_categories->next ) if $patron_categories->count == 1;
|
|
}
|
|
|
|
$template->param( adultborrower => 1 ) if ( $category_type =~ /^(A|I)$/ );
|
|
$template->param( picture => 1 ) if $patron->image;
|
|
|
|
if (C4::Context->preference('ExtendedPatronAttributes')) {
|
|
my $attributes = GetBorrowerAttributes($bor->{'borrowernumber'});
|
|
$template->param(
|
|
ExtendedPatronAttributes => 1,
|
|
extendedattributes => $attributes
|
|
);
|
|
}
|
|
|
|
$template->param(
|
|
borrowernumber => $bor->{'borrowernumber'},
|
|
cardnumber => $bor->{'cardnumber'},
|
|
surname => $bor->{'surname'},
|
|
firstname => $bor->{'firstname'},
|
|
othernames => $bor->{'othernames'},
|
|
categorycode => $bor->{'categorycode'},
|
|
category_type => $category_type,
|
|
categoryname => $bor->{'description'},
|
|
address => $bor->{address},
|
|
address2 => $bor->{'address2'},
|
|
streettype => $bor->{streettype},
|
|
city => $bor->{'city'},
|
|
state => $bor->{'state'},
|
|
zipcode => $bor->{'zipcode'},
|
|
country => $bor->{'country'},
|
|
phone => $bor->{'phone'},
|
|
phonepro => $bor->{'phonepro'},
|
|
mobile => $bor->{'mobile'},
|
|
email => $bor->{'email'},
|
|
emailpro => $bor->{'emailpro'},
|
|
branchcode => $bor->{'branchcode'},
|
|
loop => \@loop,
|
|
is_child => ( $category_type eq 'C' ),
|
|
RoutingSerials => C4::Context->preference('RoutingSerials'),
|
|
csrf_token =>
|
|
Koha::Token->new->generate_csrf( { session_id => scalar $input->cookie('CGISESSID'), } ),
|
|
);
|
|
|
|
output_html_with_http_headers $input, $cookie, $template->output;
|
|
|
|
}
|