Kyle M Hall fd4dbba7fb Bug 25903: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server ... The 'summary' field in the patron information request specifies if detail information should be send for holds, overdues, fines, etc. The field is 10 characters in length (0-9). However, the SIP2 spec only defines indexes 0 though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these undefined indexes. Apparently the 7th field is often used to request 'Fees', as opposed to 'Fines' in some ILS. Some software that integrate via SIP try both the 5th and 7th indexes to ensure they get all fines and fees. The problem is that Koha's SIP server crashes if any 'summary' index beyond 5 is flagged. We should simply ignore flags beyond 5 and act as if no flags were sent. Test Plan: 1) Enable SIP for your instance 2) Send a patron information request with a summary flag in any index beyond 5. i.e.: 6300120200617 124846 Y AOMIDAY|AA21030050054321 3) Note the SIP server just closes the connection without a response 4) Apply this patch 5) Restart the SIP server 6) Send the same request 7) Note you get back the patron information response! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jeff Gaines <jgaine@arlingtonva.us> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>		2020-08-24 10:46:13 +02:00
..
AuthoritiesMarc
Barcodes	Bug 21395: Fix C4/Barcodes/ValueBuilder.pm	2020-06-29 15:43:41 +02:00
ClassSortRoutine
ClassSplitRoutine	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Creators	Bug 25852: Improve C4::Creators::Lib reliability under plack	2020-07-31 10:03:26 +02:00
External
Form
Heading	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-02-19 13:33:32 +00:00
ILSDI	Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve	2020-05-05 11:03:33 +01:00
Installer	Bug 24545: Fix license statements	2020-02-24 13:31:26 +00:00
Labels	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Linker	Bug 25189: Don't create authority if results found	2020-06-24 14:31:37 +02:00
Members	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
OAI	Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}	2020-02-17 10:44:45 +00:00
Output
Patroncards	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Reports	Bug 22001: execute reports in an eval	2020-03-31 17:48:14 +01:00
Search
Serials
SIP	Bug 25903: Sending a SIP patron information request with a summary field flag in indexes 6-9 will crash server	2020-08-24 10:46:13 +02:00
Utils	Bug 15400: Display date of birth and age more consistantly	2020-06-29 12:37:02 +02:00
Accounts.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Acquisition.pm	Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded	2020-07-09 11:50:42 +02:00
Auth.pm	Bug 24201: (QA follow-up) Correct call to set_userenv	2020-08-07 16:54:40 +02:00
Auth_cas_servers.yaml.sample
Auth_with_cas.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Auth_with_ldap.pm	Bug 20443: Use search_with_library_limits for attribute types	2020-03-23 13:49:22 +00:00
Auth_with_shibboleth.pm
AuthoritiesMarc.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
BackgroundJob.pm
Barcodes.pm
Biblio.pm	Bug 26133: Remove GetMarcHosts	2020-08-05 17:36:28 +02:00
Boolean.pm
Breeding.pm	Bug 23542: Fix SRU import encoding	2020-08-12 11:46:25 +02:00
Budgets.pm
Calendar.pm	Bug 25723: (QA follow-up) Handle holiday and exception on same day	2020-07-20 17:45:31 +02:00
Charset.pm
Circulation.pm	Bug 18501: set the is_refunded flag as internal var	2020-08-20 12:31:59 +02:00
ClassSortRoutine.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
ClassSource.pm
ClassSplitRoutine.pm
Context.pm	Bug 24201: Attach desk to intranet session	2020-08-07 16:54:40 +02:00
Contract.pm
CourseReserves.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Creators.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Debug.pm
Heading.pm	Bug 24269: Adjust C4::Heading to generate headings from auth tags	2020-02-19 13:33:32 +00:00
HoldsQueue.pm	Bug 25799: Add edition information to "Holds queue" report	2020-07-20 17:45:31 +02:00
HTML5Media.pm	Bug 20783: Use iframe to embed Youtube videos	2020-06-15 10:32:43 +02:00
Images.pm
ImportBatch.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
ImportExportFramework.pm
InstallAuth.pm	Bug 21395: (QA follow-up) POD fixes	2020-06-29 12:37:02 +02:00
Installer.pm	Bug 24883: Add POD entry and remove unused variable	2020-03-27 12:11:32 +00:00
ItemCirculationAlertPreference.pm
Items.pm	Bug 24134: Add placeholder for 2 digit years to allow autogeneration of dates in 008	2020-08-13 07:55:44 +02:00
Koha.pm	Bug 16371: Move GetDailyQuote to get_daily_quote	2020-08-13 10:15:33 +02:00
Labels.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Languages.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Letters.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Linker.pm
Log.pm	Bug 23632: Remove C4::Logs::GetLogs	2020-08-18 15:45:48 +02:00
MarcModificationTemplates.pm	Bug 24840: Replace DateTime->now with dt_from_string	2020-04-08 11:54:23 +01:00
Matcher.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Members.pm	Bug 20443: Remove SearchIdMatchingAttribute	2020-03-23 13:49:21 +00:00
Message.pm
NewsChannels.pm
Output.pm	Bug 11994: OpenSearch plugins needs to be delivered with Content-Type application/opensearchdescription+xml	2020-06-24 14:31:37 +02:00
Overdues.pm	Bug 25127: Use Koha::Number::Price->round for comparison	2020-05-01 15:44:55 +01:00
Patroncards.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Record.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Reports.pm
Reserves.pm	Bug 24683: IsAvailableForItemLevelRequest sub description expanded	2020-08-24 10:12:46 +02:00
Ris.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
RotatingCollections.pm	Bug 23695: Set holding branch to transferring branch when manually initiating a transfer	2020-08-18 15:45:48 +02:00
Scheduler.pm
Scrubber.pm
Search.pm	Bug 23086: Search for collection is broken	2020-07-27 17:24:26 +02:00
Serials.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
Service.pm
ShelfBrowser.pm
SMS.pm
SocialData.pm
Stats.pm	Bug 24151: Copy info to the pseudonymized table when a transaction is done	2020-07-20 15:17:42 +02:00
Suggestions.pm	Bug 22784: Add the ability to archive/unarchive a purchase suggestions	2020-04-14 16:19:02 +01:00
Tags.pm	Bug 23084: Replace grep {^$var$} with grep {$_ eq $var}	2020-02-17 10:44:45 +00:00
Templates.pm	Bug 21395: Make perlcritic happy	2020-06-29 12:37:02 +02:00
TmplToken.pm
TmplTokenType.pm
TTParser.pm	Bug 25305: Translation process - Open all files specifying the utf8 encoding	2020-05-04 08:50:07 +01:00
UsageStats.pm	Bug 24159: Move useDaysMode pref to circulation rules	2020-06-25 10:51:59 +02:00
XISBN.pm	Bug 26270: Fix ThingISBN after a change in behaviour	2020-08-24 10:12:47 +02:00
XSLT.pm	Bug 24052: Rename XSLT_Handler	2020-03-24 10:42:23 +00:00