Koha/svc
Jonathan Druart 6f599652b1 Bug 13215: The same letter code can be used for several libraries
This patch fixes a major issue introduced by the
commit 5c4fdcf Bug 11742: A letter code should be unique.

The interface should let the possibility to create a default template
letter and some specific ones, with the same letter code (letter.code).

The patches submitted on bug 11742 tried to fix an issue based on a
(very bad) assumption: letter.code should be considered as a primary key and
should be uniq.

This patch reintroduces this behavior.
Note that the interface will block a letter code used in different
module (this is consistent not to have the same letter code used for different
needs).

This patch is absolutely not perfect, it just tries to change as less
change as possible and to use new tested subroutines.

Test plan:
1/ Verify that the problem raised on bug 11742 does not appears anymore.
2/ Verify there are no regression on adding, editing, copying, deleting
letters.
3/ Verify you are allowed to create a default letter template with a letter
code and to reuse for a specific letter (i.e. for a given library).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-11-27 11:42:14 -03:00
..
config Bug 9043: The comma (,) should be kept to separate multi-valuated prefs 2014-11-17 14:49:59 -03:00
members Bug 13232: Search patrons by a first letter should not redirect to a patron detail page 2014-11-14 09:33:00 -03:00
authentication
bib Bug 12590 - Support deletion of biblio in svc API 2014-10-27 11:13:49 -03:00
bib_profile
checkin Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! 2014-11-25 15:25:14 -03:00
checkouts Bug 13195 - Regression: Circulation checkouts table no longer shows item type description 2014-11-16 21:35:09 -03:00
cover_images Bug 7813: (follow-up) improvements for deleting local cover images 2013-09-21 18:11:13 +00:00
holds Bug 13099 - "Item hasn't been transferred yet" shows pickup branch rather than holding branch 2014-11-20 18:10:19 -03:00
import_bib
letters Bug 13215: The same letter code can be used for several libraries 2014-11-27 11:42:14 -03:00
new_bib
renew Bug 11703: (qa followup) consistency in svc 2014-07-03 12:38:13 -03:00
report Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00