Nick Clemens
859e84417e
Currently the bookings tab on a biblio details and patron details use 'filter_by_future'
which lists upcoming bookings.
Libraries would like to see upcoming, and active bookings in these cases, and we should add a filter
for bookings that have not ended.
NOTE: This removes the only uses of filter_by_future, but I preserve this for Martin's decision as the creator
of the bookings module
To test:
1 - Make an item bookable from the items tab on a record details
2 - Return to details view and place a booking
3 - Note sidebar says "Bookings (1)"
4 - Make the booking current from the DB:
UPDATE bookings SET start_date=NOW() WHERE biblio_id={biblionumber};
5 - Reload the page
6 - Note the count is now "Bookings (0)"
7 - View the patron's details page - note "Bookings (0)" and none listed
8 - Apply patch
9 - Reload biblio details, note Bookings(1)
10 - Reload patron details, note Bookings(1) and booking is listed
11 - End the booking:
UPDATE bookings SET end_date=NOW() WHERE biblio_id={biblionumber};
12 - Confirm booking no longer listed on biblio or patron details
Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
137 lines
4.7 KiB
PHP
137 lines
4.7 KiB
PHP
[% USE Koha %]
|
|
[% USE Biblio %]
|
|
[% SET biblio_object_id = biblio.biblionumber %]
|
|
|
|
<div id="menu">
|
|
<ul>
|
|
[%- IF ( detailview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio_object_id | url %]">Normal</a>
|
|
</li>
|
|
|
|
[%- IF Koha.Preference('viewMARC') -%]
|
|
[%- IF ( marcview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=[% biblio_object_id | url %]">MARC</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF Koha.Preference('viewLabeledMARC') -%]
|
|
[%- IF ( labeledmarcview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/labeledMARCdetail.pl?biblionumber=[% biblio_object_id | url %]">Labeled MARC</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF Koha.Preference('viewISBD') -%]
|
|
[%- IF ( isbdview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=[% biblio_object_id | url %]">ISBD</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF ( moredetailview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% biblio_object_id | url %]">Items</a>
|
|
</li>
|
|
|
|
[% IF ( CAN_user_circulate_manage_bookings && biblio.items.filter_by_bookable.count ) %]
|
|
[%- IF ( bookingsview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/bookings/list.pl?biblionumber=[% biblio_object_id | url %]">Bookings (<span class="bookings_count">[% biblio.bookings.filter_by_active.count | html %]</span>)</a>
|
|
</li>
|
|
[% END %]
|
|
|
|
[%- IF ( CAN_user_reserveforothers ) -%]
|
|
[%- IF ( holdsview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio_object_id | url %]">Holds ([% biblio.holds.count | html %])</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF ( EasyAnalyticalRecords ) -%]
|
|
[%- IF ( analyze ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio_object_id | url %]&analyze=1">Analytics</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF Koha.Preference('ArticleRequests') -%]
|
|
[%- IF ( article_requests_view ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/circ/request-article.pl?biblionumber=[% IF ( object ) %][% object | uri %][% ELSE %][% biblionumber | uri %][% END %]">Article requests ([% biblio.article_requests.filter_by_current.count | html %])</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF ( subscriptionsnumber ) -%]
|
|
<li>
|
|
<a href="/cgi-bin/koha/serials/serials-search.pl?searched=1&biblionumber=[% biblio_object_id | url %]">Subscriptions ([% subscriptionsnumber | html %])</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF ( issuehistoryview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=[% biblio_object_id | url %]" >Checkout history</a>
|
|
</li>
|
|
|
|
[%- IF ( CAN_user_tools_view_system_logs ) -%]
|
|
[%- IF ( logview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblio_object_id | url %]&object_type=biblio">Modification log</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF ( CAN_user_stockrotation_manage_rota_items && Koha.Preference('StockRotation') ) -%]
|
|
[%- IF ( stockrotationview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/catalogue/stockrotation.pl?biblionumber=[% biblio_object_id | uri %]">Rota</a>
|
|
</li>
|
|
[%- END -%]
|
|
|
|
[%- IF ( Koha.Preference('UseRecalls') && CAN_user_recalls ) -%]
|
|
[%- IF ( recallsview ) -%]
|
|
<li class="active">
|
|
[%- ELSE -%]
|
|
<li>
|
|
[%- END -%]
|
|
<a href="/cgi-bin/koha/recalls/request.pl?biblionumber=[% biblio_object_id | url %]">Recalls ([% biblio.recalls.search( completed => 0 ).count | html %])</a>
|
|
</li>
|
|
[%- END -%]
|
|
</ul>
|
|
</div>
|