Koha/catalogue
Galen Charlton bb75025364 Bug 7002: fix some invalid superlibrarian permission checks
This patch fixes a problem where if a staff user has superlibrarian
permissions, but also has module-specific permissions, they are
prevent from editing item records that they should be allowed to.

To test:

[1] Turn on IndependentBranches.
[2] Register a superlibrarian staff user at branch A.
[3] Give that new account at least one other module-level
    permission.  This cannot be done through the user interface,
    however, but can be done via SQL:

    UPDATE borrowers SET flags = 3 WHERE userid = 'XXX';

[4] Log in as that new superlibrarian.
[5] Bring up the item details (catalogue/moredetail.pl) page for
    an item at branch B.  Note that there is no 'Edit Item' link.
[6] Similarly, try editing that item (cataloging/additem.pl).  Note
    that the edit form forbids you from touching the item.
[7] Finally, try editing that item using the Tools | Batch item
    modification utility.  Note that it doesn't allow you to do so.
[8] Apply the patch.
[9] Repeat steps 5 through 7.  This time, the item actions should
    be allowed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes QA script and test suite.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2014-01-06 05:32:22 +00:00
..
cardview.pl
detail.pl Bug 8230: Display acquisition details on the catalogue detail page 2013-12-13 23:22:05 +00:00
export.pl Bug 9665: QA follow up fixing tabs 2013-06-17 11:25:40 -07:00
getitem-ajax.pl
image.pl Bug 8255: allow local cover images to be cached 2012-06-25 18:12:29 +02:00
imageviewer.pl Bug 5790 - Prevent deletion of records with holds 2013-02-07 07:29:45 -05:00
ISBDdetail.pl Bug 10404: add previous/next browsing to staff client 2013-08-09 15:07:39 +00:00
issuehistory.pl Bug 10868 - Use new DataTables include in catalog templates 2013-09-21 19:27:08 +00:00
labeledMARCdetail.pl Bug 10404: add previous/next browsing to staff client 2013-08-09 15:07:39 +00:00
MARCdetail.pl Bug 10404: add previous/next browsing to staff client 2013-08-09 15:07:39 +00:00
moredetail.pl Bug 7002: fix some invalid superlibrarian permission checks 2014-01-06 05:32:22 +00:00
search.pl Bug 5645: improve converting simple search to Z39.50 search 2013-10-02 14:58:54 +00:00
showmarc.pl Bug 9684 : Correct path to compact.xsl 2013-04-27 07:08:13 -04:00
updateitem.pl Bug 7639: add option to forgive overdue fines when declaring items lost 2013-09-17 15:10:46 +00:00