Kyle M Hall
fb4025b67b
The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.
Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged
Signed-off-by: Joel Sasse <jsasse@plumcreeklibrary.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
|
||
|---|---|---|
| .. | ||
| add_message.pl | ||
| bookcount.pl | ||
| branchoverdues.pl | ||
| branchtransfers.pl | ||
| circulation-home.pl | ||
| circulation.pl | ||
| del_message.pl | ||
| hold-transfer-slip.pl | ||
| offline-mf.pl | ||
| offline.pl | ||
| overdue.pl | ||
| pendingreserves.pl | ||
| renew.pl | ||
| reserveratios.pl | ||
| returns.pl | ||
| selectbranchprinter.pl | ||
| stats.pl | ||
| transfer-slip.pl | ||
| transferstoreceive.pl | ||
| view_holdsqueue.pl | ||
| waitingreserves.pl | ||
| ypattrodue-attr-search-authvalue.pl | ||
| ysearch.pl | ||