Jonathan Druart
bcab241639
If IdependentBranches is ON, to edit/delete items from other branches you need to be superlibrarian. Currently a "simple" staff user cannot edit them from the edit item page but from the catalogue detail page. The edit links should not be displayed on this table. Test plan: O/ Set IndependentBranches to "Prevent". Create a record and add 2 items: Set homebranch to L1 for item I1. Set homebranch to L2 for item I2. 1/ With a superlibrarian user, you should be able to edit both items. 2/ With a "simple" user attached to L1, you should only be able to edit I1. The edit links should not be displayed for I2. Note that the checkbox is displayed on the catalogue detail page (item list), but on the batch tools, it won't be possible to select non-modifiable items. TODO: Add a server-side check. Indeed it is still possible to edit an item if the user know the url. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
473 lines
17 KiB
Perl
Executable file
473 lines
17 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Acquisition qw( GetHistory );
|
|
use C4::Auth;
|
|
use C4::Dates qw/format_date/;
|
|
use C4::Koha;
|
|
use C4::Serials; #uses getsubscriptionfrom biblionumber
|
|
use C4::Output;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use C4::Circulation;
|
|
use C4::Branch;
|
|
use C4::Reserves;
|
|
use C4::Members; # to use GetMember
|
|
use C4::Serials;
|
|
use C4::XISBN qw(get_xisbns get_biblionumber_from_isbn);
|
|
use C4::External::Amazon;
|
|
use C4::Search; # enabled_staff_search_views
|
|
use C4::Tags qw(get_tags);
|
|
use C4::VirtualShelves;
|
|
use C4::XSLT;
|
|
use C4::Images;
|
|
use Koha::DateUtils;
|
|
use C4::HTML5Media;
|
|
use C4::CourseReserves qw(GetItemCourseReservesInfo);
|
|
use C4::Acquisition qw(GetOrdersByBiblionumber);
|
|
|
|
my $query = CGI->new();
|
|
|
|
my $analyze = $query->param('analyze');
|
|
|
|
my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user(
|
|
{
|
|
template_name => 'catalogue/detail.tt',
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { catalogue => 1 },
|
|
}
|
|
);
|
|
|
|
my $biblionumber = $query->param('biblionumber');
|
|
my $record = GetMarcBiblio($biblionumber);
|
|
|
|
if ( not defined $record ) {
|
|
# biblionumber invalid -> report and exit
|
|
$template->param( unknownbiblionumber => 1,
|
|
biblionumber => $biblionumber );
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|
|
exit;
|
|
}
|
|
|
|
if($query->cookie("holdfor")){
|
|
my $holdfor_patron = GetMember('borrowernumber' => $query->cookie("holdfor"));
|
|
$template->param(
|
|
holdfor => $query->cookie("holdfor"),
|
|
holdfor_surname => $holdfor_patron->{'surname'},
|
|
holdfor_firstname => $holdfor_patron->{'firstname'},
|
|
holdfor_cardnumber => $holdfor_patron->{'cardnumber'},
|
|
);
|
|
}
|
|
|
|
my $fw = GetFrameworkCode($biblionumber);
|
|
my $showallitems = $query->param('showallitems');
|
|
my $marcflavour = C4::Context->preference("marcflavour");
|
|
|
|
# XSLT processing of some stuff
|
|
if (C4::Context->preference("XSLTDetailsDisplay") ) {
|
|
$template->param('XSLTDetailsDisplay' =>'1',
|
|
'XSLTBloc' => XSLTParse4Display($biblionumber, $record, "XSLTDetailsDisplay") );
|
|
}
|
|
|
|
$template->param( 'SpineLabelShowPrintOnBibDetails' => C4::Context->preference("SpineLabelShowPrintOnBibDetails") );
|
|
$template->param( ocoins => GetCOinSBiblio($record) );
|
|
|
|
# some useful variables for enhanced content;
|
|
# in each case, we're grabbing the first value we find in
|
|
# the record and normalizing it
|
|
my $upc = GetNormalizedUPC($record,$marcflavour);
|
|
my $ean = GetNormalizedEAN($record,$marcflavour);
|
|
my $oclc = GetNormalizedOCLCNumber($record,$marcflavour);
|
|
my $isbn = GetNormalizedISBN(undef,$record,$marcflavour);
|
|
|
|
$template->param(
|
|
normalized_upc => $upc,
|
|
normalized_ean => $ean,
|
|
normalized_oclc => $oclc,
|
|
normalized_isbn => $isbn,
|
|
);
|
|
|
|
my $marcnotesarray = GetMarcNotes( $record, $marcflavour );
|
|
my $marcisbnsarray = GetMarcISBN( $record, $marcflavour );
|
|
my $marcauthorsarray = GetMarcAuthors( $record, $marcflavour );
|
|
my $marcsubjctsarray = GetMarcSubjects( $record, $marcflavour );
|
|
my $marcseriesarray = GetMarcSeries($record,$marcflavour);
|
|
my $marcurlsarray = GetMarcUrls ($record,$marcflavour);
|
|
my $marchostsarray = GetMarcHosts($record,$marcflavour);
|
|
my $subtitle = GetRecordValue('subtitle', $record, $fw);
|
|
|
|
# Get Branches, Itemtypes and Locations
|
|
my $branches = GetBranches();
|
|
my $itemtypes = GetItemTypes();
|
|
my $dbh = C4::Context->dbh;
|
|
|
|
my @all_items = GetItemsInfo( $biblionumber );
|
|
my @items;
|
|
for my $itm (@all_items) {
|
|
push @items, $itm unless ( $itm->{itemlost} && GetHideLostItemsPreference($borrowernumber) && !$showallitems);
|
|
}
|
|
|
|
# flag indicating existence of at least one item linked via a host record
|
|
my $hostrecords;
|
|
# adding items linked via host biblios
|
|
my @hostitems = GetHostItemsInfo($record);
|
|
if (@hostitems){
|
|
$hostrecords =1;
|
|
push (@items,@hostitems);
|
|
}
|
|
|
|
my $dat = &GetBiblioData($biblionumber);
|
|
|
|
#coping with subscriptions
|
|
my $subscriptionsnumber = CountSubscriptionFromBiblionumber($biblionumber);
|
|
my @subscriptions = SearchSubscriptions({ biblionumber => $biblionumber, orderby => 'title' });
|
|
my @subs;
|
|
|
|
foreach my $subscription (@subscriptions) {
|
|
my %cell;
|
|
my $serials_to_display;
|
|
$cell{subscriptionid} = $subscription->{subscriptionid};
|
|
$cell{subscriptionnotes} = $subscription->{internalnotes};
|
|
$cell{missinglist} = $subscription->{missinglist};
|
|
$cell{librariannote} = $subscription->{librariannote};
|
|
$cell{branchcode} = $subscription->{branchcode};
|
|
$cell{branchname} = GetBranchName($subscription->{branchcode});
|
|
$cell{hasalert} = $subscription->{hasalert};
|
|
$cell{callnumber} = $subscription->{callnumber};
|
|
$cell{closed} = $subscription->{closed};
|
|
#get the three latest serials.
|
|
$serials_to_display = $subscription->{staffdisplaycount};
|
|
$serials_to_display = C4::Context->preference('StaffSerialIssueDisplayCount') unless $serials_to_display;
|
|
$cell{staffdisplaycount} = $serials_to_display;
|
|
$cell{latestserials} =
|
|
GetLatestSerials( $subscription->{subscriptionid}, $serials_to_display );
|
|
push @subs, \%cell;
|
|
}
|
|
|
|
|
|
# Get acquisition details
|
|
if ( C4::Context->preference('AcquisitionDetails') ) {
|
|
my $orders = C4::Acquisition::GetHistory( biblionumber => $biblionumber, get_canceled_order => 1 );
|
|
$template->param(
|
|
orders => $orders,
|
|
);
|
|
}
|
|
|
|
if ( defined $dat->{'itemtype'} ) {
|
|
$dat->{imageurl} = getitemtypeimagelocation( 'intranet', $itemtypes->{ $dat->{itemtype} }{imageurl} );
|
|
}
|
|
|
|
$dat->{'count'} = scalar @all_items + @hostitems;
|
|
$dat->{'showncount'} = scalar @items + @hostitems;
|
|
$dat->{'hiddencount'} = scalar @all_items + @hostitems - scalar @items;
|
|
|
|
my $shelflocations = GetKohaAuthorisedValues('items.location', $fw);
|
|
my $collections = GetKohaAuthorisedValues('items.ccode' , $fw);
|
|
my $copynumbers = GetKohaAuthorisedValues('items.copynumber', $fw);
|
|
my (@itemloop, @otheritemloop, %itemfields);
|
|
my $norequests = 1;
|
|
my $authvalcode_items_itemlost = GetAuthValCode('items.itemlost',$fw);
|
|
my $authvalcode_items_damaged = GetAuthValCode('items.damaged', $fw);
|
|
|
|
my $analytics_flag;
|
|
my $materials_flag; # set this if the items have anything in the materials field
|
|
my $currentbranch = C4::Context->userenv ? C4::Context->userenv->{branch} : undef;
|
|
if ($currentbranch and C4::Context->preference('SeparateHoldings')) {
|
|
$template->param(SeparateHoldings => 1);
|
|
}
|
|
my $separatebranch = C4::Context->preference('SeparateHoldingsBranch') || 'homebranch';
|
|
foreach my $item (@items) {
|
|
my $itembranchcode = $item->{$separatebranch};
|
|
|
|
# can place holds defaults to yes
|
|
$norequests = 0 unless ( ( $item->{'notforloan'} > 0 ) || ( $item->{'itemnotforloan'} > 0 ) );
|
|
|
|
$item->{imageurl} = defined $item->{itype} ? getitemtypeimagelocation('intranet', $itemtypes->{ $item->{itype} }{imageurl})
|
|
: '';
|
|
|
|
foreach (qw(datelastseen onloan)) {
|
|
$item->{$_} = format_date($item->{$_});
|
|
}
|
|
$item->{datedue} = format_sqldatetime($item->{datedue});
|
|
# item damaged, lost, withdrawn loops
|
|
$item->{itemlostloop} = GetAuthorisedValues($authvalcode_items_itemlost, $item->{itemlost}) if $authvalcode_items_itemlost;
|
|
if ($item->{damaged}) {
|
|
$item->{itemdamagedloop} = GetAuthorisedValues($authvalcode_items_damaged, $item->{damaged}) if $authvalcode_items_damaged;
|
|
}
|
|
#get shelf location and collection code description if they are authorised value.
|
|
# same thing for copy number
|
|
my $shelfcode = $item->{'location'};
|
|
$item->{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) );
|
|
my $ccode = $item->{'ccode'};
|
|
$item->{'ccode'} = $collections->{$ccode} if ( defined( $ccode ) && defined($collections) && exists( $collections->{$ccode} ) );
|
|
my $copynumber = $item->{'copynumber'};
|
|
$item->{'copynumber'} = $copynumbers->{$copynumber} if ( defined($copynumber) && defined($copynumbers) && exists( $copynumbers->{$copynumber} ) );
|
|
foreach (qw(ccode enumchron copynumber stocknumber itemnotes uri)) {
|
|
$itemfields{$_} = 1 if ( $item->{$_} );
|
|
}
|
|
|
|
# checking for holds
|
|
my ($reservedate,$reservedfor,$expectedAt,undef,$wait) = GetReservesFromItemnumber($item->{itemnumber});
|
|
my $ItemBorrowerReserveInfo = GetMemberDetails( $reservedfor, 0);
|
|
|
|
if (C4::Context->preference('HidePatronName')){
|
|
$item->{'hidepatronname'} = 1;
|
|
}
|
|
|
|
if ( defined $reservedate ) {
|
|
$item->{backgroundcolor} = 'reserved';
|
|
$item->{reservedate} = format_date($reservedate);
|
|
$item->{ReservedForBorrowernumber} = $reservedfor;
|
|
$item->{ReservedForSurname} = $ItemBorrowerReserveInfo->{'surname'};
|
|
$item->{ReservedForFirstname} = $ItemBorrowerReserveInfo->{'firstname'};
|
|
$item->{ExpectedAtLibrary} = $branches->{$expectedAt}{branchname};
|
|
$item->{Reservedcardnumber} = $ItemBorrowerReserveInfo->{'cardnumber'};
|
|
# Check waiting status
|
|
$item->{waitingdate} = $wait;
|
|
}
|
|
|
|
|
|
# Check the transit status
|
|
my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($item->{itemnumber});
|
|
if ( defined( $transfertwhen ) && ( $transfertwhen ne '' ) ) {
|
|
$item->{transfertwhen} = format_date($transfertwhen);
|
|
$item->{transfertfrom} = $branches->{$transfertfrom}{branchname};
|
|
$item->{transfertto} = $branches->{$transfertto}{branchname};
|
|
$item->{nocancel} = 1;
|
|
}
|
|
|
|
# item has a host number if its biblio number does not match the current bib
|
|
if ($item->{biblionumber} ne $biblionumber){
|
|
$item->{hostbiblionumber} = $item->{biblionumber};
|
|
$item->{hosttitle} = GetBiblioData($item->{biblionumber})->{title};
|
|
}
|
|
|
|
#count if item is used in analytical bibliorecords
|
|
my $countanalytics= GetAnalyticsCount($item->{itemnumber});
|
|
if ($countanalytics > 0){
|
|
$analytics_flag=1;
|
|
$item->{countanalytics} = $countanalytics;
|
|
}
|
|
|
|
if (defined($item->{'materials'}) && $item->{'materials'} =~ /\S/){
|
|
$materials_flag = 1;
|
|
}
|
|
|
|
if ( C4::Context->preference('UseCourseReserves') ) {
|
|
$item->{'course_reserves'} = GetItemCourseReservesInfo( itemnumber => $item->{'itemnumber'} );
|
|
}
|
|
|
|
if ( C4::Context->preference('IndependentBranches') ) {
|
|
my $userenv = C4::Context->userenv();
|
|
if ( not C4::Context->IsSuperLibrarian()
|
|
and $userenv->{branch} ne $item->{homebranch} ) {
|
|
$item->{cannot_be_edited} = 1;
|
|
}
|
|
}
|
|
|
|
if ($currentbranch and $currentbranch ne "NO_LIBRARY_SET"
|
|
and C4::Context->preference('SeparateHoldings')) {
|
|
if ($itembranchcode and $itembranchcode eq $currentbranch) {
|
|
push @itemloop, $item;
|
|
} else {
|
|
push @otheritemloop, $item;
|
|
}
|
|
} else {
|
|
push @itemloop, $item;
|
|
}
|
|
}
|
|
|
|
# Display only one tab if one items list is empty
|
|
if (scalar(@itemloop) == 0 || scalar(@otheritemloop) == 0) {
|
|
$template->param(SeparateHoldings => 0);
|
|
if (scalar(@itemloop) == 0) {
|
|
@itemloop = @otheritemloop;
|
|
}
|
|
}
|
|
|
|
$template->param( norequests => $norequests );
|
|
$template->param(
|
|
MARCNOTES => $marcnotesarray,
|
|
MARCSUBJCTS => $marcsubjctsarray,
|
|
MARCAUTHORS => $marcauthorsarray,
|
|
MARCSERIES => $marcseriesarray,
|
|
MARCURLS => $marcurlsarray,
|
|
MARCISBNS => $marcisbnsarray,
|
|
MARCHOSTS => $marchostsarray,
|
|
subtitle => $subtitle,
|
|
itemdata_ccode => $itemfields{ccode},
|
|
itemdata_enumchron => $itemfields{enumchron},
|
|
itemdata_uri => $itemfields{uri},
|
|
itemdata_copynumber => $itemfields{copynumber},
|
|
itemdata_stocknumber => $itemfields{stocknumber},
|
|
volinfo => $itemfields{enumchron},
|
|
itemdata_itemnotes => $itemfields{itemnotes},
|
|
z3950_search_params => C4::Search::z3950_search_args($dat),
|
|
hostrecords => $hostrecords,
|
|
analytics_flag => $analytics_flag,
|
|
C4::Search::enabled_staff_search_views,
|
|
materials => $materials_flag,
|
|
);
|
|
|
|
if (C4::Context->preference("AlternateHoldingsField") && scalar @items == 0) {
|
|
my $fieldspec = C4::Context->preference("AlternateHoldingsField");
|
|
my $subfields = substr $fieldspec, 3;
|
|
my $holdingsep = C4::Context->preference("AlternateHoldingsSeparator") || ' ';
|
|
my @alternateholdingsinfo = ();
|
|
my @holdingsfields = $record->field(substr $fieldspec, 0, 3);
|
|
|
|
for my $field (@holdingsfields) {
|
|
my %holding = ( holding => '' );
|
|
my $havesubfield = 0;
|
|
for my $subfield ($field->subfields()) {
|
|
if ((index $subfields, $$subfield[0]) >= 0) {
|
|
$holding{'holding'} .= $holdingsep if (length $holding{'holding'} > 0);
|
|
$holding{'holding'} .= $$subfield[1];
|
|
$havesubfield++;
|
|
}
|
|
}
|
|
if ($havesubfield) {
|
|
push(@alternateholdingsinfo, \%holding);
|
|
}
|
|
}
|
|
|
|
$template->param(
|
|
ALTERNATEHOLDINGS => \@alternateholdingsinfo,
|
|
);
|
|
}
|
|
|
|
my @results = ( $dat, );
|
|
foreach ( keys %{$dat} ) {
|
|
$template->param( "$_" => defined $dat->{$_} ? $dat->{$_} : '' );
|
|
}
|
|
|
|
# does not work: my %views_enabled = map { $_ => 1 } $template->query(loop => 'EnableViews');
|
|
# method query not found?!?!
|
|
$template->param( AmazonTld => get_amazon_tld() ) if ( C4::Context->preference("AmazonCoverImages"));
|
|
$template->param(
|
|
itemloop => \@itemloop,
|
|
otheritemloop => \@otheritemloop,
|
|
biblionumber => $biblionumber,
|
|
($analyze? 'analyze':'detailview') =>1,
|
|
subscriptions => \@subs,
|
|
subscriptionsnumber => $subscriptionsnumber,
|
|
subscriptiontitle => $dat->{title},
|
|
searchid => $query->param('searchid'),
|
|
);
|
|
|
|
# $debug and $template->param(debug_display => 1);
|
|
|
|
# Lists
|
|
|
|
if (C4::Context->preference("virtualshelves") ) {
|
|
$template->param( 'GetShelves' => GetBibliosShelves( $biblionumber ) );
|
|
}
|
|
|
|
# XISBN Stuff
|
|
if (C4::Context->preference("FRBRizeEditions")==1) {
|
|
eval {
|
|
$template->param(
|
|
XISBNS => get_xisbns($isbn)
|
|
);
|
|
};
|
|
if ($@) { warn "XISBN Failed $@"; }
|
|
}
|
|
|
|
if ( C4::Context->preference("LocalCoverImages") == 1 ) {
|
|
my @images = ListImagesForBiblio($biblionumber);
|
|
$template->{VARS}->{localimages} = \@images;
|
|
}
|
|
|
|
# HTML5 Media
|
|
if ( (C4::Context->preference("HTML5MediaEnabled") eq 'both') or (C4::Context->preference("HTML5MediaEnabled") eq 'staff') ) {
|
|
$template->param( C4::HTML5Media->gethtml5media($record));
|
|
}
|
|
|
|
# Displaying tags
|
|
|
|
my $tag_quantity;
|
|
if (C4::Context->preference('TagsEnabled') and $tag_quantity = C4::Context->preference('TagsShowOnDetail')) {
|
|
$template->param(
|
|
TagsEnabled => 1,
|
|
TagsShowOnDetail => $tag_quantity
|
|
);
|
|
$template->param(TagLoop => get_tags({biblionumber=>$biblionumber, approved=>1,
|
|
'sort'=>'-weight', limit=>$tag_quantity}));
|
|
}
|
|
|
|
#we only need to pass the number of holds to the template
|
|
my $holds = C4::Reserves::GetReservesFromBiblionumber({ biblionumber => $biblionumber, all_dates => 1 });
|
|
$template->param( holdcount => scalar ( @$holds ) );
|
|
|
|
my $StaffDetailItemSelection = C4::Context->preference('StaffDetailItemSelection');
|
|
if ($StaffDetailItemSelection) {
|
|
# Only enable item selection if user can execute at least one action
|
|
if (
|
|
$flags->{superlibrarian}
|
|
|| (
|
|
ref $flags->{tools} eq 'HASH' && (
|
|
$flags->{tools}->{items_batchmod} # Modify selected items
|
|
|| $flags->{tools}->{items_batchdel} # Delete selected items
|
|
)
|
|
)
|
|
|| ( ref $flags->{tools} eq '' && $flags->{tools} )
|
|
)
|
|
{
|
|
$template->param(
|
|
StaffDetailItemSelection => $StaffDetailItemSelection );
|
|
}
|
|
}
|
|
|
|
my @allorders_using_biblio = GetOrdersByBiblionumber ($biblionumber);
|
|
my @deletedorders_using_biblio;
|
|
my @orders_using_biblio;
|
|
my @baskets_orders;
|
|
my @baskets_deletedorders;
|
|
|
|
foreach my $myorder (@allorders_using_biblio) {
|
|
my $basket = $myorder->{'basketno'};
|
|
if ((defined $myorder->{'datecancellationprinted'}) and ($myorder->{'datecancellationprinted'} ne '0000-00-00') ){
|
|
push @deletedorders_using_biblio, $myorder;
|
|
unless (grep(/^$basket$/, @baskets_deletedorders)){
|
|
push @baskets_deletedorders,$myorder->{'basketno'};
|
|
}
|
|
}
|
|
else {
|
|
push @orders_using_biblio, $myorder;
|
|
unless (grep(/^$basket$/, @baskets_orders)){
|
|
push @baskets_orders,$myorder->{'basketno'};
|
|
}
|
|
}
|
|
}
|
|
|
|
my $count_orders_using_biblio = scalar @orders_using_biblio ;
|
|
$template->param (countorders => $count_orders_using_biblio);
|
|
|
|
my $count_deletedorders_using_biblio = scalar @deletedorders_using_biblio ;
|
|
$template->param (countdeletedorders => $count_deletedorders_using_biblio);
|
|
|
|
$template->param (basketsorders => \@baskets_orders);
|
|
$template->param (basketsdeletedorders => \@baskets_deletedorders);
|
|
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|