Koha/rotating_collections/transferCollection.pl
Fridolyn SOMERS 76c3649db3 Bug 9605: rotating collections permissions are wrong
In tools / rotating collections, permissions are 'parameters => 1'.
But there is a dedicated permission : tools => rotating_collections.

Test plan :
- Disable tools/rotating_collections permission to your connected user
- Check you dont have access to those pages :
  rotating_collections/addItems.pl
  rotating_collections/editCollections.pl
  rotating_collections/rotatingCollections.pl
  rotating_collections/transferCollection.pl
- Enable tools/rotating_collections permission to your connected user
- Check you have access to above pages

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes wrong permission on rotating collection related pages.
This will allow to block access to those.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-03-30 22:11:05 -04:00

84 lines
2.8 KiB
Perl
Executable file

#!/usr/bin/perl
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
#
use strict;
#use warnings; FIXME - Bug 2505
require Exporter;
use C4::Output;
use C4::Auth;
use C4::Context;
use C4::RotatingCollections;
use C4::Branch;
use CGI;
my $query = new CGI;
my $colId = $query->param('colId');
my $toBranch = $query->param('toBranch');
my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "rotating_collections/transferCollection.tmpl",
query => $query,
type => "intranet",
authnotrequired => 0,
flagsrequired => { tools => 'rotating_collections' },
debug => 1,
});
## Transfer collection
my ( $success, $errorCode, $errorMessage );
if ( $toBranch ) {
( $success, $errorCode, $errorMessage ) = TransferCollection( $colId, $toBranch );
if ( $success ) {
$template->param( transferSuccess => 1 );
} else {
$template->param( transferFailure => 1,
errorCode => $errorCode,
errorMessage => $errorMessage
);
}
}
## Set up the toBranch select options
my $branches = GetBranches();
my @branchoptionloop;
foreach my $br (keys %$branches) {
my %branch;
$branch{code}=$br;
$branch{name}=$branches->{$br}->{'branchname'};
push (@branchoptionloop, \%branch);
}
## Get data about collection
my ( $colId, $colTitle, $colDesc, $colBranchcode ) = GetCollection( $colId );
$template->param(
intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
intranetstylesheet => C4::Context->preference("intranetstylesheet"),
IntranetNav => C4::Context->preference("IntranetNav"),
colId => $colId,
colTitle => $colTitle,
colDesc => $colDesc,
colBranchcode => $colBranchcode,
branchoptionloop => \@branchoptionloop
);
output_html_with_http_headers $query, $cookie, $template->output;