Koha/admin/finesrules.pl
Galen Charlton 579a227228 kohabug 2022 - fixed fine and issuing rules editors
Because of the way that the older fine and issuing
rule editors generate the HTML form, if a branch code,
patron category code, or item type code happened to have a
'-' or '.', the HTML form would not be parsed properly, thus
adding an implicit (rather than explicit) limit on the
characters allowed in one of those codes.

This fix removes this limitation by Base64-encoding the codes
when constructing the names for the <input> elements.

Two functions are added to C4::Koha:

  str_to_base64() - UTF-8 string to Base64
  base64_to_str() - reverse

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-04-21 11:17:52 -05:00

151 lines
5 KiB
Perl
Executable file

#!/usr/bin/perl
# Copyright 2000-2002 Katipo Communications
#
# This file is part of Koha.
#
# Koha is free software; you can redistribute it and/or modify it under the
# terms of the GNU General Public License as published by the Free Software
# Foundation; either version 2 of the License, or (at your option) any later
# version.
#
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along with
# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
# Suite 330, Boston, MA 02111-1307 USA
use strict;
use CGI;
use C4::Context;
use C4::Auth;
use C4::Output;
use C4::Koha;
use C4::Branch; # GetBranches
my $input = new CGI;
my $dbh = C4::Context->dbh;
my $type=$input->param('type');
my $branch = $input->param('branch');
$branch="*" unless $branch;
my $op = $input->param('op');
# my $flagsrequired;
# $flagsrequired->{circulation}=1;
my ($template, $loggedinuser, $cookie)
= get_template_and_user({template_name => "admin/finesrules.tmpl",
query => $input,
type => "intranet",
authnotrequired => 0,
flagsrequired => {parameters => 1},
debug => 1,
});
# save the values entered
if ($op eq 'save') {
my @names=$input->param();
my $sth_search = $dbh->prepare("SELECT count(*) AS total FROM issuingrules WHERE branchcode=? AND categorycode=? AND itemtype=?");
my $sth_Finsert = $dbh->prepare("INSERT INTO issuingrules (branchcode,categorycode,itemtype,fine,firstremind,chargeperiod) VALUES (?,?,?,?,?,?)");
my $sth_Fupdate=$dbh->prepare("UPDATE issuingrules SET fine=?,firstremind=?,chargeperiod=? WHERE branchcode=? AND categorycode=? AND itemtype=?");
my $sth_Fdelete=$dbh->prepare("DELETE FROM issuingrules WHERE branchcode=? AND categorycode=? AND itemtype=? AND issuelength=0");
foreach my $key (@names){
# FINES
if ($key =~ /F-(.*)-(.*)-(.*)/) {
my $br = base64_to_str($1); # branch
my $bor = base64_to_str($2); # borrower category
my $cat = base64_to_str($3); # item type
my $data=$input->param($key);
my ($fine,$firstremind,$chargeperiod)=split(',',$data);
$bor="*" unless ($bor);
$cat="*" unless ($cat);
$sth_search->execute($br,$bor,$cat);
my $res = $sth_search->fetchrow_hashref();
if ($res->{total} >0) {
$sth_Fupdate->execute($fine,$firstremind,$chargeperiod,$br,$bor,$cat);
} else {
$sth_Finsert->execute($br,$bor,$cat,$fine,$firstremind,$chargeperiod);
}
}
}
}
my $branches = GetBranches;
my @branchloop;
foreach my $thisbranch (keys %$branches) {
my $selected = 1 if $thisbranch eq $branch;
my %row =(value => $thisbranch,
selected => $selected,
branchname => $branches->{$thisbranch}->{'branchname'},
);
push @branchloop, \%row;
}
my $sth=$dbh->prepare("Select description,categorycode from categories order by description");
$sth->execute;
my @trow3;
my @title_loop;
# my $i=0;
while (my $data=$sth->fetchrow_hashref){
my %row = (in_title => $data->{'description'});
push @title_loop,\%row;
push @trow3,$data->{'categorycode'};
}
my %row = (in_title => "*");
push @title_loop, \%row;
push @trow3,'*';
$sth->finish;
$sth=$dbh->prepare("Select description,itemtype from itemtypes order by description");
$sth->execute;
# $i=0;
my $toggle= 1;
my @row_loop;
my @itemtypes;
while (my $row=$sth->fetchrow_hashref){
push @itemtypes,\$row;
}
foreach my $data (@itemtypes) {
my @trow2;
my @cell_loop;
if ( $toggle eq 1 ) {
$toggle = 0;
} else {
$toggle = 1;
}
for (my $i=0;$i<=$#trow3;$i++){
my $sth2=$dbh->prepare("SELECT * FROM issuingrules WHERE branchcode=? AND categorycode=? AND itemtype=?");
$sth2->execute($branch,$trow3[$i],$$data->{'itemtype'});
my $dat=$sth2->fetchrow_hashref;
$sth2->finish;
my $fine=$dat->{'fine'};
# remove trailing 0s
$fine =~ s/\.*0*$//g;
my $finesvalue;
$finesvalue= "$fine,$dat->{'firstremind'},$dat->{'chargeperiod'}" if $fine ne '';
my $finesname = join("-", "F", map { str_to_base64($_) } ($branch, $trow3[$i], $$data->{'itemtype'}));
my %row = (finesname=> $finesname,
finesvalue => $finesvalue,
toggle => $toggle,
);
push @cell_loop,\%row;
}
my %row = (categorycode => $$data->{description},
cell =>\@cell_loop,
);
push @row_loop, \%row;
}
$sth->finish;
$template->param(title => \@title_loop,
row => \@row_loop,
branchloop => \@branchloop,
branch => $branch,
);
output_html_with_http_headers $input, $cookie, $template->output;