Jonathan Druart
8e7718ee65
The JOIN done by this subroutine are not always useful (depending on item-level_itypes). They also search with LIKE when it is not needed. Since we have now Koha::Items, we can replace this subroutine with a call to Koha::Items->search with the correct parameters. A change in previous behaviours can happen: If a items.itemlost contains a value that is not defined as a LOST authorised value, the item will not be displayed. I think it's the expected behaviour, even if it should not happen in correctly configured installations. Test plan: To test with item-level_itypes set to item and biblio: List the lost items you have on your system, using the different filters available. The result table should contain the correct item's info. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
101 lines
2.7 KiB
Perl
Executable file
101 lines
2.7 KiB
Perl
Executable file
#!/usr/bin/perl
|
|
|
|
# Copyright Liblime 2007
|
|
# Copyright Biblibre 2009
|
|
#
|
|
# This file is part of Koha.
|
|
#
|
|
# Koha is free software; you can redistribute it and/or modify it
|
|
# under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Koha is distributed in the hope that it will be useful, but
|
|
# WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Koha; if not, see <http://www.gnu.org/licenses>.
|
|
|
|
|
|
=head1 itemslost
|
|
|
|
This script displays lost items.
|
|
|
|
=cut
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use CGI qw ( -utf8 );
|
|
use C4::Auth;
|
|
use C4::Output;
|
|
use C4::Biblio;
|
|
use C4::Items;
|
|
use Koha::DateUtils;
|
|
|
|
my $query = new CGI;
|
|
my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
|
|
{
|
|
template_name => "reports/itemslost.tt",
|
|
query => $query,
|
|
type => "intranet",
|
|
authnotrequired => 0,
|
|
flagsrequired => { reports => '*' },
|
|
debug => 1,
|
|
}
|
|
);
|
|
|
|
my $params = $query->Vars;
|
|
my $get_items = $params->{'get_items'};
|
|
|
|
if ($get_items) {
|
|
my $branchfilter = $params->{'branchfilter'} || undef;
|
|
my $barcodefilter = $params->{'barcodefilter'} || undef;
|
|
my $itemtypesfilter = $params->{'itemtypesfilter'} || undef;
|
|
my $loststatusfilter = $params->{'loststatusfilter'} || undef;
|
|
|
|
my $params = {
|
|
( $branchfilter ? ( homebranch => $branchfilter ) : () ),
|
|
(
|
|
$loststatusfilter
|
|
? ( itemlost => $loststatusfilter )
|
|
: ( itemlost => { '!=' => 0 } )
|
|
),
|
|
( $barcodefilter ? ( barcode => { like => "%$barcodefilter%" } ) : () ),
|
|
};
|
|
|
|
my $attributes;
|
|
if ($itemtypesfilter) {
|
|
if ( C4::Context->preference('item-level_itypes') ) {
|
|
$params->{itype} = $itemtypesfilter;
|
|
}
|
|
else {
|
|
# We want a join on biblioitems
|
|
$attributes = { join => 'biblioitem' };
|
|
$params->{'biblioitem.itemtype'} = $itemtypesfilter;
|
|
}
|
|
}
|
|
|
|
my $items = Koha::Items->search( $params, $attributes );
|
|
|
|
$template->param(
|
|
items => $items,
|
|
get_items => $get_items,
|
|
);
|
|
}
|
|
|
|
# getting all itemtypes
|
|
my $itemtypes = Koha::ItemTypes->search_with_localization;
|
|
|
|
# get lost statuses
|
|
my $lost_status_loop = C4::Koha::GetAuthorisedValues( 'LOST' );
|
|
|
|
$template->param(
|
|
itemtypes => $itemtypes,
|
|
loststatusloop => $lost_status_loop,
|
|
);
|
|
|
|
# writing the template
|
|
output_html_with_http_headers $query, $cookie, $template->output;
|